MB-68126: Don't try auto failover if final list is empty

boparai11 · boparai11 · commit ae23b9388246 · 2025-08-15T23:19:39.000Z
Change-Id: Id7cfca14bff3e16ba02204ed97a9d5d93f45a8df Reviewed-on: https://review.couchbase.org/c/ns_server/+/232327 Reviewed-by: Neelima Premsankar <neelima.premsankar@couchbase.com> Tested-by: Navdeep S Boparai <navdeep.boparai@couchbase.com>
diff --git a/apps/ns_server/src/auto_failover.erl b/apps/ns_server/src/auto_failover.erl
@@ -665,6 +665,9 @@ maybe_report_max_node_reached(AllNodes, NotFailedOver, ErrMsg, S) ->
             S
     end.
 
+trigger_autofailover([], _NodeStatuses, _DownNodeNames, _DownNodes, _Opts,
+                     State) ->
+    State;
 trigger_autofailover(Nodes, NodeStatuses, DownNodeNames, DownNodes, Opts,
                      State) ->
     FailoverReasons = failover_reasons(Nodes, DownNodes, NodeStatuses),

Original file line number	Diff line number	Diff line change
`@@ -665,6 +665,9 @@ maybe_report_max_node_reached(AllNodes, NotFailedOver, ErrMsg, S) ->`
`665`	`665`	`S`
`666`	`666`	`end.`
`667`	`667`
	`668`	`+trigger_autofailover([], _NodeStatuses, _DownNodeNames, _DownNodes, _Opts,`
	`669`	`+ State) ->`
	`670`	`+ State;`
`668`	`671`	`trigger_autofailover(Nodes, NodeStatuses, DownNodeNames, DownNodes, Opts,`
`669`	`672`	`State) ->`
`670`	`673`	`FailoverReasons = failover_reasons(Nodes, DownNodes, NodeStatuses),`