Skip to content

Commit c11a401

Browse files
anuthanAliaksey Artamonau
authored andcommitted
Introduce backfill_phase_started into master activity events.
Helps with, MB-30803: Collect rebalance related stats Part of EPIC, MB-30894: Rebalance visibility and reporting Change-Id: If529691a76b0e5b130d81214255f45a3ecd53563 Reviewed-on: http://review.couchbase.org/101819 Reviewed-by: Aliaksey Artamonau <[email protected]> Tested-by: Abhijeeth Nuthan <[email protected]>
1 parent 261ac6a commit c11a401

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

src/master_activity_events.erl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
note_seqno_waiting_ended/4,
4141
note_takeover_started/4,
4242
note_takeover_ended/4,
43+
note_backfill_phase_started/2,
4344
note_backfill_phase_ended/2,
4445
note_wait_index_updated_started/3,
4546
note_wait_index_updated_ended/3,
@@ -163,6 +164,9 @@ note_takeover_started(BucketName, VBucket, OldMaster, NewMaster) ->
163164
note_takeover_ended(BucketName, VBucket, OldMaster, NewMaster) ->
164165
submit_cast({takeover_ended, BucketName, VBucket, OldMaster, NewMaster}).
165166

167+
note_backfill_phase_started(BucketName, VBucket) ->
168+
submit_cast({backfill_phase_started, BucketName, VBucket}).
169+
166170
note_backfill_phase_ended(BucketName, VBucket) ->
167171
submit_cast({backfill_phase_ended, BucketName, VBucket}).
168172

@@ -550,6 +554,12 @@ event_to_jsons({TS, indexing_initated, BucketName, Node, VBucket}) ->
550554
{bucket, BucketName},
551555
{vbucket, VBucket}])];
552556

557+
event_to_jsons({TS, backfill_phase_started, BucketName, VBucket}) ->
558+
[format_simple_plist_as_json([{type, backfillPhaseStarted},
559+
{ts, misc:time_to_epoch_float(TS)},
560+
{bucket, BucketName},
561+
{vbucket, VBucket}])];
562+
553563
event_to_jsons({TS, backfill_phase_ended, BucketName, VBucket}) ->
554564
[format_simple_plist_as_json([{type, backfillPhaseEnded},
555565
{ts, misc:time_to_epoch_float(TS)},

src/ns_single_vbucket_mover.erl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ mover_inner_dcp(Parent, Bucket, VBucket,
177177
%% ep-engine guarantees that it can support indexing
178178
maybe_initiate_indexing(Bucket, Parent, JustBackfillNodes, ReplicaNodes, VBucket, IndexAware),
179179

180+
master_activity_events:note_backfill_phase_started(Bucket, VBucket),
180181
%% wait for backfill on all the opened streams
181182
AllBuiltNodes = JustBackfillNodes ++ ReplicaNodes,
182183
wait_dcp_data_move(Bucket, Parent, OldMaster, AllBuiltNodes, VBucket),

0 commit comments

Comments
 (0)