Skip to content

Commit cd7f565

Browse files
MB-47559: replace mnCollectionsService with mnKeyspaceSelectorService
in places where we call createCollectionSelector This method has been moved into mnKeyspaceSelectorService, so we should inject this service to be able to use the method. Change-Id: I6271822928a499e85ed2bbc50a50bf57cf983d49 Reviewed-on: http://review.couchbase.org/c/ns_server/+/158818 Well-Formed: Build Bot <[email protected]> Reviewed-by: Matthew <[email protected]> Tested-by: Pavel Blagodov <[email protected]>
1 parent 6f64305 commit cd7f565

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

priv/public/ui/app/components/directives/mn_user_roles_select_controller.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ function mnUserRolesSelectDirective() {
6666
}
6767
}
6868

69-
function mnUserRolesSelectFormDirective(mnCollectionsServiceDowngrade) {
69+
function mnUserRolesSelectFormDirective(mnKeyspaceSelectorServiceDowngrade) {
7070
var mnUserRolesSelectForm = {
7171
restrict: 'AE',
7272
templateUrl: 'app/components/directives/mn_user_roles_select_form.html',
@@ -84,7 +84,7 @@ function mnUserRolesSelectFormDirective(mnCollectionsServiceDowngrade) {
8484
let params = $scope.item.params.map(v => v.split("_")[0]);
8585

8686
$scope.mnCollectionSelectorService =
87-
mnCollectionsServiceDowngrade.createCollectionSelector({
87+
mnKeyspaceSelectorServiceDowngrade.createCollectionSelector({
8888
isRolesMode: true,
8989
component: {mnOnDestroy},
9090
buckets: $scope.state.parameters[$scope.item.params[0]],

priv/public/ui/app/mn.app.imports.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import * as pluggableUIsModules from '/ui/pluggable-uis.js';
2424
import {MnPoolsServiceModule} from './mn.pools.service.js';
2525
import {MnAdminServiceModule} from './mn.admin.service.js';
2626
import {MnCollectionsServiceModule} from './mn.collections.service.js';
27+
import {MnKeyspaceSelectorServiceModule} from "./mn.keyspace.selector.service.js";
2728

2829
import {MnKeyspaceSelectorModule} from './mn.keyspace.selector.module.js';
2930

@@ -227,6 +228,7 @@ let mnAppImports = [
227228
MnCollectionsServiceModule,
228229
MnAdminServiceModule,
229230
MnPoolsServiceModule,
231+
MnKeyspaceSelectorServiceModule,
230232
MnElementCraneModule.forRoot(),
231233
UIRouterUpgradeModule.forRoot({
232234
states: [

priv/public/ui/app/mn.keyspace.selector.downgrade.module.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ import angular from "../web_modules/angular.js";
1212
import {downgradeComponent,
1313
downgradeInjectable} from"../web_modules/@angular/upgrade/static.js";
1414
import {MnKeyspaceSelectorComponent} from "./mn.keyspace.selector.component.js";
15-
import {MnCollectionsService} from './mn.collections.service.js';
15+
import {MnKeyspaceSelectorService} from './mn.keyspace.selector.service.js';
1616
import {Subject, of} from "../web_modules/rxjs.js";
1717

1818
export default "mnKeyspaceSelectorDowngradeModule";
1919

2020
angular
2121
.module('mnKeyspaceSelectorDowngradeModule', [])
22-
.factory('mnCollectionsServiceDowngrade', downgradeInjectable(MnCollectionsService))
22+
.factory('mnKeyspaceSelectorServiceDowngrade', downgradeInjectable(MnKeyspaceSelectorService))
2323
.directive('mnKeyspaceSelectorDowngrade', downgradeComponent({
2424
component: MnKeyspaceSelectorComponent
2525
}));

priv/public/ui/app/mn.xdcr.module.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { MnSharedModule } from './mn.shared.module.js';
1818
import { MnInputFilterModule } from './mn.input.filter.module.js';
1919
import { MnPipesModule } from './mn.pipes.module.js';
2020
import { MnKeyspaceSelectorModule } from "./mn.keyspace.selector.module.js";
21-
import { MnKeyspaceSelectorServiceModule } from "./mn.keyspace.selector.service.js";
2221
import { MnSelectModule } from './mn.select.module.js';
2322

2423
import { MnXDCRComponent } from "./mn.xdcr.component.js";
@@ -147,7 +146,6 @@ class MnXDCRModule {
147146
MnInputFilterModule,
148147
MnElementCraneModule,
149148
MnKeyspaceSelectorModule,
150-
MnKeyspaceSelectorServiceModule,
151149

152150
MnSharedModule,
153151
MnPipesModule,

priv/public/ui/app/mn_admin/mn_gsi_controller.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ function configure($stateProvider, $transitionsProvider) {
140140
}
141141
});
142142
}
143-
function mnGsiController($scope, mnGsiService, mnPoller, $state, mnCollectionsServiceDowngrade,
144-
poolDefault) {
143+
function mnGsiController($scope, mnGsiService, mnPoller, $state,
144+
mnKeyspaceSelectorServiceDowngrade, poolDefault) {
145145
var vm = this;
146146

147147
vm.setIndexesView = setIndexesView;
@@ -184,7 +184,7 @@ function mnGsiController($scope, mnGsiService, mnPoller, $state, mnCollectionsSe
184184
}
185185

186186
vm.mnCollectionSelectorService =
187-
mnCollectionsServiceDowngrade.createCollectionSelector({
187+
mnKeyspaceSelectorServiceDowngrade.createCollectionSelector({
188188
component: {mnOnDestroy},
189189
steps: ["bucket", "scope"]
190190
});

0 commit comments

Comments
 (0)