MB-48438 [BP] Add bucketType to terse bucket info

Backporting change for MB-46625 to add the bucketType to the results of
the terse bucket info.

$ curl -s -u Administrator:asdasd localhost:9000/pools/default/b/memcBucket \
         | jq | grep bucketType
  "bucketType": "memcached",
$ curl -s -u Administrator:asdasd localhost:9000/pools/default/b/travel-sample \
         | jq | grep bucketType
  "bucketType": "membase",
$ curl -s -u Administrator:asdasd localhost:9000/pools/default/b/ephBucket \
         | jq | grep bucketType
  "bucketType": "ephemeral",

Change-Id: I2ad19b9c3f056315b21c79463ce6f00a3b9d014e
Reviewed-on: http://review.couchbase.org/c/ns_server/+/161435
Well-Formed: Restriction Checker
Well-Formed: Build Bot <[email protected]>
Tested-by: Steve Watanabe <[email protected]>
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Finlay <[email protected]>

Author: stevewatanabe

src/bucket_info_cache.erl

@@ -184,6 +184,7 @@ node_bucket_info(Node, Config, Snapshot, Bucket, BucketUUID, BucketConfig) ->
 build_short_bucket_info(Id, BucketConfig, Snapshot) ->
     BucketUUID = ns_bucket:uuid(Id, Snapshot),
     [build_name_and_locator(Id, BucketConfig),
+     {bucketType, ns_bucket:external_bucket_type(BucketConfig)},
      {uuid, BucketUUID},
      {uri, build_pools_uri(["buckets", Id], BucketUUID)},
      {streamingUri, build_pools_uri(["bucketsStreaming", Id], BucketUUID)},

src/menelaus_web_buckets.erl

@@ -246,7 +246,6 @@ build_bucket_info(Id, Ctx, InfoLevel, MayExposeAuth, SkipMap) ->
         [bucket_info_cache:build_vbucket_map(
            menelaus_web_node:get_local_addr(Ctx), BucketConfig)
          || not SkipMap],
-        {bucketType, ns_bucket:external_bucket_type(BucketConfig)},
         {authType, misc:expect_prop_value(auth_type, BucketConfig)},
         {localRandomKeyUri,
          bucket_info_cache:build_pools_uri(["buckets", Id, "localRandomKey"])},