MB-47751: set eslint array-callback-return to error

Change-Id: If5dc72c24ea985202dc2cd72b9e1dd37165b76ed
Reviewed-on: http://review.couchbase.org/c/ns_server/+/159866
Well-Formed: Build Bot <[email protected]>
Tested-by: Pavel Blagodov <[email protected]>
Reviewed-by: Raluca Lupu <[email protected]>

Author: pavel-blagodov

priv/public/ui/.eslintrc.json

@@ -13,7 +13,7 @@
     "accessor-pairs": "error",
     "array-bracket-newline": ["error", "consistent"],
     "array-bracket-spacing": ["error", "never"],
-    "array-callback-return": "off",
+    "array-callback-return": "error",
     "array-element-newline": "off",
     "arrow-body-style": "off",
     "arrow-parens": "off",

priv/public/ui/app/mn_admin/mn_settings_notifications_service.js

@@ -133,6 +133,7 @@ angular.module('mnSettingsNotificationsService', [
           if ((levels.length == 4) && (levels[3] == "svc")) {
             return levels[0].startsWith(levels[1] + "-");
           }
+          return false;
         }),
         numNodes: poolsDefault.nodes.length, //Total number of nodes
         isEnterpriseEdition: pools.isEnterprise,

priv/public/ui/app/mn_admin/mn_statistics_controller.js

@@ -425,6 +425,7 @@ function mnStatisticsNewController($scope, mnStatisticsNewService, $state, $http
                 block.statKeyPrefix = name.join("/") + "/";
                 return true;
               }
+              return false;
             });
           });
       })