Skip to content

Commit f217095

Browse files
committed
AppTelemetryTests: Catch connection error less restrictively
Sometimes rather than BrokenPipeError we can see a ConnectionResetError disconnect_on_disable_test... failed ConnectionResetError: [Errno 104] Connection reset by peer (seen in: https://cv.jenkins.couchbase.com/job/ns-server-cluster-tests/14389/) Until we support the proper websocket close handshake, make the check less restrictive, to avoid intermittant test failures. Change-Id: Ie6cb6e34f709300d45d114491bc10887887d8567 Reviewed-on: https://review.couchbase.org/c/ns_server/+/224049 Tested-by: Peter Searby <[email protected]> Reviewed-by: Timofey Barmin <[email protected]>
1 parent a9c172e commit f217095

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cluster_tests/testsets/app_telemetry_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def disconnect_on_disable_test(self):
175175
try:
176176
frame = conn.get_next_frame()
177177
testlib.assert_eq(frame.opcode, Opcode.CLOSE)
178-
except BrokenPipeError:
178+
except ConnectionError:
179179
# See MB-65238. The websocket may be closed before receiving
180180
# the response to the CLOSE message, which is sent in
181181
# WebsocketConnection._get_and_send_data

0 commit comments

Comments
 (0)