MB-47561 do not call ns_config:get from ns_bucket:failover_warnings

Change-Id: I828e687fc1abb849711dfa18f09ebc4305dbd92a
Reviewed-on: http://review.couchbase.org/c/ns_server/+/158237
Well-Formed: Restriction Checker
Tested-by: Artem Stemkovski <[email protected]>
Reviewed-by: Aliaksey Artamonau <[email protected]>

Author: vzasade

src/menelaus_web_pools.erl

@@ -229,7 +229,7 @@ do_build_pool_info(Id, InfoLevel, Stability, LocalAddr) ->
          {clusterName, list_to_binary(get_cluster_name())},
          {balanced, ns_cluster_membership:is_balanced()},
          menelaus_web_node:build_memory_quota_info(Config),
-         build_ui_params(InfoLevel),
+         build_ui_params(InfoLevel, Config),
          build_internal_params(InfoLevel),
          build_unstable_params(Stability, Config)],
     {struct, lists:flatten(PropList)}.
@@ -257,12 +257,12 @@ build_internal_params(internal) ->
 build_internal_params(_) ->
     [].
 
-build_ui_params(for_ui) ->
-    [{failoverWarnings, ns_bucket:failover_warnings()},
+build_ui_params(for_ui, Config) ->
+    [{failoverWarnings, ns_bucket:failover_warnings(Config)},
      {saslauthdEnabled, cluster_compat_mode:is_saslauthd_enabled()},
      {uiSessionTimeout,
       ns_config:read_key_fast(ui_session_timeout, undefined)}];
-build_ui_params(_) ->
+build_ui_params(_, _) ->
     [].
 
 build_unstable_params(stable, _) ->

src/ns_bucket.erl

@@ -32,7 +32,7 @@
          credentials/1,
          delete_bucket/1,
          durability_min_level/1,
-         failover_warnings/0,
+         failover_warnings/1,
          get_bucket/1,
          get_bucket/2,
          get_bucket_from_configs/2,
@@ -306,10 +306,9 @@ failover_safety_rec(BaseSafety, ExtraSafety, [BucketConfig | RestConfigs], Activ
     failover_safety_rec(NewBaseSafety, NewExtraSafety,
                         RestConfigs, ActiveNodes, LiveNodes).
 
--spec failover_warnings() -> [failoverNeeded | rebalanceNeeded | hardNodesNeeded | softNodesNeeded].
-failover_warnings() ->
-    Config = ns_config:get(),
-
+-spec failover_warnings(ns_config()) -> [failoverNeeded | rebalanceNeeded |
+                                         hardNodesNeeded | softNodesNeeded].
+failover_warnings(Config) ->
     ActiveNodes = ns_cluster_membership:service_active_nodes(Config, kv),
     LiveNodes = ns_cluster_membership:service_actual_nodes(Config, kv),
     {BaseSafety0, ExtraSafety}