setting num_writer_threads = disk_io_optimized for all durability tests by default

Change-Id: Ifb0a9629d106575b3418bdb186bc33df76228d84
Reviewed-on: http://review.couchbase.org/c/perfrunner/+/149068
Tested-by: Build Bot <[email protected]>
Reviewed-by: <[email protected]>

Author: korry8911

perfrunner/helpers/cluster.py

@@ -459,8 +459,10 @@ def restart_with_alternative_bucket_options(self):
                         self.rest.run_diag_eval(master, diag_eval)
 
         if self.test_config.bucket_extras:
+            self.disable_auto_failover()
             self.remote.restart()
             self.wait_until_healthy()
+            self.enable_auto_failover()
 
     def tune_logging(self):
         if self.dynamic_infra:
@@ -486,6 +488,24 @@ def enable_auto_failover(self):
             for master in self.cluster_spec.masters:
                 self.rest.set_auto_failover(master, enabled, failover_min, failover_max)
 
+    def disable_auto_failover(self):
+        enabled = 'false'
+        failover_min = self.test_config.bucket.failover_min
+        failover_max = self.test_config.bucket.failover_max
+        if self.dynamic_infra:
+            cluster = self.remote.get_cluster()
+            cluster['spec']['cluster']['autoFailoverMaxCount'] = 1
+            cluster['spec']['cluster']['autoFailoverServerGroup'] = bool(enabled)
+            cluster['spec']['cluster']['autoFailoverOnDataDiskIssues'] = bool(enabled)
+            cluster['spec']['cluster']['autoFailoverOnDataDiskIssuesTimePeriod'] = \
+                '{}s'.format(10)
+            cluster['spec']['cluster']['autoFailoverTimeout'] = \
+                '{}s'.format(failover_max)
+            self.remote.update_cluster_config(cluster)
+        else:
+            for master in self.cluster_spec.masters:
+                self.rest.set_auto_failover(master, enabled, failover_min, failover_max)
+
     def wait_until_warmed_up(self):
         if self.test_config.bucket.bucket_type in ('ephemeral', 'memcached'):
             return

perfrunner/helpers/rest.py

@@ -527,7 +527,7 @@ def run_diag_eval(self, host: str, cmd: str):
 
     def set_auto_failover(self, host: str, enabled: str,
                           failover_min: int, failover_max: int):
-        logger.info('Enabling auto-failover with the minimum timeout')
+        logger.info('Setting auto-failover to: {}'.format(enabled))
 
         api = 'http://{}:8091/settings/autoFailover'.format(host)
 

perfrunner/settings.py

@@ -1684,7 +1684,13 @@ def users(self) -> UserSettings:
 
     @property
     def bucket_extras(self) -> dict:
-        return self._get_options_as_dict('bucket_extras')
+        bucket_extras = self._get_options_as_dict('bucket_extras')
+        options = self._get_options_as_dict('access')
+        access = AccessSettings(options)
+        if access.durability is not None:
+            if "num_writer_threads" not in bucket_extras:
+                bucket_extras["num_writer_threads"] = "disk_io_optimized"
+        return bucket_extras
 
     @property
     def buckets(self) -> List[str]: