Skip to content

Commit 618eb82

Browse files
committed
optionally increasing check_num_items retry count
Change-Id: Id94f13db33735be535cadeb4d53ea1a6b433aa16 Reviewed-on: http://review.couchbase.org/c/perfrunner/+/152569 Tested-by: Build Bot <[email protected]> Reviewed-by: Bo-Chun Wang <[email protected]> Reviewed-by: Korrigan Clark <[email protected]>
1 parent c10a0af commit 618eb82

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

perfrunner/helpers/monitor.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -973,10 +973,12 @@ def _wait_for_replica_count_match(self, host, bucket):
973973
if time.time() - start_time > self.TIMEOUT:
974974
raise Exception('Replica items monitoring got stuck')
975975

976-
def monitor_num_items(self, host: str, bucket: str, num_items: int):
976+
def monitor_num_items(self, host: str, bucket: str, num_items: int, max_retry: int=None):
977977
logger.info('Checking the number of items in {}'.format(bucket))
978+
if not max_retry:
979+
max_retry = self.MAX_RETRY
978980
retries = 0
979-
while retries < self.MAX_RETRY:
981+
while retries < max_retry:
980982
curr_items = self._get_num_items(host, bucket, total=True)
981983
if curr_items == num_items:
982984
break

perfrunner/tests/__init__.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ def wait_for_indexing(self):
250250
for server in self.index_nodes:
251251
self.monitor.monitor_indexing(server)
252252

253-
def check_num_items(self, bucket_items: dict = None):
253+
def check_num_items(self, bucket_items: dict = None, max_retry: int=None):
254254
if bucket_items:
255255
for target in self.target_iterator:
256256
num_items = bucket_items.get(target.bucket, None)
@@ -259,7 +259,8 @@ def check_num_items(self, bucket_items: dict = None):
259259
self.monitor.monitor_num_items(
260260
target.node,
261261
target.bucket,
262-
num_items
262+
num_items,
263+
max_retry=max_retry
263264
)
264265
elif getattr(self.test_config.load_settings, 'collections', None):
265266
for target in self.target_iterator:
@@ -274,14 +275,14 @@ def check_num_items(self, bucket_items: dict = None):
274275
num_load_targets * \
275276
(1 + self.test_config.bucket.replica_number)
276277
self.monitor.monitor_num_items(target.node, target.bucket,
277-
num_items)
278+
num_items, max_retry=max_retry)
278279
else:
279280
num_items = self.test_config.load_settings.items * (
280281
1 + self.test_config.bucket.replica_number
281282
)
282283
for target in self.target_iterator:
283284
self.monitor.monitor_num_items(target.node, target.bucket,
284-
num_items)
285+
num_items, max_retry=max_retry)
285286

286287
def reset_kv_stats(self):
287288
master_node = next(self.cluster_spec.masters)

perfrunner/tests/operator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class OperatorBackupRestoreTest(OperatorBackupTest):
7171
def restore(self):
7272
logger.info('Running restore')
7373
self.remote.create_restore()
74-
self.check_num_items()
74+
self.check_num_items(max_retry=3600)
7575

7676
def flush_buckets(self):
7777
logger.info('Flushing bucket')

0 commit comments

Comments
 (0)