ING-1328: Handle error when eviction policy invalid for bucket

ING-1328: Uncomment tests that have been fixed in gocbcorex

ING-1328: Handle invalid arg errs when updating bucket

ING-1328: Handle error returned when bad credentials are used

Author: Westwooo

gateway/dataimpl/server_v1/bucketadminserver.go

@@ -284,6 +284,8 @@ func (s *BucketAdminServer) CreateBucket(
 			return nil, s.errorHandler.NewBucketExistsStatus(err, in.BucketName).Err()
 		} else if errors.Is(err, cbmgmtx.ErrServerInvalidArg) {
 			return nil, s.errorHandler.NewBucketInvalidArgStatus(err, "", in.BucketName).Err()
+		} else if errors.Is(err, cbmgmtx.ErrAccessDenied) {
+			return nil, s.errorHandler.NewBucketAccessDeniedStatus(err, in.BucketName).Err()
 		}
 		return nil, s.errorHandler.NewGenericStatus(err).Err()
 	}
@@ -387,6 +389,10 @@ func (s *BucketAdminServer) UpdateBucket(
 	if err != nil {
 		if errors.Is(err, cbmgmtx.ErrBucketNotFound) {
 			return nil, s.errorHandler.NewBucketMissingStatus(err, in.BucketName).Err()
+		} else if errors.Is(err, cbmgmtx.ErrServerInvalidArg) {
+			return nil, s.errorHandler.NewBucketInvalidArgStatus(err, "", in.BucketName).Err()
+		} else if errors.Is(err, cbmgmtx.ErrAccessDenied) {
+			return nil, s.errorHandler.NewBucketAccessDeniedStatus(err, in.BucketName).Err()
 		}
 		return nil, s.errorHandler.NewGenericStatus(err).Err()
 	}
@@ -418,6 +424,8 @@ func (s *BucketAdminServer) DeleteBucket(
 	if err != nil {
 		if errors.Is(err, cbmgmtx.ErrBucketNotFound) {
 			return nil, s.errorHandler.NewBucketMissingStatus(err, in.BucketName).Err()
+		} else if errors.Is(err, cbmgmtx.ErrAccessDenied) {
+			return nil, s.errorHandler.NewBucketAccessDeniedStatus(err, in.BucketName).Err()
 		}
 		return nil, s.errorHandler.NewGenericStatus(err).Err()
 	}
@@ -451,6 +459,8 @@ func (s *BucketAdminServer) FlushBucket(
 			return nil, s.errorHandler.NewBucketMissingStatus(err, in.BucketName).Err()
 		} else if errors.Is(err, cbmgmtx.ErrFlushDisabled) {
 			return nil, s.errorHandler.NewBucketFlushDisabledStatus(err, in.BucketName).Err()
+		} else if errors.Is(err, cbmgmtx.ErrAccessDenied) {
+			return nil, s.errorHandler.NewBucketAccessDeniedStatus(err, in.BucketName).Err()
 		}
 		return nil, s.errorHandler.NewGenericStatus(err).Err()
 	}

gateway/dataimpl/server_v1/errorhandler.go

@@ -188,6 +188,19 @@ func (e ErrorHandler) NewBucketInvalidArgStatus(baseErr error, msg string, bucke
 	return st
 }
 
+func (e ErrorHandler) NewBucketAccessDeniedStatus(baseErr error, bucketName string) *status.Status {
+	msg := "No permissions to perform bucket management operation."
+	st := status.New(codes.PermissionDenied, msg)
+
+	st = e.tryAttachStatusDetails(
+		st, &epb.ResourceInfo{
+			ResourceType: "bucket",
+			ResourceName: bucketName,
+			Description:  "",
+		})
+	return st
+}
+
 func (e ErrorHandler) NewCollectionInvalidArgStatus(baseErr error, msg string, bucket, scope, collection string) *status.Status {
 	if msg == "" {
 		msg = "invalid argument"