Add RestTester test to fetch by old RevTree ID

Author: bbrks

rest/revision_old_revtree_test.go

@@ -0,0 +1,85 @@
+// Copyright 2025-Present Couchbase, Inc.
+//
+// Use of this software is governed by the Business Source License included
+// in the file licenses/BSL-Couchbase.txt.  As of the Change Date specified
+// in that file, in accordance with the Business Source License, use of this
+// software will be governed by the Apache License, Version 2.0, included in
+// the file licenses/APL2.txt.
+
+package rest
+
+import (
+	"fmt"
+	"net/http"
+	"testing"
+
+	"github.com/couchbase/sync_gateway/base"
+	"github.com/stretchr/testify/assert"
+)
+
+// TestGetOldRevisionBodyByRevTreeID ensures that fetching an older revision body using a legacy RevTree ID after flushing the revision cache works with store_legacy_revtree_data set.
+func TestGetOldRevisionBodyByRevTreeID(t *testing.T) {
+	base.SetUpTestLogging(t, base.LevelDebug, base.KeyCRUD)
+
+	tests := []struct {
+		name                   string
+		storeLegacyRevTreeData bool
+		deltaSyncEnabled       bool
+		expectedToFindOldRev   bool
+	}{
+		{
+			name:                   "store_legacy_revtree_data=true, delta_sync=true",
+			storeLegacyRevTreeData: true,
+			deltaSyncEnabled:       true,
+			expectedToFindOldRev:   true,
+		},
+		{
+			name:                   "store_legacy_revtree_data=true, delta_sync=false",
+			storeLegacyRevTreeData: true,
+			deltaSyncEnabled:       false,
+			expectedToFindOldRev:   false, // TODO: CBG-4840 - Should be true - Requires restoration of non-delta sync rev storage
+		},
+		{
+			name:                   "store_legacy_revtree_data=false, delta_sync=true",
+			storeLegacyRevTreeData: false,
+			deltaSyncEnabled:       true,
+			expectedToFindOldRev:   false,
+		},
+		{
+			name:                   "store_legacy_revtree_data=false, delta_sync=false",
+			storeLegacyRevTreeData: false,
+			deltaSyncEnabled:       false,
+			expectedToFindOldRev:   false,
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			rt := NewRestTester(t, &RestTesterConfig{
+				DatabaseConfig: &DatabaseConfig{DbConfig: DbConfig{
+					DeltaSync:              &DeltaSyncConfig{Enabled: base.Ptr(tc.deltaSyncEnabled)},
+					StoreLegacyRevTreeData: base.Ptr(tc.storeLegacyRevTreeData),
+				}},
+			})
+			defer rt.Close()
+
+			// Create and update a document to generate an old revision.
+			const docID = "doc1"
+			v1 := rt.PutDoc(docID, `{"v":1}`)
+			v2 := rt.UpdateDoc(docID, v1, `{"v":2}`)
+			_ = v2
+
+			// Flush the revision cache to force retrieval from bucket-stored old revision docs.
+			rt.GetDatabase().FlushRevisionCacheForTest()
+
+			resp := rt.SendAdminRequest(http.MethodGet, fmt.Sprintf("/{{.keyspace}}/%s?rev=%s", docID, v1.RevTreeID), "")
+			// Attempt to fetch the old revision body using its RevTree ID.
+			if tc.expectedToFindOldRev {
+				RequireStatus(t, resp, http.StatusOK)
+				assert.Contains(t, resp.BodyString(), `"v":1`)
+			} else {
+				RequireStatus(t, resp, http.StatusNotFound)
+			}
+		})
+	}
+}

rest/utilities_testing_resttester.go

@@ -95,7 +95,7 @@ func (rt *RestTester) GetDocVersion(docID string, version DocVersion) db.Body {
 
 // GetDocByRev returns the doc body for the given docID and Rev. If the document is not found, t.Fail will be called.
 func (rt *RestTester) GetDocByRev(docID, revTreeID string) db.Body {
-	rawResponse := rt.SendAdminRequest(http.MethodGet, fmt.Sprintf("/%s/%s?rev=%s", rt.GetSingleKeyspace(), docID, revTreeID), "")
+	rawResponse := rt.SendAdminRequest(http.MethodGet, fmt.Sprintf("/{{.keyspace}}/%s?rev=%s", docID, revTreeID), "")
 	RequireStatus(rt.TB(), rawResponse, http.StatusOK)
 	var body db.Body
 	require.NoError(rt.TB(), base.JSONUnmarshal(rawResponse.Body.Bytes(), &body))
@@ -104,14 +104,14 @@ func (rt *RestTester) GetDocByRev(docID, revTreeID string) db.Body {
 
 // CreateTestDoc creates a document with an arbitrary body.
 func (rt *RestTester) CreateTestDoc(docid string) DocVersion {
-	response := rt.SendAdminRequest(http.MethodPut, fmt.Sprintf("/%s/%s", rt.GetSingleKeyspace(), docid), `{"prop":true}`)
+	response := rt.SendAdminRequest(http.MethodPut, fmt.Sprintf("/{{.keyspace}}/%s", docid), `{"prop":true}`)
 	RequireStatus(rt.TB(), response, 201)
 	return DocVersionFromPutResponse(rt.TB(), response)
 }
 
 // PutDoc will upsert the document with a given contents.
 func (rt *RestTester) PutDoc(docID, body string) DocVersion {
-	rawResponse := rt.SendAdminRequest(http.MethodPut, fmt.Sprintf("/%s/%s", rt.GetSingleKeyspace(), docID), body)
+	rawResponse := rt.SendAdminRequest(http.MethodPut, fmt.Sprintf("/{{.keyspace}}/%s", docID), body)
 	RequireStatus(rt.TB(), rawResponse, 201)
 	return DocVersionFromPutResponse(rt.TB(), rawResponse)
 }