Skip to content

Commit 6bf370d

Browse files
RIT3shSapataRIT3shSapata
committed
refactor the unit tests for import filter dry run
1 parent f09f031 commit 6bf370d

File tree

1 file changed

+23
-22
lines changed

1 file changed

+23
-22
lines changed

‎rest/diagnostic_doc_api_test.go‎

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,6 +1188,13 @@ func TestImportFilterDryRun(t *testing.T) {
11881188
base.SkipImportTestsIfNotEnabled(t)
11891189
base.SetUpTestLogging(t, base.LevelDebug, base.KeyAll)
11901190

1191+
rt := NewRestTester(t, &RestTesterConfig{
1192+
PersistentConfig: true,
1193+
})
1194+
defer rt.Close()
1195+
1196+
RequireStatus(t, rt.CreateDatabase("db", rt.NewDbConfig()), http.StatusCreated)
1197+
11911198
tests := []struct {
11921199
name string
11931200
dbImportFilter string
@@ -1293,9 +1300,9 @@ func TestImportFilterDryRun(t *testing.T) {
12931300
{
12941301
name: "db_import_filter-no_custom_import_filter-no_doc_body-existing_doc-docid",
12951302
dbImportFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
1296-
docID: "doc2",
1303+
docID: "db_import_filter-no_custom_import_filter-no_doc_body-existing_doc-docid",
12971304
existingDoc: true,
1298-
existingDocID: "doc2",
1305+
existingDocID: "db_import_filter-no_custom_import_filter-no_doc_body-existing_doc-docid",
12991306
existingDocBody: `{"user":{"num":125}}`,
13001307
expectedOutput: ImportFilterDryRun{
13011308
ShouldImport: true,
@@ -1305,9 +1312,9 @@ func TestImportFilterDryRun(t *testing.T) {
13051312
{
13061313
name: "no_db_import_filter-custom_import_filter-no_doc_body-existing_doc-docid",
13071314
importFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
1308-
docID: "doc2",
1315+
docID: "no_db_import_filter-custom_import_filter-no_doc_body-existing_doc-docid",
13091316
existingDoc: true,
1310-
existingDocID: "doc2",
1317+
existingDocID: "no_db_import_filter-custom_import_filter-no_doc_body-existing_doc-docid",
13111318
existingDocBody: `{"user":{"num":125}}`,
13121319
expectedOutput: ImportFilterDryRun{
13131320
ShouldImport: true,
@@ -1318,9 +1325,9 @@ func TestImportFilterDryRun(t *testing.T) {
13181325
name: "db_import_filter-custom_import_filter-no_doc_body-existing_doc-docid",
13191326
dbImportFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13201327
importFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
1321-
docID: "doc2",
1328+
docID: "db_import_filter-custom_import_filter-no_doc_body-existing_doc-docid",
13221329
existingDoc: true,
1323-
existingDocID: "doc2",
1330+
existingDocID: "db_import_filter-custom_import_filter-no_doc_body-existing_doc-docid",
13241331
existingDocBody: `{"user":{"num":125}}`,
13251332
expectedOutput: ImportFilterDryRun{
13261333
ShouldImport: true,
@@ -1332,7 +1339,7 @@ func TestImportFilterDryRun(t *testing.T) {
13321339
dbImportFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13331340
docID: "doc404",
13341341
existingDoc: true,
1335-
existingDocID: "doc2",
1342+
existingDocID: "db_import_filter-no_custom_import_filter-no_doc_body-existing_doc-invalid_docid",
13361343
existingDocBody: `{"user":{"num":125}}`,
13371344
expectedOutput: ImportFilterDryRun{
13381345
Error: "not_found",
@@ -1344,7 +1351,7 @@ func TestImportFilterDryRun(t *testing.T) {
13441351
importFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13451352
docID: "doc404",
13461353
existingDoc: true,
1347-
existingDocID: "doc2",
1354+
existingDocID: "no_db_import_filter-custom_import_filter-no_doc_body-existing_doc-invalid_docid",
13481355
existingDocBody: `{"user":{"num":125}}`,
13491356
expectedOutput: ImportFilterDryRun{
13501357
Error: "not_found",
@@ -1357,7 +1364,7 @@ func TestImportFilterDryRun(t *testing.T) {
13571364
importFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13581365
docID: "doc404",
13591366
existingDoc: true,
1360-
existingDocID: "doc2",
1367+
existingDocID: "db_import_filter-custom_import_filter-no_doc_body-existing_doc-invalid_docid",
13611368
existingDocBody: `{"user":{"num":125}}`,
13621369
expectedOutput: ImportFilterDryRun{
13631370
Error: "not_found",
@@ -1368,9 +1375,9 @@ func TestImportFilterDryRun(t *testing.T) {
13681375
name: "db_import_filter-no_custom_import_filter-doc_body-existing_doc-docid",
13691376
dbImportFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13701377
document: map[string]interface{}{"user": map[string]interface{}{"num": 23}},
1371-
docID: "doc2",
1378+
docID: "db_import_filter-no_custom_import_filter-doc_body-existing_doc-docid",
13721379
existingDoc: true,
1373-
existingDocID: "doc2",
1380+
existingDocID: "db_import_filter-no_custom_import_filter-doc_body-existing_doc-docid",
13741381
existingDocBody: `{"user":{"num":125}}`,
13751382
expectedOutput: ImportFilterDryRun{
13761383
Error: "Bad Request",
@@ -1381,9 +1388,9 @@ func TestImportFilterDryRun(t *testing.T) {
13811388
name: "no_db_import_filter-custom_import_filter-doc_body-existing_doc-docid",
13821389
importFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13831390
document: map[string]interface{}{"user": map[string]interface{}{"num": 23}},
1384-
docID: "doc2",
1391+
docID: "no_db_import_filter-custom_import_filter-doc_body-existing_doc-docid",
13851392
existingDoc: true,
1386-
existingDocID: "doc2",
1393+
existingDocID: "no_db_import_filter-custom_import_filter-doc_body-existing_doc-docid",
13871394
existingDocBody: `{"user":{"num":125}}`,
13881395
expectedOutput: ImportFilterDryRun{
13891396
Error: "Bad Request",
@@ -1395,9 +1402,9 @@ func TestImportFilterDryRun(t *testing.T) {
13951402
dbImportFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13961403
importFilter: "function(doc) { if (doc.user.num) { return true; } else { return false; } }",
13971404
document: map[string]interface{}{"user": map[string]interface{}{"num": 23}},
1398-
docID: "doc2",
1405+
docID: "db_import_filter-custom_import_filter-doc_body-existing_doc-docid",
13991406
existingDoc: true,
1400-
existingDocID: "doc2",
1407+
existingDocID: "db_import_filter-custom_import_filter-doc_body-existing_doc-docid",
14011408
existingDocBody: `{"user":{"num":125}}`,
14021409
expectedOutput: ImportFilterDryRun{
14031410
Error: "Bad Request",
@@ -1408,13 +1415,7 @@ func TestImportFilterDryRun(t *testing.T) {
14081415

14091416
for _, test := range tests {
14101417
t.Run(test.name, func(t *testing.T) {
1411-
rt := NewRestTester(t, &RestTesterConfig{
1412-
PersistentConfig: true,
1413-
ImportFilter: test.dbImportFilter,
1414-
})
1415-
defer rt.Close()
1416-
1417-
RequireStatus(t, rt.CreateDatabase("db", rt.NewDbConfig()), http.StatusCreated)
1418+
RequireStatus(t, rt.SendAdminRequest("PUT", "/{{.keyspace}}/_config/import_filter", test.dbImportFilter), http.StatusOK)
14181419

14191420
url := "/{{.keyspace}}/_import_filter"
14201421
if test.existingDoc {

0 commit comments

Comments
 (0)