Acquire read lock to present data race

torcolvin · torcolvin · commit a3199760301e · 2024-11-27T15:04:50.000-05:00
diff --git a/db/active_replicator_common.go b/db/active_replicator_common.go
@@ -313,8 +313,9 @@ func (a *activeReplicatorCommon) getState() string {
 	return a.state
 }
 
-// requires a.stateErrorLock
 func (a *activeReplicatorCommon) _getStateWithErrorMessage() (state string, lastErrorMessage string) {
+	a.stateErrorLock.RLock()
+	defer a.stateErrorLock.RUnlock()
 	if a.lastError == nil {
 		return a.state, ""
 	}

Original file line number	Diff line number	Diff line change
`@@ -313,8 +313,9 @@ func (a *activeReplicatorCommon) getState() string {`
`313`	`313`	`return a.state`
`314`	`314`	`}`
`315`	`315`
`316`		`-// requires a.stateErrorLock`
`317`	`316`	`func (a *activeReplicatorCommon) _getStateWithErrorMessage() (state string, lastErrorMessage string) {`
	`317`	`+ a.stateErrorLock.RLock()`
	`318`	`+ defer a.stateErrorLock.RUnlock()`
`318`	`319`	`if a.lastError == nil {`
`319`	`320`	`return a.state, ""`
`320`	`321`	`}`