CBG-4892: Add eccv to cluster_info endpoint (#7846)

Author: RIT3shSapata

rest/admin_api.go

@@ -2293,17 +2293,19 @@ type ClusterInfo struct {
 }
 
 type BucketInfo struct {
-	Registry GatewayRegistry `json:"registry"`
+	Registry                     *GatewayRegistry `json:"registry,omitempty"`
+	EnableCrossClusterVersioning bool             `json:"enable_cross_cluster_versioning"`
 }
 
 // Get SG cluster information.  Iterates over all buckets associated with the server, and returns cluster
 // information (registry) for each
 func (h *handler) handleGetClusterInfo() error {
 
 	clusterInfo := ClusterInfo{
-		LegacyConfig: true,
+		Buckets: make(map[string]BucketInfo),
 	}
 
+	eccv := h.server.getBucketCCVSettings()
 	if h.server.persistentConfig {
 
 		bucketNames, err := h.server.GetBucketNames()
@@ -2323,7 +2325,17 @@ func (h *handler) handleGetClusterInfo() error {
 			}
 
 			bucketInfo := BucketInfo{
-				Registry: *registry,
+				Registry:                     registry,
+				EnableCrossClusterVersioning: eccv[bucketName],
+			}
+			clusterInfo.Buckets[bucketName] = bucketInfo
+		}
+	} else {
+		clusterInfo.LegacyConfig = true
+
+		for bucketName, eccvVal := range eccv {
+			bucketInfo := BucketInfo{
+				EnableCrossClusterVersioning: eccvVal,
 			}
 			clusterInfo.Buckets[bucketName] = bucketInfo
 		}

rest/api_test.go

@@ -3533,6 +3533,65 @@ func TestDisableAllowStarChannel(t *testing.T) {
 	base.DebugfCtx(t.Context(), base.KeySGTest, "additional logs")
 }
 
+// TestECCV validates if the ECCV value of the bucket is returned as a response
+// for _cluster_info endpoint. ECCV value is returned for each bucket, if the
+// bucket does not contain any SGW database, the value will be set to false
+func TestECCV(t *testing.T) {
+	if base.UnitTestUrlIsWalrus() {
+		t.Skip("This test only works against Couchbase Server since it requires a gocb bucket")
+	}
+
+	tests := []struct {
+		name             string
+		persistentConfig bool
+		dbName           string
+	}{
+		{
+			name:             "PersistentConfig=true",
+			persistentConfig: true,
+			dbName:           "db1",
+		},
+		{
+			name:             "PersistentConfig=false",
+			persistentConfig: false,
+			dbName:           "db2",
+		},
+	}
+
+	for _, tests := range tests {
+		t.Run(tests.name, func(t *testing.T) {
+			rt := NewRestTester(t, &RestTesterConfig{
+				PersistentConfig: tests.persistentConfig,
+			})
+			defer rt.Close()
+
+			if tests.persistentConfig {
+				dbConfig := rt.NewDbConfig()
+				dbConfig.Name = tests.dbName
+
+				RequireStatus(t, rt.CreateDatabase(tests.dbName, dbConfig), http.StatusCreated)
+			}
+
+			resp := rt.SendAdminRequest(http.MethodGet, "/_cluster_info", "")
+			RequireStatus(t, resp, http.StatusOK)
+
+			bucketName := rt.GetDatabase().Bucket.GetName()
+
+			type BucketInfoResponse struct {
+				EnableCrossClusterVersioning bool `json:"enable_cross_cluster_versioning"`
+			}
+			type ClusterInfoResponse struct {
+				LegacyConfig bool                          `json:"legacy_config,omitempty"`
+				Buckets      map[string]BucketInfoResponse `json:"buckets,omitempty"`
+			}
+			var clusterInfo ClusterInfoResponse
+			err := base.JSONUnmarshal(resp.Body.Bytes(), &clusterInfo)
+			require.NoError(t, err)
+			assert.True(t, clusterInfo.Buckets[bucketName].EnableCrossClusterVersioning)
+		})
+	}
+}
+
 func TestUnsupportedServerConfigOptions(t *testing.T) {
 	tests := []struct {
 		name            string

rest/server_context.go

@@ -2330,3 +2330,12 @@ func (sc *ServerContext) getClusterUUID(ctx context.Context) (string, error) {
 	}
 	return base.ParseClusterUUID(output)
 }
+
+func (sc *ServerContext) getBucketCCVSettings() map[string]bool {
+	bucketCCVSettings := make(map[string]bool)
+	for _, _db := range sc.databases_ {
+		bucketName := _db.BucketSpec.BucketName
+		bucketCCVSettings[bucketName] = _db.CachedCCVEnabled.Load()
+	}
+	return bucketCCVSettings
+}