Skip to content

CBG-4747: remove serialisation on critical path #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −7
Open

CBG-4747: remove serialisation on critical path #7873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0946e76
CBG-4747: remove serialisation on critical path
gregns1 Nov 11, 2025
f61f975
remove unused field
gregns1 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions channels/set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,19 @@ const AllChannelWildcard = "*" // wildcard for 'all channels'

// ID represents a single channel inside a collection
type ID struct {
Name string // name of channel
CollectionID uint32 // collection it belongs to
serialization string // private method for logging and matching inside changeWaiter notification
Name string // name of channel
CollectionID uint32 // collection it belongs to
}

func (c ID) String() string {
return c.serialization
return strconv.FormatUint(uint64(c.CollectionID), 10) + "." + base.UserDataPrefix + c.Name + base.UserDataSuffix
}

// NewID returns a new ChannelID
func NewID(channelName string, collectionID uint32) ID {
return ID{
Name: channelName,
CollectionID: collectionID,
serialization: strconv.FormatUint(uint64(collectionID), 10) + "." + base.UserDataPrefix + channelName + base.UserDataSuffix,
Name: channelName,
CollectionID: collectionID,
}
}

Expand Down
Loading