Skip to content

CBG-4928 do not log warning for closed blip sender #7878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

CBG-4928 do not log warning for closed blip sender #7878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db/blip_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ func (bh *blipHandler) sendBatchOfChanges(sender *blip.Sender, changeArray [][]a
bh.replicationStats.SendChangesCount.Add(int64(len(changeArray)))
// Spawn a goroutine to await the client's response:
go func(bh *blipHandler, sender *blip.Sender, response *blip.Message, changeArray [][]any, sendTime time.Time, dbCollection *DatabaseCollectionWithUser) {
if err := bh.handleChangesResponse(bh.loggingCtx, sender, response, changeArray, sendTime, dbCollection, bh.collectionIdx); err != nil {
if err := bh.handleChangesResponse(bh.loggingCtx, sender, response, changeArray, sendTime, dbCollection, bh.collectionIdx); err != nil && !errors.Is(err, ErrClosedBLIPSender) {
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The condition is now complex with multiple checks on a single line. Consider extracting the error check to a separate variable for improved readability: if err := bh.handleChangesResponse(...); err != nil { if !errors.Is(err, ErrClosedBLIPSender) { ... } }

Copilot uses AI. Check for mistakes.
base.WarnfCtx(bh.loggingCtx, "Error from bh.handleChangesResponse: %v", err)
if bh.fatalErrorCallback != nil {
bh.fatalErrorCallback(err)
Expand Down