-
Notifications
You must be signed in to change notification settings - Fork 140
Prototype: Create an abstract DCPClient to be able to work with rosmar #7879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
torcolvin
wants to merge
1
commit into
main
Choose a base branch
from
dcp-abstract
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package base | ||
|
|
||
| import ( | ||
| "context" | ||
| "expvar" | ||
| "fmt" | ||
|
|
||
| sgbucket "github.com/couchbase/sg-bucket" | ||
| "github.com/couchbaselabs/rosmar" | ||
| ) | ||
|
|
||
| type DCPClient interface { | ||
| Start(ctx context.Context) (chan error, error) | ||
| Close() error | ||
| GetMetadata() []DCPMetadata | ||
| GetMetadataKeyPrefix() string | ||
| } | ||
|
|
||
| type DCPCollections map[string][]string | ||
|
|
||
| type DCPClientOptions struct { | ||
| ID string // name of the DCP feed, used for logging locally and stored by Couchbase Server | ||
| OneShot bool // if true, the feed runs to latest document found when the client is started | ||
| FailOnRollback bool // if true, fail Start if the current DCP checkpoints encounter a rollback condition | ||
| MetadataStoreType DCPMetadataStoreType // persistent or in memory storage | ||
| GroupID string // name of groupID of rest.ServerContext in order to isolate DCP checkpoints | ||
| CheckpointPrefix string // start of the checkpoint documents | ||
| Callback sgbucket.FeedEventCallbackFunc // callback function for DCP events | ||
| DBStats *expvar.Map | ||
| Scopes map[string][]string // scopes and collections to monitor | ||
| InitialMetadata []DCPMetadata // initial metadata to seed the DCP client with | ||
| } | ||
|
|
||
| func NewDCPClient(ctx context.Context, bucket Bucket, opts DCPClientOptions) (DCPClient, error) { | ||
| underlyingBucket := GetBaseBucket(bucket) | ||
| if _, ok := underlyingBucket.(*rosmar.Bucket); ok { | ||
| return NewRosmarDCPClient(bucket, opts) | ||
| } else if gocbBucket, ok := underlyingBucket.(*GocbV2Bucket); ok { | ||
| feedArgs := sgbucket.FeedArguments{ | ||
| ID: opts.ID, | ||
| CheckpointPrefix: opts.CheckpointPrefix, | ||
| Scopes: opts.Scopes, | ||
| } | ||
| return newGocbDCPClient(ctx, gocbBucket, gocbBucket.GetName(), feedArgs, opts.Callback, opts.DBStats, opts.MetadataStoreType, opts.GroupID) | ||
| } | ||
| return nil, fmt.Errorf("bucket type %T does not have a DCPClient implementation", underlyingBucket) | ||
| } | ||
|
|
||
| func (c DCPCollections) Add(ds ...sgbucket.DataStoreName) { | ||
| for _, d := range ds { | ||
| if _, ok := c[d.ScopeName()]; !ok { | ||
| c[d.ScopeName()] = []string{} | ||
| } | ||
| c[d.ScopeName()] = append(c[d.ScopeName()], d.CollectionName()) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This FIXME suggests incomplete implementation. The context parameter is passed to Start() but this comment indicates it should be set somewhere. Clarify what needs to be done here or remove the comment if the implementation is correct.