Skip to content

Commit 1044057

Browse files
committed
Update per feedback
1 parent 1916819 commit 1044057

File tree

2 files changed

+18
-37
lines changed

2 files changed

+18
-37
lines changed

spec/tests/dev_e2e/003-replication-auto-purge.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,10 @@ Test that when the removed access documents are filtered, the removed access doc
182182
* credentials: user1/pass
183183
8. Check document replications:
184184
* `post_1` has access-removed flag set with no error.
185-
* `post_2` has access-removed flag set with WebSocket/403 ("CBL, 10403) error.
185+
* Note: JS doesn't notify document ended error notifications when documents
186+
are rejected by pull replication filters. The other platforms plan to align
187+
this behavior. So we are not checking the error from the filtered removed
188+
revision here. See CBL-7246 and CBL-7645 for more details.
186189
9. Check local documents:
187190
* `post_1` was purged.
188191
* `post_2` still exists.

tests/dev_e2e/test_replication_auto_purge.py

Lines changed: 14 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
WaitForDocumentEventEntry,
1818
)
1919
from cbltest.api.syncgateway import DocumentUpdateEntry
20-
from cbltest.responses import ServerVariant
2120

2221

2322
@pytest.mark.min_test_servers(1)
@@ -733,42 +732,21 @@ async def test_filter_removed_access_documents(
733732
self.mark_test_step("""
734733
Check document replications
735734
* `post_1` has access-removed flag set with no error.
736-
* `post_2` has access-removed flag set with WebSocket/403 ("CBL, 10403) error (except JS)
737-
Note:
738-
* JS doesn't notify document ended notification when documents are rejected
739-
by the pull replication filter. Maybe implemented in the future based on demands.
740-
See CBL-7246 for more details
735+
* Note: JS doesn't notify document ended error notifications when documents
736+
are rejected by pull replication filters. The other platforms plan to align
737+
this behavior. So we are not checking the error from the filtered removed
738+
revision here. See CBL-7246 and CBL-7645 for more details.
741739
""")
742-
if (await cblpytest.test_servers[0].get_info()).variant != ServerVariant.JS:
743-
await repl2.wait_for_all_doc_events(
744-
{
745-
WaitForDocumentEventEntry(
746-
"_default.posts",
747-
"post_1",
748-
ReplicatorType.PULL,
749-
ReplicatorDocumentFlags.ACCESS_REMOVED,
750-
),
751-
WaitForDocumentEventEntry(
752-
"_default.posts",
753-
"post_2",
754-
ReplicatorType.PULL,
755-
ReplicatorDocumentFlags.ACCESS_REMOVED,
756-
"CBL",
757-
10403,
758-
),
759-
}
760-
)
761-
else:
762-
await repl2.wait_for_all_doc_events(
763-
{
764-
WaitForDocumentEventEntry(
765-
"_default.posts",
766-
"post_1",
767-
ReplicatorType.PULL,
768-
ReplicatorDocumentFlags.ACCESS_REMOVED,
769-
)
770-
}
771-
)
740+
await repl2.wait_for_all_doc_events(
741+
{
742+
WaitForDocumentEventEntry(
743+
"_default.posts",
744+
"post_1",
745+
ReplicatorType.PULL,
746+
ReplicatorDocumentFlags.ACCESS_REMOVED,
747+
)
748+
}
749+
)
772750

773751
self.mark_test_step("""
774752
Check the local docs

0 commit comments

Comments
 (0)