Skip to content

Commit c54bc25

Browse files
dsarlo-visochedim
authored andcommitted
Fix datasource connection leak when using the JdbcChatMemoryRepository
Signed-off-by: Dan Sarlo <[email protected]>
1 parent a9967e4 commit c54bc25

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepositoryDialect.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.ai.chat.memory.repository.jdbc;
1818

1919
import javax.sql.DataSource;
20+
import java.sql.Connection;
2021

2122
/**
2223
* Abstraction for database-specific SQL for chat memory repository.
@@ -53,8 +54,8 @@ public interface JdbcChatMemoryRepositoryDialect {
5354
*/
5455
static JdbcChatMemoryRepositoryDialect from(DataSource dataSource) {
5556
// Simple detection (could be improved)
56-
try {
57-
String url = dataSource.getConnection().getMetaData().getURL().toLowerCase();
57+
try (Connection connection = dataSource.getConnection()) {
58+
String url = connection.getMetaData().getURL().toLowerCase();
5859
if (url.contains("postgresql")) {
5960
return new PostgresChatMemoryRepositoryDialect();
6061
}

0 commit comments

Comments
 (0)