Add version number validation

Author: countableSet

build.gradle.kts

@@ -12,7 +12,8 @@ repositories {
 dependencies {
     testImplementation(platform("org.junit:junit-bom:5.8.2"))
     testImplementation("org.junit.jupiter:junit-jupiter")
-    testImplementation("com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.13.2")
+    testImplementation("org.junit.jupiter:junit-jupiter-params")
+    testImplementation("com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.12.6")
     testImplementation("com.fasterxml.jackson.module:jackson-module-kotlin:2.13.2")
 }
 

src/main/kotlin/dev/poolside/gradle/semanticversion/SemanticVersionTask.kt

@@ -10,13 +10,15 @@ import java.util.concurrent.TimeUnit
 
 abstract class SemanticVersionTask : DefaultTask() {
 
+    private val versionRegex = "^\\d+\\.\\d+\$".toRegex()
     private val versions = mutableMapOf<String, String>()
 
     @TaskAction
     fun setVersion() {
         project.allprojects.forEach { p ->
             p.extensions.getByType(PublishingExtension::class.java).publications.forEach { publication ->
                 val pub = publication as MavenPublication
+                checkVersion(pub.version)
                 val (key, version) = findVersion(pub)
                 pub.version = version
                 versions[key] = version
@@ -28,6 +30,12 @@ abstract class SemanticVersionTask : DefaultTask() {
         }
     }
 
+    private fun checkVersion(version: String) {
+        if (!versionRegex.matches(version)) {
+            throw IllegalArgumentException("Invalid version, must be in format $versionRegex")
+        }
+    }
+
     private fun findVersion(publication: MavenPublication): Pair<String, String> {
         val dep = project.dependencies.create(group = publication.groupId, name = publication.artifactId, version = "${publication.version}+")
         val conf = project.rootProject.configurations.detachedConfiguration(dep)

src/test/kotlin/dev/poolside/gradle/semanticversion/SemanticVersionPluginTest.kt

@@ -1,11 +1,16 @@
 package dev.poolside.gradle.semanticversion
 
 import org.gradle.testkit.runner.GradleRunner
+import org.gradle.testkit.runner.TaskOutcome.FAILED
+import org.gradle.testkit.runner.UnexpectedBuildFailure
 import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Assertions.assertTrue
 import org.junit.jupiter.api.Assertions.fail
 import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.assertThrows
 import org.junit.jupiter.api.io.TempDir
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
 import java.io.File
 
 class SemanticVersionPluginTest {
@@ -279,4 +284,46 @@ class SemanticVersionPluginTest {
         }
         assertTrue(valid.isEmpty())
     }
+
+    @ParameterizedTest(name = "{index} invalid version {0}")
+    @ValueSource(strings = ["0.1.0", "1", "10.0.0-SNAPSHOT", "1.0-SNAPSHOT", "SNAPSHOT"])
+    fun `invalid version`(version: String) {
+        val build = """
+            plugins {
+                java
+                `maven-publish`
+                id("dev.poolside.gradle.semantic-version")
+            }
+            repositories {
+                maven { url = uri("${mavenRepo.absolutePath}") }
+            }
+            group = "dev.poolside.test"
+            version = "$version"
+            publishing {
+                repositories {
+                    maven { url = uri("${mavenRepo.absolutePath}") }
+                }
+                publications {
+                    create<MavenPublication>("mavenJava") {
+                        artifactId = "my-library"
+                        from(components["java"])
+                    }
+                }
+            }
+        """.trimIndent()
+        val settings = """rootProject.name = "testing""""
+        File(testProjectDir, "build.gradle.kts").writeText(build)
+        File(testProjectDir, "settings.gradle.kts").writeText(settings)
+        val exception = assertThrows<UnexpectedBuildFailure> {
+            GradleRunner.create()
+                .withPluginClasspath()
+                .withProjectDir(testProjectDir)
+                .withArguments("publish")
+//            .withDebug(true)
+                .build()
+        }
+        val result = exception.buildResult
+        assertTrue(result.output.contains("Invalid version, must be in format ^\\d+\\.\\d+\$"))
+        assertEquals(FAILED, result.task(":semanticVersion")?.outcome)
+    }
 }