Merge pull request #1917 from counterfact/copilot/resolve-jest-expect-expect-warnings

Resolve `jest/expect-expect` warnings and stabilize flaky app runner test

Author: pmcelhaney

test/app.test.ts

@@ -81,12 +81,15 @@ describe("counterfact", () => {
 
   it("uses the first spec's runner as primary (contextRegistry, registry) when specs are provided", async () => {
     const realCreate = ApiRunner.create;
-    const capturedRunners: ApiRunner[] = [];
+    const capturedRunnersByGroup = new Map<string, ApiRunner>();
 
     const createSpy = jest.spyOn(ApiRunner, "create");
     createSpy.mockImplementation(async (...args) => {
       const runner = await realCreate.apply(ApiRunner, args);
-      capturedRunners.push(runner);
+      const group = args[1];
+      if (group) {
+        capturedRunnersByGroup.set(group, runner);
+      }
       return runner;
     });
 
@@ -96,10 +99,12 @@ describe("counterfact", () => {
     ];
 
     const result = await (app as any).counterfact(mockConfig, specs);
+    const firstRunner = capturedRunnersByGroup.get("v1");
 
-    expect(capturedRunners).toHaveLength(2);
-    expect(result.contextRegistry).toBe(capturedRunners[0]!.contextRegistry);
-    expect(result.registry).toBe(capturedRunners[0]!.registry);
+    expect(capturedRunnersByGroup.size).toBe(2);
+    expect(firstRunner).toBeDefined();
+    expect(result.contextRegistry).toBe(firstRunner!.contextRegistry);
+    expect(result.registry).toBe(firstRunner!.registry);
 
     createSpy.mockRestore();
   });

test/repl/raw-http-client.test.ts

@@ -212,7 +212,8 @@ describe("RawHttpClient", () => {
 
     client.get("/pets");
 
-    await capture;
+    const raw = await capture;
+    expect(raw).toMatch(/^GET \/pets HTTP\/1\.1/);
     // Allow the event loop to flush the client's "data"/"end" socket events so
     // that #printResponse (including highlightJson with boolean/null values) runs.
     await new Promise((resolve) => setTimeout(resolve, 20));
@@ -227,7 +228,8 @@ describe("RawHttpClient", () => {
 
     client.get("/pets");
 
-    await capture;
+    const raw = await capture;
+    expect(raw).toMatch(/^GET \/pets HTTP\/1\.1/);
     await new Promise((resolve) => setTimeout(resolve, 20));
   });
 
@@ -240,7 +242,8 @@ describe("RawHttpClient", () => {
 
     client.get("/status");
 
-    await capture;
+    const raw = await capture;
+    expect(raw).toMatch(/^GET \/status HTTP\/1\.1/);
     await new Promise((resolve) => setTimeout(resolve, 20));
   });
 });