replace unsafe use of in operator by Object.hasOwn

Author: louis-bompart

packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts

@@ -229,8 +229,8 @@ export class AtomicCommerceSearchBox
       return;
     }
     if (
-      !('redirectTo' in this.searchBoxState) ||
-      !('afterRedirection' in this.searchBox)
+      !Object.hasOwn(this.searchBoxState, 'redirectTo') ||
+      !Object.hasOwn(this.searchBox, 'afterRedirection')
     ) {
       return;
     }
@@ -306,7 +306,7 @@ export class AtomicCommerceSearchBox
   private isStandaloneSearchBox(
     searchBox: SearchBox | StandaloneSearchBox
   ): searchBox is StandaloneSearchBox {
-    return 'updateRedirectUrl' in searchBox;
+    return Object.hasOwn(searchBox, 'updateRedirectUrl');
   }
 
   private updateBreakpoints = once(() => updateBreakpoints(this));

packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx

@@ -215,7 +215,7 @@ export class AtomicSearchBox implements InitializableComponent<Bindings> {
   private isStandaloneSearchBox(
     searchBox: SearchBox | StandaloneSearchBox
   ): searchBox is StandaloneSearchBox {
-    return 'redirectTo' in searchBox;
+    return Object.hasOwn(searchBox, 'redirectTo');
   }
 
   public initialize() {
@@ -254,8 +254,8 @@ export class AtomicSearchBox implements InitializableComponent<Bindings> {
 
   public componentWillUpdate() {
     if (
-      !('redirectTo' in this.searchBoxState) ||
-      !('afterRedirection' in this.searchBox)
+      !Object.hasOwn(this.searchBoxState, 'redirectTo') ||
+      !Object.hasOwn(this.searchBox, 'afterRedirection')
     ) {
       return;
     }

packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts

@@ -1,7 +1,8 @@
 import {expect, test} from './fixture';
 
 test.describe('default', () => {
-  test.beforeEach(async ({searchBox}) => {
+  test.beforeEach(async ({searchBox, browser}) => {
+    browser;
     await searchBox.load({args: {suggestionTimeout: 5000}});
   });