From 33fd5508f005c3d82d21910a52c08530bc696cb8 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 14 Nov 2025 19:13:24 +0000 Subject: [PATCH 01/13] Initial plan From 10672f2895a303398556b2776041a7d20b3cc4bf Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 14 Nov 2025 19:20:39 +0000 Subject: [PATCH 02/13] Add webkit browser to Playwright tests in CI, keep Chrome only for local Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com> --- packages/atomic/playwright.config.ts | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/packages/atomic/playwright.config.ts b/packages/atomic/playwright.config.ts index d2eedc4cc9e..7377bf1d2ce 100644 --- a/packages/atomic/playwright.config.ts +++ b/packages/atomic/playwright.config.ts @@ -35,10 +35,17 @@ export default defineConfig({ // name: 'firefox', // use: {...devices['Desktop Firefox'], viewport: DEFAULT_DESKTOP_VIEWPORT}, // }, - // { - // name: 'webkit', - // use: {...devices['Desktop Safari'], viewport: DEFAULT_DESKTOP_VIEWPORT}, - // }, + ...(process.env.CI + ? [ + { + name: 'webkit', + use: { + ...devices['Desktop Safari'], + viewport: DEFAULT_DESKTOP_VIEWPORT, + }, + }, + ] + : []), ], expect: { timeout: 7 * 1000, From 5595d0bc9f7405347c0221de5b24685210c67b98 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 14 Nov 2025 19:29:37 +0000 Subject: [PATCH 03/13] Add webkit browser to Vitest tests in CI for consistency Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com> --- packages/atomic/vitest.config.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/atomic/vitest.config.js b/packages/atomic/vitest.config.js index 58cef6f2058..c5c435951b7 100644 --- a/packages/atomic/vitest.config.js +++ b/packages/atomic/vitest.config.js @@ -113,6 +113,16 @@ const atomicDefault = defineConfig({ actionTimeout: 3000, }, }, + ...(process.env.CI + ? [ + { + browser: 'webkit', + context: { + actionTimeout: 3000, + }, + }, + ] + : []), ], }, }, @@ -138,7 +148,10 @@ const storybook = defineConfig({ enabled: true, headless: true, provider: playwright(), - instances: [{browser: 'chromium'}], + instances: [ + {browser: 'chromium'}, + ...(process.env.CI ? [{browser: 'webkit'}] : []), + ], context: { actionTimeout: 3000, }, From d1717eb3dc03aab2a28468515b49ed69f33c260d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 14 Nov 2025 22:07:03 +0000 Subject: [PATCH 04/13] Skip webkit for storybook tests and skip Touch tests in webkit Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com> --- .../atomic-product-children.spec.ts | 91 ++++++++++--------- packages/atomic/vitest.config.js | 5 +- 2 files changed, 48 insertions(+), 48 deletions(-) diff --git a/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts b/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts index 9af845a0d2d..5658a826df2 100644 --- a/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts +++ b/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts @@ -162,51 +162,54 @@ describe('atomic-product-children', () => { }); }); - describe('when a child product is touched', () => { - const touchChild = async () => { - const {childProducts} = await renderProductChildren(); - childProducts[3].dispatchEvent( - new TouchEvent('touchstart', { - touches: [ - new Touch({ - identifier: 0, - target: childProducts[3], - clientX: 100, - clientY: 100, - screenX: 100, - screenY: 100, - pageX: 100, - pageY: 100, - radiusX: 10, - radiusY: 10, - rotationAngle: 0, - force: 0.5, - }), - ], - }) - ); - return childProducts; - }; - - it('should change the active child product', async () => { - const childProducts = await touchChild(); - await expect - .poll(() => childProducts[3]) - .toHaveClass('box-border rounded border border-primary'); - await expect - .poll(() => childProducts[0]) - .not.toHaveClass('box-border rounded border border-primary'); - }); + describe.skipIf(typeof Touch === 'undefined')( + 'when a child product is touched', + () => { + const touchChild = async () => { + const {childProducts} = await renderProductChildren(); + childProducts[3].dispatchEvent( + new TouchEvent('touchstart', { + touches: [ + new Touch({ + identifier: 0, + target: childProducts[3], + clientX: 100, + clientY: 100, + screenX: 100, + screenY: 100, + pageX: 100, + pageY: 100, + radiusX: 10, + radiusY: 10, + rotationAngle: 0, + force: 0.5, + }), + ], + }) + ); + return childProducts; + }; + + it('should change the active child product', async () => { + const childProducts = await touchChild(); + await expect + .poll(() => childProducts[3]) + .toHaveClass('box-border rounded border border-primary'); + await expect + .poll(() => childProducts[0]) + .not.toHaveClass('box-border rounded border border-primary'); + }); - it('should dispatch the "atomic/selectChildProduct" event', async () => { - const dispatchSpy = vi.spyOn( - AtomicProductChildren.prototype, - 'dispatchEvent' - ); - await touchChild(); - expect(dispatchSpy).toHaveBeenCalled(); - }); - }); + it('should dispatch the "atomic/selectChildProduct" event', async () => { + const dispatchSpy = vi.spyOn( + AtomicProductChildren.prototype, + 'dispatchEvent' + ); + await touchChild(); + expect(dispatchSpy).toHaveBeenCalled(); + }); + } + ); describe('when a child product is clicked', () => { it('should stop propagation if the parent element is an tag', async () => { diff --git a/packages/atomic/vitest.config.js b/packages/atomic/vitest.config.js index c5c435951b7..62ec084b9ad 100644 --- a/packages/atomic/vitest.config.js +++ b/packages/atomic/vitest.config.js @@ -148,10 +148,7 @@ const storybook = defineConfig({ enabled: true, headless: true, provider: playwright(), - instances: [ - {browser: 'chromium'}, - ...(process.env.CI ? [{browser: 'webkit'}] : []), - ], + instances: [{browser: 'chromium'}], context: { actionTimeout: 3000, }, From a8fadeefb4007a48ee57343372f8c4c9537b6d3b Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Fri, 14 Nov 2025 17:20:52 -0500 Subject: [PATCH 05/13] better if --- .../atomic-product-children/atomic-product-children.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts b/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts index 5658a826df2..45cec7742fd 100644 --- a/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts +++ b/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts @@ -2,6 +2,7 @@ import type {ChildProduct} from '@coveo/headless/commerce'; import {html} from 'lit'; import {ifDefined} from 'lit/directives/if-defined.js'; import {describe, expect, it, vi} from 'vitest'; +import {server} from 'vitest/browser'; import type {AtomicProduct} from '@/src/components/commerce/atomic-product/atomic-product'; import {closest} from '@/src/utils/dom-utils'; import {renderInAtomicProduct} from '@/vitest-utils/testing-helpers/fixtures/atomic/commerce/atomic-product-fixture'; @@ -162,7 +163,7 @@ describe('atomic-product-children', () => { }); }); - describe.skipIf(typeof Touch === 'undefined')( + describe.skipIf(server.browser === 'webkit')( 'when a child product is touched', () => { const touchChild = async () => { From 06884ee3aaed47b01c4084d2751b8664260c35e5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 17 Nov 2025 20:57:19 +0000 Subject: [PATCH 06/13] Rename touchChild to touchChildProduct for clarity Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com> --- .../atomic-product-children/atomic-product-children.spec.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts b/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts index 45cec7742fd..09b5c42abce 100644 --- a/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts +++ b/packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts @@ -166,7 +166,7 @@ describe('atomic-product-children', () => { describe.skipIf(server.browser === 'webkit')( 'when a child product is touched', () => { - const touchChild = async () => { + const touchChildProduct = async () => { const {childProducts} = await renderProductChildren(); childProducts[3].dispatchEvent( new TouchEvent('touchstart', { @@ -192,7 +192,7 @@ describe('atomic-product-children', () => { }; it('should change the active child product', async () => { - const childProducts = await touchChild(); + const childProducts = await touchChildProduct(); await expect .poll(() => childProducts[3]) .toHaveClass('box-border rounded border border-primary'); @@ -206,7 +206,7 @@ describe('atomic-product-children', () => { AtomicProductChildren.prototype, 'dispatchEvent' ); - await touchChild(); + await touchChildProduct(); expect(dispatchSpy).toHaveBeenCalled(); }); } From 621a2477a9c57ec6f3f2d5fb78db54a6a00d01fc Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Mon, 17 Nov 2025 20:33:44 -0500 Subject: [PATCH 07/13] fix: iframe race condition contentDocument is not available until the iframe is connected to the DOM --- .../quickview-iframe/quickview-iframe.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/atomic/src/components/search/result-template-components/quickview-iframe/quickview-iframe.tsx b/packages/atomic/src/components/search/result-template-components/quickview-iframe/quickview-iframe.tsx index a8a30c65d10..022d60e0791 100644 --- a/packages/atomic/src/components/search/result-template-components/quickview-iframe/quickview-iframe.tsx +++ b/packages/atomic/src/components/search/result-template-components/quickview-iframe/quickview-iframe.tsx @@ -59,7 +59,7 @@ export const QuickviewIframe: FunctionalComponent<{ // When a document is written with document.open/document.write/document.close // it is not synchronous and the content of the iframe is only available to be queried at the end of the current call stack. // This add a "wait" (setTimeout 0) before calling the `onSetIframeRef` from the parent modal quickview - const waitForIframeContentToBeWritten = () => { + const flushMicrotasks = () => { return new Promise((resolve) => setTimeout(resolve)); }; @@ -76,6 +76,10 @@ export const QuickviewIframe: FunctionalComponent<{ return; } + if(iframeRef.isConnected === false) { + await flushMicrotasks(); + } + const documentWriter = iframeRef.contentDocument; if (!documentWriter) { if (src) { @@ -97,7 +101,7 @@ export const QuickviewIframe: FunctionalComponent<{ writeDocument(documentWriter, content); ensureSameResultIsNotOverwritten(documentWriter, uniqueIdentifier); - await waitForIframeContentToBeWritten(); + await flushMicrotasks(); onSetIframeRef(iframeRef); }} > From b8fe0325715ad2bec95a2202435d177974516ed0 Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Mon, 17 Nov 2025 20:34:38 -0500 Subject: [PATCH 08/13] tweak config its easier to toggle the browser using vscode ext --- packages/atomic/playwright.config.ts | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/packages/atomic/playwright.config.ts b/packages/atomic/playwright.config.ts index 7377bf1d2ce..43648a38c85 100644 --- a/packages/atomic/playwright.config.ts +++ b/packages/atomic/playwright.config.ts @@ -35,17 +35,16 @@ export default defineConfig({ // name: 'firefox', // use: {...devices['Desktop Firefox'], viewport: DEFAULT_DESKTOP_VIEWPORT}, // }, - ...(process.env.CI - ? [ - { - name: 'webkit', - use: { - ...devices['Desktop Safari'], - viewport: DEFAULT_DESKTOP_VIEWPORT, - }, - }, - ] - : []), + { + name: 'webkit', + use: { + ...devices['Desktop Safari'], + viewport: DEFAULT_DESKTOP_VIEWPORT, + }, + expect: { + timeout: 30 * 1000, + }, + }, ], expect: { timeout: 7 * 1000, From f389033af3f76a2921f2af6ea4d157fe5a25ecb3 Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Mon, 17 Nov 2025 23:21:29 -0500 Subject: [PATCH 09/13] replace unsafe use of in operator by Object.hasOwn --- .../atomic-commerce-search-box.ts | 6 +++--- .../search/atomic-search-box/atomic-search-box.tsx | 6 +++--- .../search/atomic-search-box/e2e/atomic-search-box.e2e.ts | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts b/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts index 74c3c653873..f241e645bcd 100644 --- a/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts +++ b/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts @@ -229,8 +229,8 @@ export class AtomicCommerceSearchBox return; } if ( - !('redirectTo' in this.searchBoxState) || - !('afterRedirection' in this.searchBox) + !Object.hasOwn(this.searchBoxState, 'redirectTo') || + !Object.hasOwn(this.searchBox, 'afterRedirection') ) { return; } @@ -306,7 +306,7 @@ export class AtomicCommerceSearchBox private isStandaloneSearchBox( searchBox: SearchBox | StandaloneSearchBox ): searchBox is StandaloneSearchBox { - return 'updateRedirectUrl' in searchBox; + return Object.hasOwn(searchBox, 'updateRedirectUrl'); } private updateBreakpoints = once(() => updateBreakpoints(this)); diff --git a/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx b/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx index b1b4f00bffd..e8befc8b797 100644 --- a/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx +++ b/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx @@ -215,7 +215,7 @@ export class AtomicSearchBox implements InitializableComponent { private isStandaloneSearchBox( searchBox: SearchBox | StandaloneSearchBox ): searchBox is StandaloneSearchBox { - return 'redirectTo' in searchBox; + return Object.hasOwn(searchBox, 'redirectTo'); } public initialize() { @@ -254,8 +254,8 @@ export class AtomicSearchBox implements InitializableComponent { public componentWillUpdate() { if ( - !('redirectTo' in this.searchBoxState) || - !('afterRedirection' in this.searchBox) + !Object.hasOwn(this.searchBoxState, 'redirectTo') || + !Object.hasOwn(this.searchBox, 'afterRedirection') ) { return; } diff --git a/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts b/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts index 10bcb36123d..26f0de1e956 100644 --- a/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts +++ b/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts @@ -1,7 +1,8 @@ import {expect, test} from './fixture'; test.describe('default', () => { - test.beforeEach(async ({searchBox}) => { + test.beforeEach(async ({searchBox, browser}) => { + browser; await searchBox.load({args: {suggestionTimeout: 5000}}); }); From db8c680954506f15f33bd56a51dcc4e42391c96a Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Mon, 17 Nov 2025 23:41:09 -0500 Subject: [PATCH 10/13] typesafety --- .../atomic-commerce-search-box.ts | 8 +++++++- .../search/atomic-search-box/atomic-search-box.tsx | 11 ++++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts b/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts index f241e645bcd..b26dedd94c2 100644 --- a/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts +++ b/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts @@ -229,7 +229,7 @@ export class AtomicCommerceSearchBox return; } if ( - !Object.hasOwn(this.searchBoxState, 'redirectTo') || + !this.isStandaloneSearchboxState(this.searchBoxState) || !Object.hasOwn(this.searchBox, 'afterRedirection') ) { return; @@ -309,6 +309,12 @@ export class AtomicCommerceSearchBox return Object.hasOwn(searchBox, 'updateRedirectUrl'); } + private isStandaloneSearchboxState( + state: SearchBoxState | StandaloneSearchBoxState + ): state is StandaloneSearchBoxState { + return Object.hasOwn(this.searchBoxState, 'redirectTo'); + } + private updateBreakpoints = once(() => updateBreakpoints(this)); private get isSearchDisabledForEndUser() { diff --git a/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx b/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx index e8befc8b797..7bc287c2291 100644 --- a/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx +++ b/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx @@ -212,6 +212,11 @@ export class AtomicSearchBox implements InitializableComponent { @AriaLiveRegion('search-suggestions', true) protected suggestionsAriaMessage!: string; + private isStandaloneSearchBoxState(): this is (AtomicSearchBox & { + searchBoxState: StandaloneSearchBoxState}) { + return Object.hasOwn(this.searchBoxState, 'redirectTo'); + } + private isStandaloneSearchBox( searchBox: SearchBox | StandaloneSearchBox ): searchBox is StandaloneSearchBox { @@ -252,9 +257,13 @@ export class AtomicSearchBox implements InitializableComponent { }); } + private isStandaloneSearchboxState(state: SearchBoxState | StandaloneSearchBoxState): state is StandaloneSearchBoxState { + return Object.hasOwn(this.searchBoxState, 'redirectTo') + } + public componentWillUpdate() { if ( - !Object.hasOwn(this.searchBoxState, 'redirectTo') || + !this.isStandaloneSearchboxState(this.searchBoxState) || !Object.hasOwn(this.searchBox, 'afterRedirection') ) { return; From b13a810f3a819df56af51e96eb3ecbd8ef3caea0 Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Tue, 18 Nov 2025 11:50:38 -0500 Subject: [PATCH 11/13] derp --- .../atomic-commerce-search-box.ts | 4 ++-- .../search/atomic-search-box/atomic-search-box.tsx | 9 ++------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts b/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts index b26dedd94c2..3ba2e609297 100644 --- a/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts +++ b/packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts @@ -247,7 +247,7 @@ export class AtomicCommerceSearchBox const storage = new SafeStorage(); storage.setJSON(StorageItems.STANDALONE_SEARCH_BOX_DATA, data); - this.searchBox.afterRedirection(); + (this.searchBox as StandaloneSearchBox).afterRedirection(); const event = new CustomEvent('redirect'); this.dispatchEvent(event); @@ -312,7 +312,7 @@ export class AtomicCommerceSearchBox private isStandaloneSearchboxState( state: SearchBoxState | StandaloneSearchBoxState ): state is StandaloneSearchBoxState { - return Object.hasOwn(this.searchBoxState, 'redirectTo'); + return Object.hasOwn(state, 'redirectTo'); } private updateBreakpoints = once(() => updateBreakpoints(this)); diff --git a/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx b/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx index 7bc287c2291..54262178287 100644 --- a/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx +++ b/packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx @@ -212,11 +212,6 @@ export class AtomicSearchBox implements InitializableComponent { @AriaLiveRegion('search-suggestions', true) protected suggestionsAriaMessage!: string; - private isStandaloneSearchBoxState(): this is (AtomicSearchBox & { - searchBoxState: StandaloneSearchBoxState}) { - return Object.hasOwn(this.searchBoxState, 'redirectTo'); - } - private isStandaloneSearchBox( searchBox: SearchBox | StandaloneSearchBox ): searchBox is StandaloneSearchBox { @@ -258,7 +253,7 @@ export class AtomicSearchBox implements InitializableComponent { } private isStandaloneSearchboxState(state: SearchBoxState | StandaloneSearchBoxState): state is StandaloneSearchBoxState { - return Object.hasOwn(this.searchBoxState, 'redirectTo') + return Object.hasOwn(state, 'redirectTo') } public componentWillUpdate() { @@ -282,7 +277,7 @@ export class AtomicSearchBox implements InitializableComponent { const storage = new SafeStorage(); storage.setJSON(StorageItems.STANDALONE_SEARCH_BOX_DATA, data); - this.searchBox.afterRedirection(); + (this.searchBox as StandaloneSearchBox).afterRedirection(); const event = this.redirect.emit({redirectTo, value}); if (!event.defaultPrevented) { window.location.href = redirectTo; From 96324b55ed01e205840ce5146cf2b694b17c0b9f Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Wed, 19 Nov 2025 00:18:07 -0500 Subject: [PATCH 12/13] Potential fix for pull request finding 'Expression has no effect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> --- .../search/atomic-search-box/e2e/atomic-search-box.e2e.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts b/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts index 26f0de1e956..91c02f1baae 100644 --- a/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts +++ b/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts @@ -2,7 +2,6 @@ import {expect, test} from './fixture'; test.describe('default', () => { test.beforeEach(async ({searchBox, browser}) => { - browser; await searchBox.load({args: {suggestionTimeout: 5000}}); }); From 777e77c89bd87a120ba09e737cae31c9ad459995 Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Wed, 19 Nov 2025 00:19:31 -0500 Subject: [PATCH 13/13] Update packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts --- .../search/atomic-search-box/e2e/atomic-search-box.e2e.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts b/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts index 91c02f1baae..10bcb36123d 100644 --- a/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts +++ b/packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts @@ -1,7 +1,7 @@ import {expect, test} from './fixture'; test.describe('default', () => { - test.beforeEach(async ({searchBox, browser}) => { + test.beforeEach(async ({searchBox}) => { await searchBox.load({args: {suggestionTimeout: 5000}}); });