Merge pull request #248 from petli/bug-in-performance-test

Fix bug in the performance test and document how to run it in README.md.

Author: tonerdo

README.md

@@ -387,6 +387,15 @@ This will result in the following:
 
 These steps must be followed before you attempt to open the solution in an IDE (e.g. Visual Studio, Rider) for all projects to be loaded successfully.
 
+### Performance testing
+
+There is a performance test for the hit counting instrumentation in the test project `coverlet.core.performancetest`.  Build the project with the msbuild step above and then run:
+
+    dotnet test /p:CollectCoverage=true test/coverlet.core.performancetest/
+
+The duration of the test can be tweaked by changing the number of iterations in the `[InlineData]` in the `PerformanceTest` class.
+
+
 ## Code of Conduct
 
 This project enforces a code of conduct in line with the contributor covenant. See [CODE OF CONDUCT](CODE_OF_CONDUCT.md) for details.

test/coverlet.core.performancetest/PerformanceTest.cs

@@ -9,7 +9,7 @@ namespace coverlet.core.performancetest
     /// Test the performance of coverlet by running a unit test that calls a reasonably big and complex test class.
     /// Enable the test, compile, then run the test in the command line:
     /// <code>
-    /// dotnet test -p:CollectCoverage=true -p:CoverletOutputFormat=opencover test/coverlet.core.performancetest/
+    /// dotnet test /p:CollectCoverage=true test/coverlet.core.performancetest/
     /// </code>
     /// </summary>
     public class PerformanceTest
@@ -20,11 +20,12 @@ public void TestPerformance(int iterations)
         {
             var big = new BigClass();
 
-            List<Task> tasks = new List<Task>();
+            var tasks = new List<Task>();
 
             for (var i = 0; i < iterations; i++)
             {
-                tasks.Add(Task.Run(() => big.Do(i)));
+                var j = i;
+                tasks.Add(Task.Run(() => big.Do(j)));
             }
 
             Task.WaitAll(tasks.ToArray());