Merge pull request #375 from tonerdo/fix-embeddedpdb-backups

tonerdo · web-flow · commit 4be53656e937 · 2019-04-01T11:21:51.000+01:00
Fix Backup Symbol File Restore for Embedded PDBs
diff --git a/src/coverlet.core/Helpers/InstrumentationHelper.cs b/src/coverlet.core/Helpers/InstrumentationHelper.cs
@@ -109,8 +109,11 @@ public static void RestoreOriginalModule(string module, string identifier)
 
             RetryHelper.Retry(() =>
             {
-                File.Copy(backupSymbolPath, Path.ChangeExtension(module, ".pdb"), true);
-                File.Delete(backupSymbolPath);
+                if (File.Exists(backupSymbolPath))
+                {
+                    File.Copy(backupSymbolPath, Path.ChangeExtension(module, ".pdb"), true);
+                    File.Delete(backupSymbolPath);
+                }
             }, retryStrategy, 10);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,11 @@ public static void RestoreOriginalModule(string module, string identifier)`
`109`	`109`
`110`	`110`	`RetryHelper.Retry(() =>`
`111`	`111`	`{`
`112`		`- File.Copy(backupSymbolPath, Path.ChangeExtension(module, ".pdb"), true);`
`113`		`- File.Delete(backupSymbolPath);`
	`112`	`+ if (File.Exists(backupSymbolPath))`
	`113`	`+ {`
	`114`	`+ File.Copy(backupSymbolPath, Path.ChangeExtension(module, ".pdb"), true);`
	`115`	`+ File.Delete(backupSymbolPath);`
	`116`	`+ }`
`114`	`117`	`}, retryStrategy, 10);`
`115`	`118`	`}`
`116`	`119`