Merge pull request #259 from tonerdo/embedded-pdbs

Add support for assemblies with embedded PDBs

Author: tonerdo

build.proj

@@ -25,7 +25,7 @@
   </Target>
 
   <Target Name="RunTests" AfterTargets="CopyMSBuildScripts">
-    <Exec Command="dotnet test &quot;$(MSBuildThisFileDirectory)test\coverlet.core.tests\coverlet.core.tests.csproj&quot; -c $(Configuration) /p:CollectCoverage=true /p:CoverletOutputFormat=opencover"/>
+    <Exec Command="dotnet test &quot;$(MSBuildThisFileDirectory)test\coverlet.core.tests\coverlet.core.tests.csproj&quot; -c $(Configuration) /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:Include=[coverlet.*]*"/>
   </Target>
 
   <Target Name="CreateNuGetPackage" AfterTargets="RunTests" Condition="$(Configuration) == 'Release'">

src/coverlet.core/Helpers/InstrumentationHelper.cs

@@ -69,8 +69,13 @@ public static bool HasPdb(string module)
                     if (entry.Type == DebugDirectoryEntryType.CodeView)
                     {
                         var codeViewData = peReader.ReadCodeViewDebugDirectoryData(entry);
-                        var peDirectory = Path.GetDirectoryName(module);
-                        return File.Exists(Path.Combine(peDirectory, Path.GetFileName(codeViewData.Path)));
+                        if (codeViewData.Path == $"{Path.GetFileNameWithoutExtension(module)}.pdb")
+                        {
+                            // PDB is embedded
+                            return true;
+                        }
+
+                        return File.Exists(codeViewData.Path);
                     }
                 }