Fix source file check for non portable pdb (#558)

Fix source file check for non portable pdb

Author: MarcoRossignoli

src/coverlet.core/Coverage.cs

@@ -81,6 +81,7 @@ public CoveragePrepareResult PrepareModules()
 
             Array.ForEach(_excludeFilters ?? Array.Empty<string>(), filter => _logger.LogVerbose($"Excluded module filter '{filter}'"));
             Array.ForEach(_includeFilters ?? Array.Empty<string>(), filter => _logger.LogVerbose($"Included module filter '{filter}'"));
+            Array.ForEach(_excludedSourceFiles ?? Array.Empty<string>(), filter => _logger.LogVerbose($"Excluded source files filter '{filter}'"));
 
             _excludeFilters = _excludeFilters?.Where(f => _instrumentationHelper.IsValidFilterExpression(f)).ToArray();
             _includeFilters = _includeFilters?.Where(f => _instrumentationHelper.IsValidFilterExpression(f)).ToArray();

src/coverlet.core/Helpers/InstrumentationHelper.cs

@@ -146,7 +146,17 @@ public bool PortablePdbHasLocalSource(string module, out string firstNotFoundDoc
                         var codeViewData = peReader.ReadCodeViewDebugDirectoryData(entry);
                         using FileStream pdbStream = new FileStream(codeViewData.Path, FileMode.Open);
                         using MetadataReaderProvider metadataReaderProvider = MetadataReaderProvider.FromPortablePdbStream(pdbStream);
-                        MetadataReader metadataReader = metadataReaderProvider.GetMetadataReader();
+                        MetadataReader metadataReader = null;
+                        try
+                        {
+                            metadataReader = metadataReaderProvider.GetMetadataReader();
+                        }
+                        catch (BadImageFormatException)
+                        {
+                            // TODO log this to warning
+                            // In case of non portable pdb we get exception so we skip file sources check
+                            return true;
+                        }
                         foreach (DocumentHandle docHandle in metadataReader.Documents)
                         {
                             Document document = metadataReader.GetDocument(docHandle);

src/coverlet.core/Instrumentation/Instrumenter.cs

@@ -779,7 +779,6 @@ public ExcludedFilesHelper(string[] excludes, ILogger logger)
                     {
                         continue;
                     }
-                    logger.LogVerbose($"Excluded source file rule '{excludeRule}'");
                     _matcher.AddInclude(Path.IsPathRooted(excludeRule) ? excludeRule.Substring(Path.GetPathRoot(excludeRule).Length) : excludeRule);
                 }
             }