Skip to content

Commit 8eaaecb

Browse files
authored
Invariant CLI output (#1264)
Invariant CLI output
1 parent a54a894 commit 8eaaecb

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

Documentation/Changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77
## Unreleased
88

99
### Fixed
10+
-Fix summary output format for culture de-DE [#1263](https://github.com/coverlet-coverage/coverlet/issues/1263)
1011
-Fix branch coverage issue for finally block with await [#1233](https://github.com/coverlet-coverage/coverlet/issues/1233)
1112
-Fix threshold doesn't work when coverage empty [#1205](https://github.com/coverlet-coverage/coverlet/issues/1205)
1213
-Fix branch coverage issue for il switch [#1177](https://github.com/coverlet-coverage/coverlet/issues/1177)

src/coverlet.console/Program.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
using System.Collections.Generic;
33
using System.ComponentModel;
44
using System.Diagnostics;
5+
using System.Globalization;
56
using System.IO;
67
using System.Linq;
78
using System.Text;
@@ -248,7 +249,7 @@ static int Main(string[] args)
248249
var branchPercent = summary.CalculateBranchCoverage(_module.Value).Percent;
249250
var methodPercent = summary.CalculateMethodCoverage(_module.Value).Percent;
250251

251-
coverageTable.AddRow(Path.GetFileNameWithoutExtension(_module.Key), $"{linePercent}%", $"{branchPercent}%", $"{methodPercent}%");
252+
coverageTable.AddRow(Path.GetFileNameWithoutExtension(_module.Key), $"{InvariantFormat(linePercent)}%", $"{InvariantFormat(branchPercent)}%", $"{InvariantFormat(methodPercent)}%");
252253
}
253254

254255
logger.LogInformation(coverageTable.ToStringAlternative());
@@ -257,8 +258,8 @@ static int Main(string[] args)
257258
coverageTable.Rows.Clear();
258259

259260
coverageTable.AddColumn(new[] { "", "Line", "Branch", "Method" });
260-
coverageTable.AddRow("Total", $"{totalLinePercent}%", $"{totalBranchPercent}%", $"{totalMethodPercent}%");
261-
coverageTable.AddRow("Average", $"{averageLinePercent}%", $"{averageBranchPercent}%", $"{averageMethodPercent}%");
261+
coverageTable.AddRow("Total", $"{InvariantFormat(totalLinePercent)}%", $"{InvariantFormat(totalBranchPercent)}%", $"{InvariantFormat(totalMethodPercent)}%");
262+
coverageTable.AddRow("Average", $"{InvariantFormat(averageLinePercent)}%", $"{InvariantFormat(averageBranchPercent)}%", $"{InvariantFormat(averageMethodPercent)}%");
262263

263264
logger.LogInformation(coverageTable.ToStringAlternative());
264265
if (process.ExitCode > 0)
@@ -314,5 +315,7 @@ static int Main(string[] args)
314315
}
315316

316317
static string GetAssemblyVersion() => typeof(Program).Assembly.GetName().Version.ToString();
318+
319+
static string InvariantFormat(double value) => value.ToString(CultureInfo.InvariantCulture);
317320
}
318321
}

src/coverlet.msbuild.tasks/CoverageResultTask.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.Collections.Generic;
3+
using System.Globalization;
34
using System.IO;
45
using System.Linq;
56
using System.Text;
@@ -206,7 +207,7 @@ public override bool Execute()
206207
var branchPercent = summary.CalculateBranchCoverage(module.Value).Percent;
207208
var methodPercent = summary.CalculateMethodCoverage(module.Value).Percent;
208209

209-
coverageTable.AddRow(Path.GetFileNameWithoutExtension(module.Key), $"{linePercent}%", $"{branchPercent}%", $"{methodPercent}%");
210+
coverageTable.AddRow(Path.GetFileNameWithoutExtension(module.Key), $"{InvariantFormat(linePercent)}%", $"{InvariantFormat(branchPercent)}%", $"{InvariantFormat(methodPercent)}%");
210211
}
211212

212213
Console.WriteLine();
@@ -216,8 +217,8 @@ public override bool Execute()
216217
coverageTable.Rows.Clear();
217218

218219
coverageTable.AddColumn(new[] { "", "Line", "Branch", "Method" });
219-
coverageTable.AddRow("Total", $"{totalLinePercent}%", $"{totalBranchPercent}%", $"{totalMethodPercent}%");
220-
coverageTable.AddRow("Average", $"{averageLinePercent}%", $"{averageBranchPercent}%", $"{averageMethodPercent}%");
220+
coverageTable.AddRow("Total", $"{InvariantFormat(totalLinePercent)}%", $"{InvariantFormat(totalBranchPercent)}%", $"{InvariantFormat(totalMethodPercent)}%");
221+
coverageTable.AddRow("Average", $"{InvariantFormat(averageLinePercent)}%", $"{InvariantFormat(averageBranchPercent)}%", $"{InvariantFormat(averageMethodPercent)}%");
221222

222223
Console.WriteLine(coverageTable.ToStringAlternative());
223224

@@ -254,5 +255,7 @@ public override bool Execute()
254255

255256
return true;
256257
}
258+
259+
private static string InvariantFormat(double value) => value.ToString(CultureInfo.InvariantCulture);
257260
}
258261
}

0 commit comments

Comments
 (0)