Skip to content

Commit b67be9c

Browse files
committed
update package and framework versions
1 parent cef7021 commit b67be9c

File tree

8 files changed

+67
-31
lines changed

8 files changed

+67
-31
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,3 +318,4 @@ FolderProfile.pubxml
318318
/NuGet.config
319319
nuget.config
320320
*.dmp
321+
/test/coverlet.core.coverage.tests/System.Private.CoreLib-version.png

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ Contributions are highly welcome, however, except for very small changes, kindly
44

55
## Requirements
66

7-
[.NET SDK 6.0](https://dotnet.microsoft.com/en-us/download/dotnet/6.0)
8-
[.NET SDK 7.0](https://dotnet.microsoft.com/en-us/download/dotnet/7.0)
9-
[.NET SDK 8.0](https://dotnet.microsoft.com/en-us/download/dotnet/8.0)
7+
STS version [.NET SDK 9.0](https://dotnet.microsoft.com/en-us/download/dotnet/9.0) for development environment
8+
9+
LTS version [.NET SDK 8.0](https://dotnet.microsoft.com/en-us/download/dotnet/9.0) for runtime environment
1010

1111
## Building the Project
1212

Directory.Packages.props

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,19 @@
99
</ItemGroup>
1010
<PropertyGroup>
1111
<MicrosoftBuildVersion>17.13.9</MicrosoftBuildVersion>
12-
<MicrosoftCodeAnalysisVersion>4.12.0</MicrosoftCodeAnalysisVersion>
12+
<MicrosoftCodeAnalysisVersion>4.13.0</MicrosoftCodeAnalysisVersion>
1313
<!-- Test Platform, .NET Test SDK and Object Model -->
1414
<MicrosoftNETTestSdkVersion>17.13.0</MicrosoftNETTestSdkVersion>
1515
<NugetPackageVersion>6.13.2</NugetPackageVersion>
16-
<XunitV3Version>2.0.0</XunitV3Version>
17-
<XunitRunnerVisualstudioVersion>3.0.2</XunitRunnerVisualstudioVersion>
16+
<XunitV3Version>2.0.2</XunitV3Version>
17+
<XunitRunnerVisualstudioVersion>3.1.0</XunitRunnerVisualstudioVersion>
1818
</PropertyGroup>
1919
<ItemGroup>
2020
<PackageVersion Include="DotNetConfig" Version="1.2.0" />
2121
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
2222
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildVersion)" />
2323
<PackageVersion Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildVersion)" />
24-
<PackageVersion Include="Microsoft.Build.Locator" Version="1.7.8" />
24+
<PackageVersion Include="Microsoft.Build.Locator" Version="1.9.1" />
2525
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="$(MicrosoftCodeAnalysisVersion)" />
2626
<PackageVersion Include="Microsoft.Extensions.DependencyModel" Version="8.0.2" />
2727
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />

Documentation/VSTestIntegration.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ or
4343
```text
4444
dotnet publish
4545
...
46-
... -> C:\project\bin\Debug\net6.0\testdll.dll
47-
... -> C:\project\bin\Debug\net6.0\publish\
46+
... -> C:\project\bin\Debug\net8.0\testdll.dll
47+
... -> C:\project\bin\Debug\net8.0\publish\
4848
...
49-
dotnet vstest C:\project\bin\Debug\net6.0\publish\testdll.dll --collect:"XPlat Code Coverage"
49+
dotnet vstest C:\project\bin\Debug\net8.0\publish\testdll.dll --collect:"XPlat Code Coverage"
5050
```
5151

5252
As you can see in case of `vstest` verb you **must** publish project before.

src/coverlet.core/coverlet.core.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<PackageReference Include="Mono.Cecil" />
1616
<PackageReference Include="NuGet.Versioning" />
1717
<PackageReference Include="System.Text.Json" />
18+
<PackageReference Include="System.Threading.Tasks.Extensions" />
1819
</ItemGroup>
1920

2021
<ItemGroup Condition="'$(TargetFramework)' != 'netstandard2.0'">
@@ -25,7 +26,6 @@
2526
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
2627
<PackageReference Include="System.Reflection.Metadata" VersionOverride="$(SystemReflectionMetadataVersion)" />
2728
<PackageReference Include="System.Collections.Immutable" VersionOverride="$(SystemCollectionsImmutableVersion)" />
28-
<PackageReference Include="System.Threading.Tasks.Extensions" />
2929
</ItemGroup>
3030

3131
</Project>

test/coverlet.core.tests.samples.netstandard/coverlet.core.tests.samples.netstandard.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<ItemGroup>
1010
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
11-
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.6.0" />
11+
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.6.3" />
1212
</ItemGroup>
1313

1414
</Project>

test/coverlet.integration.tests/Msbuild.cs

Lines changed: 53 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System;
55
using System.IO;
66
using System.Linq;
7+
using System.Runtime.InteropServices;
78
using Coverlet.Tests.Utils;
89
using Xunit;
910

@@ -109,7 +110,7 @@ public void TestMsbuild_CoverletOutput_Folder_FileNameExtension()
109110
public void TestMsbuild_CoverletOutput_Folder_FileNameExtension_SpecifyFramework()
110111
{
111112
using ClonedTemplateProject clonedTemplateProject = PrepareTemplateProject();
112-
string[] targetFrameworks = new string[] { "net6.0" };
113+
string[] targetFrameworks = new string[] { "net8.0" };
113114
UpdateProjectTargetFramework(clonedTemplateProject, targetFrameworks);
114115
Assert.False(clonedTemplateProject.IsMultipleTargetFramework());
115116
string framework = clonedTemplateProject.GetTargetFrameworks().Single();
@@ -152,7 +153,8 @@ public void TestMsbuild_CoverletOutput_Folder_FileNameWithDoubleExtension()
152153
public void Test_MultipleTargetFrameworkReport_NoCoverletOutput()
153154
{
154155
using ClonedTemplateProject clonedTemplateProject = PrepareTemplateProject();
155-
string[] targetFrameworks = new string[] { "net6.0", "net8.0" };
156+
string[] targetFrameworks = new string[] { "net8.0" };
157+
string fileToCheck = "";
156158
UpdateProjectTargetFramework(clonedTemplateProject, targetFrameworks);
157159
DotnetCli($"test -c {_buildConfiguration} \"{clonedTemplateProject.ProjectRootPath}\" /p:CollectCoverage=true /p:Include=\"[{ClonedTemplateProject.AssemblyName}]*DeepThought\" /p:IncludeTestAssembly=true", out string standardOutput, out string standardError, clonedTemplateProject.ProjectRootPath!);
158160
if (!string.IsNullOrEmpty(standardError))
@@ -168,17 +170,24 @@ public void Test_MultipleTargetFrameworkReport_NoCoverletOutput()
168170

169171
foreach (string targetFramework in targetFrameworks)
170172
{
171-
Assert.True(File.Exists(Path.Combine(clonedTemplateProject.ProjectRootPath, $"coverage.{targetFramework}.json")));
173+
//if targetFrameworks has more than one framework
174+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"coverage.{targetFramework}.json");
175+
if (targetFrameworks.Length == 1)
176+
{
177+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"coverage.json");
178+
}
179+
Assert.True(File.Exists(fileToCheck), $"Expected file '{fileToCheck}'\nOutput:\n{standardOutput}");
172180
}
173181

174-
AssertCoverage(clonedTemplateProject, "coverage.*.json");
182+
AssertCoverage(clonedTemplateProject, Path.GetFileName(fileToCheck));
175183
}
176184

177185
[Fact]
178186
public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder()
179187
{
180188
using ClonedTemplateProject clonedTemplateProject = PrepareTemplateProject();
181-
string[] targetFrameworks = new string[] { "net6.0", "net8.0" };
189+
string[] targetFrameworks = new string[] { "net8.0" };
190+
string fileToCheck = "";
182191
UpdateProjectTargetFramework(clonedTemplateProject, targetFrameworks);
183192
int result = DotnetCli($"test -c {_buildConfiguration} \"{clonedTemplateProject.ProjectRootPath}\" /p:CollectCoverage=true /p:Include=\"[{ClonedTemplateProject.AssemblyName}]*DeepThought\" /p:IncludeTestAssembly=true /p:CoverletOutput=\"{clonedTemplateProject.ProjectRootPath}\"\\", out string standardOutput, out string standardError, clonedTemplateProject.ProjectRootPath!);
184193
if (!string.IsNullOrEmpty(standardError))
@@ -195,18 +204,24 @@ public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder()
195204

196205
foreach (string targetFramework in targetFrameworks)
197206
{
198-
string fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"coverage.{targetFramework}.json");
207+
//if targetFrameworks has more than one framework
208+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"coverage.{targetFramework}.json");
209+
if (targetFrameworks.Length == 1)
210+
{
211+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"coverage.json");
212+
}
199213
Assert.True(File.Exists(fileToCheck), $"Expected file '{fileToCheck}'\nOutput:\n{standardOutput}");
200214
}
201215

202-
AssertCoverage(clonedTemplateProject, "coverage.*.json");
216+
AssertCoverage(clonedTemplateProject, Path.GetFileName(fileToCheck));
203217
}
204218

205219
[Fact]
206220
public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWithoutExtension()
207221
{
208222
using ClonedTemplateProject clonedTemplateProject = PrepareTemplateProject();
209-
string[] targetFrameworks = new string[] { "net6.0", "net8.0" };
223+
string[] targetFrameworks = new string[] { "net8.0" };
224+
string fileToCheck = "";
210225
UpdateProjectTargetFramework(clonedTemplateProject, targetFrameworks);
211226
DotnetCli($"test -c {_buildConfiguration} \"{clonedTemplateProject.ProjectRootPath}\" /p:CollectCoverage=true /p:Include=\"[{ClonedTemplateProject.AssemblyName}]*DeepThought\" /p:IncludeTestAssembly=true /p:CoverletOutput=\"{clonedTemplateProject.ProjectRootPath}\"\\file", out string standardOutput, out string standardError, clonedTemplateProject.ProjectRootPath!);
212227
if (!string.IsNullOrEmpty(standardError))
@@ -222,17 +237,24 @@ public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWit
222237

223238
foreach (string targetFramework in targetFrameworks)
224239
{
225-
Assert.True(File.Exists(Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.{targetFramework}.json")));
240+
//if targetFrameworks has more than one framework
241+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.{targetFramework}.json");
242+
if (targetFrameworks.Length == 1)
243+
{
244+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.json");
245+
}
246+
Assert.True(File.Exists(fileToCheck), $"Expected file '{fileToCheck}'\nOutput:\n{standardOutput}");
226247
}
227248

228-
AssertCoverage(clonedTemplateProject, "file.*.json");
249+
AssertCoverage(clonedTemplateProject, Path.GetFileName(fileToCheck));
229250
}
230251

231252
[Fact]
232253
public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWithExtension_SpecifyFramework()
233254
{
255+
Assert.SkipUnless(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "Test requires Windows [net48]");
234256
using ClonedTemplateProject clonedTemplateProject = PrepareTemplateProject();
235-
string[] targetFrameworks = new string[] { "net6.0", "net8.0" };
257+
string[] targetFrameworks = new string[] { "net8.0", "net48" };
236258
UpdateProjectTargetFramework(clonedTemplateProject, targetFrameworks);
237259
Assert.True(clonedTemplateProject.IsMultipleTargetFramework());
238260
string[] frameworks = clonedTemplateProject.GetTargetFrameworks();
@@ -261,15 +283,15 @@ public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWit
261283
Assert.False(File.Exists(Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.{targetFramework}.ext")));
262284
}
263285
}
264-
265286
AssertCoverage(clonedTemplateProject, "file.*.ext");
266287
}
267288

268289
[Fact]
269290
public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWithExtension()
270291
{
271292
using ClonedTemplateProject clonedTemplateProject = PrepareTemplateProject();
272-
string[] targetFrameworks = new string[] { "net6.0", "net8.0" };
293+
string[] targetFrameworks = new string[] { "net8.0" };
294+
string fileToCheck = "";
273295
UpdateProjectTargetFramework(clonedTemplateProject, targetFrameworks);
274296
DotnetCli($"test -c {_buildConfiguration} \"{clonedTemplateProject.ProjectRootPath}\" /p:CollectCoverage=true /p:Include=\"[{ClonedTemplateProject.AssemblyName}]*DeepThought\" /p:IncludeTestAssembly=true /p:CoverletOutput=\"{clonedTemplateProject.ProjectRootPath}\"\\file.ext", out string standardOutput, out string standardError, clonedTemplateProject.ProjectRootPath!);
275297
if (!string.IsNullOrEmpty(standardError))
@@ -285,17 +307,24 @@ public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWit
285307

286308
foreach (string targetFramework in targetFrameworks)
287309
{
288-
Assert.True(File.Exists(Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.{targetFramework}.ext")));
310+
//if targetFrameworks has more than one framework
311+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.{targetFramework}.ext");
312+
if (targetFrameworks.Length == 1)
313+
{
314+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.ext");
315+
}
316+
Assert.True(File.Exists(fileToCheck), $"Expected file '{fileToCheck}'\nOutput:\n{standardOutput}");
289317
}
290318

291-
AssertCoverage(clonedTemplateProject, "file.*.ext");
319+
AssertCoverage(clonedTemplateProject, Path.GetFileName(fileToCheck));
292320
}
293321

294322
[Fact]
295323
public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWithDoubleExtension()
296324
{
297325
using ClonedTemplateProject clonedTemplateProject = PrepareTemplateProject();
298-
string[] targetFrameworks = new string[] { "net6.0", "net8.0" };
326+
string[] targetFrameworks = new string[] { "net8.0" };
327+
string fileToCheck = "";
299328
UpdateProjectTargetFramework(clonedTemplateProject, targetFrameworks);
300329
DotnetCli($"test -c {_buildConfiguration} \"{clonedTemplateProject.ProjectRootPath}\" /p:CollectCoverage=true /p:Include=\"[{ClonedTemplateProject.AssemblyName}]*DeepThought\" /p:IncludeTestAssembly=true /p:CoverletOutput=\"{clonedTemplateProject.ProjectRootPath}\"\\file.ext1.ext2", out string standardOutput, out string standardError, clonedTemplateProject.ProjectRootPath!);
301330
if (!string.IsNullOrEmpty(standardError))
@@ -311,10 +340,16 @@ public void Test_MultipleTargetFrameworkReport_CoverletOutput_Folder_FileNameWit
311340

312341
foreach (string targetFramework in targetFrameworks)
313342
{
314-
Assert.True(File.Exists(Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.ext1.{targetFramework}.ext2")));
343+
//if targetFrameworks has more than one framework
344+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, $"file.ext1.{targetFramework}.ext2");
345+
if (targetFrameworks.Length == 1)
346+
{
347+
fileToCheck = Path.Combine(clonedTemplateProject.ProjectRootPath, "file.ext1.ext2");
348+
}
349+
Assert.True(File.Exists(fileToCheck), $"Expected file '{fileToCheck}'\nOutput:\n{standardOutput}");
315350
}
316351

317-
AssertCoverage(clonedTemplateProject, "file.ext1.*.ext2");
352+
AssertCoverage(clonedTemplateProject, Path.GetFileName(fileToCheck));
318353
}
319354
}
320355
}

test/coverlet.tests.projectsample.aspmvcrazor/coverlet.tests.projectsample.aspmvcrazor.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFramework>net8.0</TargetFramework>
55
<ImplicitUsings>enable</ImplicitUsings>
66
<IsPackable>false</IsPackable>
77
<IsTestProject>false</IsTestProject>

0 commit comments

Comments
 (0)