Skip to content

Commit dcc3c29

Browse files
Joseph SunJosephSun2003
authored andcommitted
Fix problems encountered with newly added method and variables from unit testing with existing tests
1 parent 88a5782 commit dcc3c29

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/coverlet.collector/Utilities/Interfaces/ICoverageWrapper.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ internal interface ICoverageWrapper
4242
/// <summary>
4343
/// Unload module in the specified path
4444
/// </summary>
45-
/// <param name="modulePath"></param>
45+
/// <param name="coverage"></param>
46+
/// <param name="modulePath"> path of the module to be unloaded</param>
4647
void UnloadModule(Coverage coverage, string modulePath);
4748

4849
}

src/coverlet.core/Coverage.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ internal class Coverage
5757
private readonly ICecilSymbolHelper _cecilSymbolHelper;
5858
private readonly List<InstrumenterResult> _results;
5959
private readonly CoverageParameters _parameters;
60+
private readonly List<string> _unloadedModules;
6061

6162
public string Identifier { get; }
62-
private List<string> unloadedModules { get; set; }
6363

6464
public Coverage(string moduleOrDirectory,
6565
CoverageParameters parameters,
@@ -79,7 +79,7 @@ public Coverage(string moduleOrDirectory,
7979
_cecilSymbolHelper = cecilSymbolHelper;
8080
Identifier = Guid.NewGuid().ToString();
8181
_results = new List<InstrumenterResult>();
82-
unloadedModules = new List<string>();
82+
_unloadedModules = new List<string>();
8383
}
8484

8585
public Coverage(CoveragePrepareResult prepareResult,
@@ -96,6 +96,7 @@ public Coverage(CoveragePrepareResult prepareResult,
9696
_instrumentationHelper = instrumentationHelper;
9797
_fileSystem = fileSystem;
9898
_sourceRootTranslator = sourceRootTranslator;
99+
_unloadedModules = new List<string>();
99100
}
100101

101102
public CoveragePrepareResult PrepareModules()
@@ -243,7 +244,7 @@ public CoverageResult GetCoverageResult()
243244
}
244245

245246
modules.Add(Path.GetFileName(result.ModulePath), documents);
246-
if (!unloadedModules.Contains(result.ModulePath))
247+
if (!_unloadedModules.Contains(result.ModulePath))
247248
{
248249
UnloadModule(result.ModulePath);
249250
}
@@ -337,7 +338,7 @@ public CoverageResult GetCoverageResult()
337338
/// <param name="modulePath"></param>
338339
public void UnloadModule(string modulePath)
339340
{
340-
unloadedModules.Add(modulePath);
341+
_unloadedModules.Add(modulePath);
341342
_instrumentationHelper.RestoreOriginalModule(modulePath, Identifier);
342343
}
343344

0 commit comments

Comments
 (0)