Skip to content

Commit f9b8adb

Browse files
committed
refactor: Replace GetAssemblyBuildConfiguration with GetBuildConfigurationString for consistency and lowercase output
1 parent 6b8167c commit f9b8adb

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

test/coverlet.integration.tests/Collectors.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public abstract class Collectors : BaseTest
5050

5151
public Collectors()
5252
{
53-
_buildConfiguration = TestUtils.GetAssemblyBuildConfiguration().ToString();
53+
_buildConfiguration = TestUtils.GetBuildConfigurationString();
5454
_buildTargetFramework = TestUtils.GetAssemblyTargetFramework();
5555
}
5656

test/coverlet.integration.tests/DeterministicBuild.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class DeterministicBuild : BaseTest, IDisposable
3232

3333
public DeterministicBuild(ITestOutputHelper output)
3434
{
35-
_buildConfiguration = TestUtils.GetAssemblyBuildConfiguration().ToString();
35+
_buildConfiguration = TestUtils.GetBuildConfigurationString();
3636
_buildTargetFramework = TestUtils.GetAssemblyTargetFramework();
3737
_artifactsPivot = _buildConfiguration + "_" + _buildTargetFramework;
3838
_output = output;
@@ -74,7 +74,7 @@ private void CreateDeterministicTestPropsFile()
7474

7575
private protected void AssertCoverage(string standardOutput = "", string reportName = "", bool checkDeterministicReport = true)
7676
{
77-
if (_buildConfiguration == "Debug")
77+
if (_buildConfiguration == "debug")
7878
{
7979
bool coverageChecked = false;
8080
string reportFilePath = "";

test/coverlet.integration.tests/Msbuild.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class Msbuild : BaseTest
1717

1818
public Msbuild(ITestOutputHelper output)
1919
{
20-
_buildConfiguration = TestUtils.GetAssemblyBuildConfiguration().ToString();
20+
_buildConfiguration = TestUtils.GetBuildConfigurationString();
2121
_buildTargetFramework = TestUtils.GetAssemblyTargetFramework();
2222
_output = output;
2323
}

test/coverlet.tests.utils/TestUtils.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,12 @@ public static string GetAssemblyTargetFramework()
4545
throw new NotSupportedException($"Build configuration not supported");
4646
}
4747

48+
public static string GetBuildConfigurationString()
49+
{
50+
// Returns lowercase configuration string to match MSBuild output paths on case-sensitive filesystems
51+
return GetAssemblyBuildConfiguration().ToString().ToLower();
52+
}
53+
4854
public static string GetTestProjectPath(string directoryName)
4955
{
5056
return Path.Join(Path.GetFullPath(Path.Join(AppContext.BaseDirectory, s_rel4Parents)), "test", directoryName);

0 commit comments

Comments
 (0)