From dd5950b60658d4dc35615ad4088396db1f13f744 Mon Sep 17 00:00:00 2001 From: Kian McKenna Date: Wed, 23 Oct 2024 10:23:05 -0500 Subject: [PATCH 1/3] fix: disable nav scroll while menu is open --- packages/site-kit/src/lib/nav/Nav.svelte | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/site-kit/src/lib/nav/Nav.svelte b/packages/site-kit/src/lib/nav/Nav.svelte index 0f8a23448c..21b00780ee 100644 --- a/packages/site-kit/src/lib/nav/Nav.svelte +++ b/packages/site-kit/src/lib/nav/Nav.svelte @@ -47,6 +47,10 @@ Top navigation bar for the application. It provides a slot for the left side, th last_scroll = scroll; hash_changed = false; } + + $effect(() => { + document.body.style.overflow = open ? 'hidden' : 'scroll'; + }) Date: Wed, 23 Oct 2024 10:28:44 -0500 Subject: [PATCH 2/3] format --- packages/site-kit/src/lib/nav/Nav.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/site-kit/src/lib/nav/Nav.svelte b/packages/site-kit/src/lib/nav/Nav.svelte index 21b00780ee..7e20217a1f 100644 --- a/packages/site-kit/src/lib/nav/Nav.svelte +++ b/packages/site-kit/src/lib/nav/Nav.svelte @@ -50,7 +50,7 @@ Top navigation bar for the application. It provides a slot for the left side, th $effect(() => { document.body.style.overflow = open ? 'hidden' : 'scroll'; - }) + }); Date: Thu, 24 Oct 2024 13:51:46 +0200 Subject: [PATCH 3/3] fix: unset overflow when nav is closed --- packages/site-kit/src/lib/nav/Nav.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/site-kit/src/lib/nav/Nav.svelte b/packages/site-kit/src/lib/nav/Nav.svelte index 7e20217a1f..8dd1d77866 100644 --- a/packages/site-kit/src/lib/nav/Nav.svelte +++ b/packages/site-kit/src/lib/nav/Nav.svelte @@ -49,7 +49,7 @@ Top navigation bar for the application. It provides a slot for the left side, th } $effect(() => { - document.body.style.overflow = open ? 'hidden' : 'scroll'; + document.body.style.overflow = open ? 'hidden' : ''; });