Commit 39d7f4d
authored
Fallback to the default Balancer Vault address during the deployment (#243)
## Description
This PR updates the GPv2Settlement SC deployment script to default to
the deterministic Balancer Vault
address(`0xBA12222222228d8Ba445958a75a0704d566BF2C8`) when it is not
actually deployed yet.
While the GPv2Settlement contract accepts a Balancer Vault address in
its constructor, it does not strictly require the Vault to be deployed
for basic ERC20 settlement functionality. This was confirmed in internal
discussion:
- On Gnosis Chain, we used the Settlement contract before the Balancer
Vault was even available.
- The contract only interacts with the Vault for advanced balance
sources (non-ERC20 tokens), which are not required for standard usage.
- Vault-dependent logic is guarded and will not be triggered unless
certain preconditions (e.g. balanceOpCount > 0) are met
## Test Plan
Created an Avalanche fork on Tenderly before the Balancer Vault
deployment, and the deployment worked well:
https://dashboard.tenderly.co/cow-protocol/barn/testnet/14090eef-bc20-43fc-994d-2353743159cb
## Potential risks
SAFE core contract addresses on ZK rollups differ from those on
optimistic ones. Not sure if there is a chance that the Balancer Vault
will be deployed later with a different address.1 parent 08f8627 commit 39d7f4d
1 file changed
+8
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
49 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
50 | 57 | | |
51 | | - | |
52 | | - | |
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
| |||
0 commit comments