fix: remove `tsx` and restore `ts-node` by cowdan · Pull Request #992 · cowprotocol/token-lists

cowdan · 2025-06-26T15:21:58Z

Description

Remove tsx runner and restore the previous way to run scripts, to fix the issue

error tsx@4.20.3: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.2"

Summary by CodeRabbit

Chores
- Updated the script execution method to use Node.js with specific flags instead of the previous tool.
- Removed an unused development dependency.
- Added a new runtime dependency to support the updated script execution.

coderabbitai · 2025-06-26T15:24:47Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The npm script for running the project was modified to use the Node.js runtime directly with specific experimental flags and the ts-node/esm loader, replacing the previous use of the tsx package. The tsx package was also removed from the development dependencies, and ts-node was added to the dependencies.

Changes

File(s)	Change Summary
package.json	Updated `run-script` to use `node --loader ts-node/esm --experimental-json-modules --experimental-specifier-resolution=node`; removed `tsx` from `devDependencies` and added `ts-node` to `dependencies`.

Poem

A hop, a skip, the scripts now run,
With Node and flags, the work is done.
Farewell to tsx, you served us well,
Now ts-node leads, as stories tell.
The garden’s code grows strong and bright,
With every change, we leap to new height! 🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f61210 and 4678037.

📒 Files selected for processing (1)

package.json (2 hunks)

🔇 Additional comments (1)

package.json (1)

38-38: ```shell
#!/bin/bash

Search for any residual 'tsx' invocations across the repository

rg -n 'tsx'
</details>

</blockquote></details>

</details>

package.json

socket-security · 2025-06-26T16:29:57Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@tsconfig/node10@1.0.11
	@tsconfig/node12@1.0.11
	@tsconfig/node14@1.0.3
	@tsconfig/node16@1.0.4
	v8-compile-cache-lib@3.0.1
	@cspotcode/source-map-support@0.8.1
	create-require@1.1.1
	yn@3.1.1
	@jridgewell/resolve-uri@3.1.2
	@jridgewell/trace-mapping@0.3.9
	@jridgewell/sourcemap-codec@1.5.0
	ts-node@10.9.2
	make-error@1.3.6
	acorn-walk@8.3.4
	arg@4.1.3
	diff@4.0.2
	acorn@8.11.2 ⏵ 8.15.0

View full report

alfetopito

The build failed.

Can you update the package lock locally and try again?

fix: remove tsx and restore ts-node

4678037

coderabbitai bot reviewed Jun 26, 2025

View reviewed changes

package.json Show resolved Hide resolved

fix: restore ts-node

88006cf

alfetopito reviewed Jun 26, 2025

View reviewed changes

chore: update yarn.lock

58792ba

cowdan requested review from alfetopito and shoom3301 June 27, 2025 09:18

alfetopito approved these changes Jun 30, 2025

View reviewed changes

alfetopito merged commit b629046 into main Jun 30, 2025
7 checks passed

alfetopito deleted the fix/remove-tsx branch June 30, 2025 13:54

github-actions bot locked and limited conversation to collaborators Jun 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove `tsx` and restore `ts-node`#992

fix: remove `tsx` and restore `ts-node`#992
alfetopito merged 3 commits intomainfrom
fix/remove-tsx

cowdan commented Jun 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 26, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Search for any residual 'tsx' invocations across the repository

Uh oh!

Uh oh!

socket-security bot commented Jun 26, 2025 •

edited

Loading

Uh oh!

alfetopito left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cowdan commented Jun 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Search for any residual 'tsx' invocations across the repository

Uh oh!

Uh oh!

socket-security bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alfetopito left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cowdan commented Jun 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented Jun 26, 2025 •

edited

Loading