Skip to content

Commit a98db80

Browse files
committed
Fix #79 by removing confusing comment(s)
1 parent 0b51cbd commit a98db80

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

src/main/java/com/fasterxml/uuid/NoArgGenerator.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,10 @@
1010
*/
1111
public abstract class NoArgGenerator extends UUIDGenerator
1212
{
13+
/**
14+
* Method for generating a {@link UUID}.
15+
*
16+
* @return Newly generated {@link UUID}
17+
*/
1318
public abstract UUID generate();
1419
}

src/main/java/com/fasterxml/uuid/UUIDTimer.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,9 @@ public int getClockSequence() {
233233
/**
234234
* Method that constructs unique timestamp suitable for use for
235235
* constructing UUIDs. Default implementation is fully synchronized;
236-
* sub-classes may choose to implemented alternate strategies
236+
* sub-classes may choose to implement alternate strategies but
237+
* due to existing usage and expectations should also be synchronized
238+
* unless usage is specifically known not to require it.
237239
*
238240
* @return 64-bit timestamp to use for constructing UUID
239241
*/

src/main/java/com/fasterxml/uuid/impl/TimeBasedGenerator.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,7 @@ public TimeBasedGenerator(EthernetAddress ethAddr, UUIDTimer timer)
8585
/* UUID generation
8686
/**********************************************************************
8787
*/
88-
89-
/* As timer is not synchronized (nor _uuidBytes), need to sync; but most
90-
* importantly, synchronize on timer which may also be shared between
91-
* multiple instances
92-
*/
88+
9389
@Override
9490
public UUID generate()
9591
{

src/main/java/com/fasterxml/uuid/impl/TimeBasedReorderedGenerator.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,7 @@ public TimeBasedReorderedGenerator(EthernetAddress ethAddr, UUIDTimer timer)
9090
/* UUID generation
9191
/**********************************************************************
9292
*/
93-
94-
/* As timer is not synchronized (nor _uuidBytes), need to sync; but most
95-
* importantly, synchronize on timer which may also be shared between
96-
* multiple instances
97-
*/
93+
9894
@Override
9995
public UUID generate()
10096
{

0 commit comments

Comments
 (0)