feat: [Coda] migrate fmt.Errorf to errorx error codes in evaluation module

(LogID: 202509241110360100911101341211FA3)

Co-Authored-By: Coda <[email protected]>

Author: tpfz

backend/modules/evaluation/application/evaluator_app.go

@@ -1029,7 +1029,7 @@ func (e *EvaluatorHandlerImpl) transformURIsToURLs(ctx context.Context, inputFie
 
 	urlMap, err := e.fileProvider.MGetFileURL(ctx, uris)
 	if err != nil {
-		return fmt.Errorf("failed to get file URLs: %w", err)
+		return errorx.NewByCode(errno.FileURLRetrieveFailedCode, errorx.WithExtraMsg(err.Error()))
 	}
 
 	// 回填URL到原始数据
@@ -1193,7 +1193,7 @@ func (e *EvaluatorHandlerImpl) batchDebugWithConcurrency(ctx context.Context, ev
 	// 创建并发池，并发度为10
 	pool, err := goroutine.NewPool(10)
 	if err != nil {
-		return nil, fmt.Errorf("failed to create goroutine pool: %w", err)
+		return nil, errorx.NewByCode(errno.GoroutinePoolCreateFailedCode, errorx.WithExtraMsg(err.Error()))
 	}
 
 	// 初始化结果数组
@@ -1244,10 +1244,10 @@ func (e *EvaluatorHandlerImpl) batchDebugWithConcurrency(ctx context.Context, ev
 	// 执行所有任务，使用ExecAll确保单个失败不影响其他任务
 	err = pool.ExecAll(ctx)
 	if err != nil {
-		return nil, fmt.Errorf("failed to execute batch debug tasks: %w", err)
+		return nil, errorx.NewByCode(errno.BatchTaskExecutionFailedCode, errorx.WithExtraMsg(err.Error()))
 	}
 
 	return &evaluatorservice.BatchDebugEvaluatorResponse{
 		EvaluatorOutputData: results,
 	}, nil
-}
+}

backend/modules/evaluation/domain/service/evaluator_source_code_impl.go

@@ -1,6 +1,5 @@
 // Copyright (c) 2025 coze-dev Authors
-// SPDX-License-Identifier: Apache-2.0
-
+// SPDX-License-Identifier: Apache-2.0	return errorx.NewByCode(errno.RequiredFunctionNotFoundCode, errorx.WithExtraMsg("代码中必须定义 exec_evaluation 或 execEvaluation 函数。JavaScript 函数定义格式：function execEvaluation(turn, userInput, modelOutput, modelConfig, evaluatorConfig) { ... } 或 function exec_evaluation(turn, user_input, model_output, model_config, evaluator_config) { ... }"))
 package service
 
 import (
@@ -289,26 +288,26 @@ func (c *EvaluatorSourceCodeServiceImpl) prepareAndExecuteCode(ctx context.Conte
 	// 1. 获取代码构建器
 	codeBuilder, err := c.codeBuilderFactory.CreateBuilder(codeVersion.LanguageType)
 	if err != nil {
-		return "", nil, fmt.Errorf("failed to get code builder for language %s: %v", codeVersion.LanguageType, err)
+		return "", nil, errorx.NewByCode(errno.CodeBuilderGetFailedCode, errorx.WithExtraMsg(fmt.Sprintf("language: %s, error: %v", codeVersion.LanguageType, err)))
 	}
 
 	// 2. 构建代码
 	code, err := codeBuilder.BuildCode(input, codeVersion)
 	if err != nil {
-		return "", nil, fmt.Errorf("failed to build code: %v", err)
+		return "", nil, errorx.NewByCode(errno.CodeBuildFailedCode, errorx.WithExtraMsg(err.Error()))
 	}
 
 	// 3. 获取Runtime
 	runtime, err := c.runtimeManager.GetRuntime(codeVersion.LanguageType)
 	if err != nil {
-		return code, nil, fmt.Errorf("failed to get runtime for language %s: %v", codeVersion.LanguageType, err)
+		return code, nil, errorx.NewByCode(errno.RuntimeGetFailedCode, errorx.WithExtraMsg(fmt.Sprintf("language: %s, error: %v", codeVersion.LanguageType, err)))
 	}
 
 	// 4. 执行代码
 	ext := c.buildExtParams(evaluator)
 	result, err := runtime.RunCode(ctx, code, string(codeVersion.LanguageType), c.getTimeoutMS(), ext)
 	if err != nil {
-		return code, nil, fmt.Errorf("code execution failed: %v", err)
+		return code, nil, errorx.NewByCode(errno.CodeExecutionFailedCode, errorx.WithExtraMsg(err.Error()))
 	}
 
 	return code, result, nil
@@ -486,7 +485,7 @@ func (c *EvaluatorSourceCodeServiceImpl) PreHandle(ctx context.Context, evaluato
 func (c *EvaluatorSourceCodeServiceImpl) Validate(ctx context.Context, evaluator *entity.Evaluator) error {
 	// 基础验证
 	if evaluator.EvaluatorType != entity.EvaluatorTypeCode || evaluator.CodeEvaluatorVersion == nil {
-		return fmt.Errorf("invalid evaluator type or code evaluator version is nil")
+		return errorx.NewByCode(errno.InvalidEvaluatorConfigurationCode, errorx.WithExtraMsg("invalid evaluator type or code evaluator version is nil"))
 	}
 
 	codeVersion := evaluator.CodeEvaluatorVersion
@@ -513,7 +512,7 @@ func (c *EvaluatorSourceCodeServiceImpl) Validate(ctx context.Context, evaluator
 	case entity.LanguageTypeJS:
 		return c.validateJavaScriptCode(ctx, evaluator, codeVersion)
 	default:
-		return fmt.Errorf("unsupported language type: %s", codeVersion.LanguageType)
+		return errorx.NewByCode(errno.UnsupportedLanguageTypeCode, errorx.WithExtraMsg(fmt.Sprintf("language type: %s", codeVersion.LanguageType)))
 	}
 }
 
@@ -607,13 +606,13 @@ func (c *EvaluatorSourceCodeServiceImpl) parseSyntaxValidationStdoutJSON(stdout
 	// 清理stdout，移除换行符和额外的空白字符
 	stdout = strings.TrimSpace(stdout)
 	if stdout == "" {
-		return nil, fmt.Errorf("empty stdout")
+		return nil, errorx.NewByCode(errno.ExecutionResultEmptyCode, errorx.WithExtraMsg("stdout is empty"))
 	}
 
 	// 尝试解析JSON
 	var result map[string]interface{}
 	if err := json.Unmarshal([]byte(stdout), &result); err != nil {
-		return nil, fmt.Errorf("failed to parse stdout JSON: %v", err)
+		return nil, errorx.NewByCode(errno.ExecutionResultParseFailedCode, errorx.WithExtraMsg(fmt.Sprintf("failed to parse stdout JSON: %v", err)))
 	}
 
 	// 解码错误信息中的Unicode转义字符
@@ -631,13 +630,13 @@ func (c *EvaluatorSourceCodeServiceImpl) parseSyntaxValidationRetValJSON(retVal
 	// 清理retVal，移除换行符和额外的空白字符
 	retVal = strings.TrimSpace(retVal)
 	if retVal == "" {
-		return nil, fmt.Errorf("empty ret_val")
+		return nil, errorx.NewByCode(errno.ExecutionResultEmptyCode, errorx.WithExtraMsg("ret_val is empty"))
 	}
 
 	// 尝试解析JSON
 	var result map[string]interface{}
 	if err := json.Unmarshal([]byte(retVal), &result); err != nil {
-		return nil, fmt.Errorf("failed to parse ret_val JSON: %v", err)
+		return nil, errorx.NewByCode(errno.ExecutionResultParseFailedCode, errorx.WithExtraMsg(fmt.Sprintf("failed to parse ret_val JSON: %v", err)))
 	}
 
 	// 解码错误信息中的Unicode转义字符
@@ -653,7 +652,7 @@ func (c *EvaluatorSourceCodeServiceImpl) parseSyntaxValidationRetValJSON(retVal
 // processExecutionResult 处理执行结果，仅保留decodeUnicodeEscapes的处理
 func (c *EvaluatorSourceCodeServiceImpl) processExecutionResult(result *entity.ExecutionResult) (*entity.ExecutionResult, error) {
 	if result == nil {
-		return nil, fmt.Errorf("execution result is nil")
+		return nil, errorx.NewByCode(errno.ExecutionResultNilCode, errorx.WithExtraMsg("execution result is nil"))
 	}
 
 	// 处理输出信息
@@ -812,11 +811,11 @@ func (c *EvaluatorSourceCodeServiceImpl) parseEvaluationRetVal(retVal string) (s
 		// 如果 JSON 解析失败，尝试 Python 字典格式
 		jsonStr, convertErr := c.convertPythonDictToJSON(cleanedRetVal)
 		if convertErr != nil {
-			return nil, "", fmt.Errorf("failed to parse RetVal: %v, jsonStr: %s", err, jsonStr)
+			return nil, "", errorx.NewByCode(errno.ExecutionResultParseFailedCode, errorx.WithExtraMsg(fmt.Sprintf("failed to parse RetVal: %v, jsonStr: %s", err, jsonStr)))
 		}
 
 		if err := json.Unmarshal([]byte(jsonStr), &result); err != nil {
-			return nil, "", fmt.Errorf("failed to parse converted RetVal JSON: %v, jsonStr: %s", err, jsonStr)
+			return nil, "", errorx.NewByCode(errno.ExecutionResultParseFailedCode, errorx.WithExtraMsg(fmt.Sprintf("failed to parse converted RetVal JSON: %v, jsonStr: %s", err, jsonStr)))
 		}
 	}
 
@@ -873,7 +872,7 @@ func (c *EvaluatorSourceCodeServiceImpl) parseEvaluationExecutionResult(result *
 func (c *EvaluatorSourceCodeServiceImpl) validatePythonCode(ctx context.Context, evaluator *entity.Evaluator, codeVersion *entity.CodeEvaluatorVersion) error {
 	// 基础检查
 	if codeVersion.CodeContent == "" {
-		return fmt.Errorf("python code is empty")
+		return errorx.NewByCode(errno.EmptyCodeContentCode, errorx.WithExtraMsg("python code is empty"))
 	}
 
 	// 额外的Python特定安全检查
@@ -884,7 +883,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validatePythonCode(ctx context.Context,
 	// 获取Runtime
 	runtime, err := c.runtimeManager.GetRuntime(entity.LanguageTypePython)
 	if err != nil {
-		return fmt.Errorf("failed to get python runtime for validation: %v", err)
+		return errorx.NewByCode(errno.RuntimeGetFailedCode, errorx.WithExtraMsg(fmt.Sprintf("failed to get python runtime for validation: %v", err)))
 	}
 
 	// 构建Python语法检查代码，参考pyodide客户端的AST验证方式
@@ -894,18 +893,18 @@ func (c *EvaluatorSourceCodeServiceImpl) validatePythonCode(ctx context.Context,
 	ext := c.buildExtParams(evaluator)
 	result, err := runtime.RunCode(ctx, syntaxCheckCode, "python", 10000, ext) // 10秒超时用于语法验证
 	if err != nil {
-		return fmt.Errorf("python syntax validation failed: %w", err)
+		return errorx.NewByCode(errno.SyntaxValidationFailedCode, errorx.WithExtraMsg(fmt.Sprintf("python syntax validation failed: %v", err)))
 	}
 
 	// 处理执行结果并解析stdout中的JSON
 	valid, errorMsg, err := c.processSyntaxValidationExecutionResult(result)
 	if err != nil {
-		return fmt.Errorf("failed to process syntax validation result: %w", err)
+		return errorx.NewByCode(errno.SyntaxValidationResultParseFailedCode, errorx.WithExtraMsg(err.Error()))
 	}
 	// 直接使用 processSyntaxValidationExecutionResult 的验证结果
 	// 该方法已经完成了所有的 valid 字段解析和验证
 	if !valid {
-		return fmt.Errorf("python syntax error: %s", errorMsg)
+		return errorx.NewByCode(errno.SyntaxValidationFailedCode, errorx.WithExtraMsg(fmt.Sprintf("python syntax error: %s", errorMsg)))
 	}
 
 	return nil
@@ -915,7 +914,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validatePythonCode(ctx context.Context,
 func (c *EvaluatorSourceCodeServiceImpl) validateJavaScriptCode(ctx context.Context, evaluator *entity.Evaluator, codeVersion *entity.CodeEvaluatorVersion) error {
 	// 基础检查
 	if codeVersion.CodeContent == "" {
-		return fmt.Errorf("javascript code is empty")
+		return errorx.NewByCode(errno.EmptyCodeContentCode, errorx.WithExtraMsg("javascript code is empty"))
 	}
 
 	// JavaScript特定安全检查
@@ -926,7 +925,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validateJavaScriptCode(ctx context.Cont
 	// 获取Runtime
 	runtime, err := c.runtimeManager.GetRuntime(entity.LanguageTypeJS)
 	if err != nil {
-		return fmt.Errorf("failed to get javascript runtime for validation: %v", err)
+		return errorx.NewByCode(errno.RuntimeGetFailedCode, errorx.WithExtraMsg(fmt.Sprintf("failed to get javascript runtime for validation: %v", err)))
 	}
 
 	// 构建JavaScript语法检查代码 (使用Builder模式)
@@ -936,19 +935,19 @@ func (c *EvaluatorSourceCodeServiceImpl) validateJavaScriptCode(ctx context.Cont
 	ext := c.buildExtParams(evaluator)
 	result, err := runtime.RunCode(ctx, syntaxCheckCode, "js", 10000, ext) // 与Python保持一致的10秒超时
 	if err != nil {
-		return fmt.Errorf("javascript syntax validation failed: %w", err)
+		return errorx.NewByCode(errno.SyntaxValidationFailedCode, errorx.WithExtraMsg(fmt.Sprintf("javascript syntax validation failed: %v", err)))
 	}
 
 	// 使用统一的结果处理方法 (与Python保持一致)
 	valid, errorMsg, err := c.processSyntaxValidationExecutionResult(result)
 	if err != nil {
-		return fmt.Errorf("failed to process syntax validation result: %w", err)
+		return errorx.NewByCode(errno.SyntaxValidationResultParseFailedCode, errorx.WithExtraMsg(err.Error()))
 	}
 
 	// 直接使用 processSyntaxValidationExecutionResult 的验证结果
 	// 该方法已经完成了所有的 valid 字段解析和验证
 	if !valid {
-		return fmt.Errorf("javascript syntax error: %s", errorMsg)
+		return errorx.NewByCode(errno.SyntaxValidationFailedCode, errorx.WithExtraMsg(fmt.Sprintf("javascript syntax error: %s", errorMsg)))
 	}
 
 	return nil
@@ -1055,7 +1054,7 @@ try {
 // validateCodeSecurity 验证代码安全性
 func (c *EvaluatorSourceCodeServiceImpl) validateCodeSecurity(codeVersion *entity.CodeEvaluatorVersion) error {
 	if strings.TrimSpace(codeVersion.CodeContent) == "" {
-		return fmt.Errorf("代码不能为空")
+		return errorx.NewByCode(errno.EmptyCodeContentCode, errorx.WithExtraMsg("代码不能为空"))
 	}
 
 	// 转换语言类型
@@ -1103,7 +1102,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validatePythonSpecificSecurity(code str
 
 	for _, pattern := range dangerousPatterns {
 		if matched, _ := regexp.MatchString(pattern, code); matched {
-			return fmt.Errorf("detected dangerous Python pattern")
+			return errorx.NewByCode(errno.DangerousImportDetectedCode, errorx.WithExtraMsg("detected dangerous Python pattern"))
 		}
 	}
 
@@ -1122,7 +1121,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validateJavaScriptSpecificSecurity(code
 
 	for _, pattern := range dangerousPatterns {
 		if matched, _ := regexp.MatchString(pattern, code); matched {
-			return fmt.Errorf("detected dangerous JavaScript pattern")
+			return errorx.NewByCode(errno.DangerousImportDetectedCode, errorx.WithExtraMsg("detected dangerous JavaScript pattern"))
 		}
 	}
 
@@ -1147,7 +1146,7 @@ func (c *EvaluatorSourceCodeServiceImpl) checkDangerousFunctions(code, language
 		// 创建正则表达式匹配函数调用
 		pattern := regexp.MustCompile(`\b` + regexp.QuoteMeta(fn) + `\s*\(`)
 		if pattern.MatchString(code) {
-			return fmt.Errorf("安全违规: 检测到危险函数调用: %s", fn)
+			return errorx.NewByCode(errno.DangerousFunctionDetectedCode, errorx.WithExtraMsg(fmt.Sprintf("detected function: %s", fn)))
 		}
 	}
 
@@ -1187,9 +1186,9 @@ func (c *EvaluatorSourceCodeServiceImpl) checkDangerousImports(code, language st
 
 		for _, pattern := range patterns {
 			regex := regexp.MustCompile(pattern)
-			if regex.MatchString(code) {
-				return fmt.Errorf("安全违规: 检测到危险模块导入: %s", imp)
-			}
+		if regex.MatchString(code) {
+			return errorx.NewByCode(errno.DangerousImportDetectedCode, errorx.WithExtraMsg(fmt.Sprintf("detected import: %s", imp)))
+		}
 		}
 	}
 
@@ -1333,7 +1332,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validateExecEvaluationFunction(codeVers
 	case entity.LanguageTypeJS:
 		return c.validateJavaScriptExecEvaluationFunction(codeVersion.CodeContent)
 	default:
-		return fmt.Errorf("unsupported language type for exec_evaluation validation: %s", codeVersion.LanguageType)
+		return errorx.NewByCode(errno.UnsupportedLanguageTypeCode, errorx.WithExtraMsg(fmt.Sprintf("unsupported language type for exec_evaluation validation: %s", codeVersion.LanguageType)))
 	}
 }
 
@@ -1344,7 +1343,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validatePythonExecEvaluationFunction(co
 	pattern := `(?m)^\s*def\s+exec_evaluation\s*\(`
 	regex := regexp.MustCompile(pattern)
 	if !regex.MatchString(code) {
-		return fmt.Errorf("代码中必须定义 exec_evaluation 函数。Python 函数定义格式：def exec_evaluation(turn_data):")
+		return errorx.NewByCode(errno.RequiredFunctionNotFoundCode, errorx.WithExtraMsg("代码中必须定义 exec_evaluation 函数。Python 函数定义格式：def exec_evaluation(turn_data):"))
 	}
 	return nil
 }
@@ -1376,7 +1375,7 @@ func (c *EvaluatorSourceCodeServiceImpl) validateJavaScriptExecEvaluationFunctio
 		}
 	}
 
-	return fmt.Errorf("代码中必须定义 exec_evaluation 或 execEvaluation 函数。JavaScript 函数定义格式：function exec_evaluation(turn_data) { ... }")
+	return errorx.NewByCode(errno.RequiredFunctionNotFoundCode, errorx.WithExtraMsg("代码中必须定义 exec_evaluation 或 execEvaluation 函数。JavaScript 函数定义格式：function exec_evaluation(turn_data) { ... }"))
 }
 
 // ReportCodeRootSpanRequest Code评估器专用的上报请求结构