Skip to content

Commit e75a3b2

Browse files
authored
[feat][backend] loop anno api (#281)
* feat(backend): add idl tag * feat(backend): change auth point * feat(backend): fix ut
1 parent c7d2d24 commit e75a3b2

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

backend/modules/observability/application/openapi.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ func (o *OpenAPIApplication) CreateAnnotation(ctx context.Context, req *openapi.
446446

447447
func (o *OpenAPIApplication) DeleteAnnotation(ctx context.Context, req *openapi.DeleteAnnotationRequest) (*openapi.DeleteAnnotationResponse, error) {
448448
if err := o.auth.CheckWorkspacePermission(ctx,
449-
rpc.AuthActionAnnotationCreate,
449+
rpc.AuthActionAnnotationDelete,
450450
strconv.FormatInt(req.WorkspaceID, 10), true); err != nil {
451451
return nil, err
452452
}

backend/modules/observability/application/openapi_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,7 @@ func TestOpenAPIApplication_DeleteAnnotation(t *testing.T) {
659659
name: "delete annotation successfully",
660660
fieldsGetter: func(ctrl *gomock.Controller) fields {
661661
authMock := rpcmocks.NewMockIAuthProvider(ctrl)
662-
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationCreate, "1", true).Return(nil)
662+
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationDelete, "1", true).Return(nil)
663663
traceServiceMock := servicemocks.NewMockITraceService(ctrl)
664664
traceServiceMock.EXPECT().DeleteAnnotation(gomock.Any(), gomock.Any()).Return(nil)
665665
benefitMock := benefitmocks.NewMockIBenefitService(ctrl)
@@ -711,7 +711,7 @@ func TestOpenAPIApplication_DeleteAnnotation(t *testing.T) {
711711
name: "delete annotation with permission denied",
712712
fieldsGetter: func(ctrl *gomock.Controller) fields {
713713
authMock := rpcmocks.NewMockIAuthProvider(ctrl)
714-
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationCreate, "1", true).
714+
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationDelete, "1", true).
715715
Return(assert.AnError)
716716
traceServiceMock := servicemocks.NewMockITraceService(ctrl)
717717
benefitMock := benefitmocks.NewMockIBenefitService(ctrl)
@@ -746,7 +746,7 @@ func TestOpenAPIApplication_DeleteAnnotation(t *testing.T) {
746746
name: "delete annotation with benefit check failed",
747747
fieldsGetter: func(ctrl *gomock.Controller) fields {
748748
authMock := rpcmocks.NewMockIAuthProvider(ctrl)
749-
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationCreate, "1", true).Return(nil)
749+
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationDelete, "1", true).Return(nil)
750750
traceServiceMock := servicemocks.NewMockITraceService(ctrl)
751751
benefitMock := benefitmocks.NewMockIBenefitService(ctrl)
752752
benefitMock.EXPECT().CheckTraceBenefit(gomock.Any(), gomock.Any()).
@@ -782,7 +782,7 @@ func TestOpenAPIApplication_DeleteAnnotation(t *testing.T) {
782782
name: "delete annotation with trace service failed",
783783
fieldsGetter: func(ctrl *gomock.Controller) fields {
784784
authMock := rpcmocks.NewMockIAuthProvider(ctrl)
785-
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationCreate, "1", true).Return(nil)
785+
authMock.EXPECT().CheckWorkspacePermission(gomock.Any(), rpc.AuthActionAnnotationDelete, "1", true).Return(nil)
786786
traceServiceMock := servicemocks.NewMockITraceService(ctrl)
787787
traceServiceMock.EXPECT().DeleteAnnotation(gomock.Any(), gomock.Any()).Return(assert.AnError)
788788
benefitMock := benefitmocks.NewMockIBenefitService(ctrl)

backend/modules/observability/domain/component/rpc/auth.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const (
1313
AuthActionTraceViewList = "listLoopTraceView"
1414
AuthActionTraceViewEdit = "edit"
1515
AuthActionAnnotationCreate = "createLoopTraceAnnotation"
16+
AuthActionAnnotationDelete = "deleteLoopTraceAnnotation"
1617
AuthActionTraceExport = "exportLoopTrace"
1718
AuthActionTracePreviewExport = "previewExportLoopTrace"
1819
AuthActionTraceTaskCreate = "createLoopTask"

idl/thrift/coze/loop/observability/coze.loop.observability.openapi.thrift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,6 @@ service OpenAPIService {
174174
SearchTraceTreeOApiResponse SearchTraceTreeOApi(1: SearchTraceTreeOApiRequest req) (api.post = '/v1/loop/traces/search_tree')
175175
ListSpansOApiResponse ListSpansOApi(1: ListSpansOApiRequest req) (api.post = '/v1/loop/spans/search', api.tag="openapi")
176176
ListTracesOApiResponse ListTracesOApi(1: ListTracesOApiRequest req) (api.post = '/v1/loop/traces/list')
177-
CreateAnnotationResponse CreateAnnotation(1: CreateAnnotationRequest req) (api.post = '/v1/loop/annotations')
178-
DeleteAnnotationResponse DeleteAnnotation(1: DeleteAnnotationRequest req) (api.delete = '/v1/loop/annotations')
177+
CreateAnnotationResponse CreateAnnotation(1: CreateAnnotationRequest req) (api.post = '/v1/loop/annotations', api.tag="openapi")
178+
DeleteAnnotationResponse DeleteAnnotation(1: DeleteAnnotationRequest req) (api.delete = '/v1/loop/annotations', api.tag="openapi")
179179
}

0 commit comments

Comments
 (0)