[fix][backend]Fix mq compression bug. #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I7a1e90ba1c4379a23ca8b6034cced1b3330ea5e3
CozeLoop
reviewed
Dec 2, 2025
Collaborator
CozeLoop
left a comment
CozeLoop
left a comment
There was a problem hiding this comment.
Reviewed backend/infra/mq/rocketmq/factory.go. The change removes a hard error on Compression and resolves producer initialization failures. No blocking issues found. Left a suggestion to clarify that RocketMQ currently ignores ProducerConfig.Compression and compression should be handled upstream if required.
CozeLoop
reviewed
Dec 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 69.46% 69.46%
=======================================
Files 588 588
Lines 55149 55147 -2
=======================================
Hits 38310 38310
+ Misses 13940 13938 -2
Partials 2899 2899
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
kidkidkid
approved these changes
Dec 2, 2025
lsy357
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I7a1e90ba1c4379a23ca8b6034cced1b3330ea5e3
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes