Skip to content

Commit f19761f

Browse files
authored
fix(agent): disallow update if prompt is empty (#1802)
1 parent 14ce6bc commit f19761f

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

backend/domain/agent/singleagent/internal/dal/single_agent_draft.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,18 @@ func (sa *SingleAgentDraftDAO) MGet(ctx context.Context, agentIDs []int64) ([]*e
102102
return dos, nil
103103
}
104104

105+
func (sa *SingleAgentDraftDAO) Save(ctx context.Context, agentInfo *entity.SingleAgent) (err error) {
106+
po := sa.singleAgentDraftDo2Po(agentInfo)
107+
singleAgentDAOModel := sa.dbQuery.SingleAgentDraft
108+
109+
err = singleAgentDAOModel.WithContext(ctx).Where(singleAgentDAOModel.AgentID.Eq(agentInfo.AgentID)).Save(po)
110+
if err != nil {
111+
return errorx.WrapByCode(err, errno.ErrAgentUpdateCode)
112+
}
113+
114+
return nil
115+
}
116+
105117
func (sa *SingleAgentDraftDAO) Update(ctx context.Context, agentInfo *entity.SingleAgent) (err error) {
106118
po := sa.singleAgentDraftDo2Po(agentInfo)
107119
singleAgentDAOModel := sa.dbQuery.SingleAgentDraft

backend/domain/agent/singleagent/repository/repository.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ type SingleAgentDraftRepo interface {
4646
MGet(ctx context.Context, agentIDs []int64) ([]*entity.SingleAgent, error)
4747
Delete(ctx context.Context, spaceID, agentID int64) (err error)
4848
Update(ctx context.Context, agentInfo *entity.SingleAgent) (err error)
49+
Save(ctx context.Context, agentInfo *entity.SingleAgent) (err error)
4950

5051
GetDisplayInfo(ctx context.Context, userID, agentID int64) (*entity.AgentDraftDisplayInfo, error)
5152
UpdateDisplayInfo(ctx context.Context, userID int64, e *entity.AgentDraftDisplayInfo) error

backend/domain/agent/singleagent/service/single_agent_impl.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func (s *singleAgentImpl) UpdateSingleAgentDraft(ctx context.Context, agentInfo
153153
}
154154
}
155155

156-
return s.AgentDraftRepo.Update(ctx, agentInfo)
156+
return s.AgentDraftRepo.Save(ctx, agentInfo)
157157
}
158158

159159
func (s *singleAgentImpl) CreateSingleAgentDraftWithID(ctx context.Context, creatorID, agentID int64, draft *entity.SingleAgent) (int64, error) {

backend/domain/knowledge/service/retrieve_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ import (
2424
"testing"
2525

2626
"github.com/cloudwego/eino/schema"
27+
"github.com/stretchr/testify/assert"
28+
"go.uber.org/mock/gomock"
29+
"gorm.io/driver/mysql"
30+
"gorm.io/gorm"
31+
2732
"github.com/coze-dev/coze-studio/backend/domain/knowledge/entity"
2833
"github.com/coze-dev/coze-studio/backend/domain/knowledge/internal/dal/model"
2934
"github.com/coze-dev/coze-studio/backend/domain/knowledge/repository"
@@ -35,10 +40,6 @@ import (
3540
mock_db "github.com/coze-dev/coze-studio/backend/internal/mock/infra/contract/rdb"
3641
"github.com/coze-dev/coze-studio/backend/pkg/lang/ptr"
3742
"github.com/coze-dev/coze-studio/backend/pkg/lang/sets"
38-
"github.com/stretchr/testify/assert"
39-
"go.uber.org/mock/gomock"
40-
"gorm.io/driver/mysql"
41-
"gorm.io/gorm"
4243
)
4344

4445
func TestAddSliceIdColumn(t *testing.T) {

0 commit comments

Comments
 (0)