Skip to content

Commit f6cf6a2

Browse files
committed
SLO: combine MIR and security better
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
1 parent 274b2fc commit f6cf6a2

File tree

1 file changed

+33
-12
lines changed

1 file changed

+33
-12
lines changed

README.md

Lines changed: 33 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,19 +1211,30 @@ we can do two things:
12111211
1. List all distinct binary packages that should be promoted. Often a source package will have binary packages that aren't actually needed in main. Things like `-doc`, `-autopilot` or `-dbgsym`. These can stay in universe, and it is a kindness to list only the packages we need for the archive team member that does the promotion.
12121212
1. Recommend the owning team to add their corresponding team bug subscriber during the MIR process.
12131213

1214-
## MIR Review - service level objective
1214+
# Constraints and Service Level Objectives
12151215

1216-
MIR reviews take time, scaling up with the complexity of the case. Sadly it is usually
1217-
the very complex, very special cases that come in very late then are not happy with the
1218-
velocity of review.
1216+
Reviews take time, scaling up with the complexity of the case. Sadly it is usually
1217+
the very complex, very special cases that tend to come in very late then be unhappy
1218+
with the velocity of the review.
1219+
For transparency and to manage expectations we hereby defined the service level
1220+
objectives we defined for this process.
1221+
1222+
Furthermore to be clear - you can help!
1223+
You know in advance what we will check.
1224+
History shows that a well prepared case will pass through more quickly in each
1225+
phase. By truly caring about tests, quality, warnings and the many other things
1226+
we check for you can help efficiency. So please take all the statements we ask
1227+
for serious and try to fulfill them.
1228+
1229+
## MIR Review SLO
12191230

12201231
While we aim for more when possible, our goal is to assign (in the weekly meeting)
1221-
one review per active MIR member per week, and coming back with the result until
1222-
the next meeting or earlier. That usually means we can handle ~4 cases per week,
1232+
one review per active MIR member per week, and coming back with the result before
1233+
the next meeting. On average that means we can handle ~4 cases per week,
12231234
sometimes more (if we can make the space or they are trivial) and sometimes
12241235
less (PTO times).
12251236

1226-
So far this used to be always enough and allowed <week responses for almost
1237+
So far this used to be always enough and allowed < 1 week responses for almost
12271238
all cases for several years now. Except in spikes of everyone dumping huge
12281239
changes last minute right before feature freeze. Try to avoid that phase
12291240
to help yourself getting a timely review.
@@ -1232,17 +1243,27 @@ The above of course is for the initial review, if everything is fine and no
12321243
security review needed that is it and you are done. But findings have to be
12331244
answered or fixed and if needed a security review has to be exercised. The time
12341245
for this depends on the complexity of the findings and remember that there have
1235-
been cases as bad as being rejected forcing the requester to look for
1246+
been cases as bad as being rejected, forcing the requester to look for
12361247
alternative solutions.
12371248
Please consider this in your estimations when you plan a contribution.
12381249

1239-
## Security Reviews
1250+
## Security Review SLO
12401251

1241-
Security team MIRs are laborious and require lead time. Make MIR requests as early in a release cycle as possible, ideally well before Feature Freeze. For a MIR to be considered for a release, it must be assigned to the Security team (by the MIR team) before Beta Freeze. This does not guarantee that a security review can be completed by Final Release. Ask the director of Security for exceptions.
1252+
Security team MIRs are laborious and require lead time. Make MIR requests as
1253+
early in a release cycle as possible, ideally well before Feature Freeze. For
1254+
a MIR to be considered for a release, it must be assigned to the Security
1255+
team (by the MIR team) before Beta Freeze. This does not guarantee that a
1256+
security review can be completed by Final Release. Ask the director of
1257+
Security for exceptions.
12421258

1243-
The best ways to contact the Security team about MIRs is the [MIR / Audits Jira Page](https://warthogs.atlassian.net/jira/software/c/projects/SEC/boards/594) or through the Mattermost channels `~mir-security-review-priority` or `~security-engineering`.
1259+
The best ways to contact the Security team about MIRs is the
1260+
[MIR / Audits Jira Page](https://warthogs.atlassian.net/jira/software/c/projects/SEC/boards/594)
1261+
or through the Mattermost channels `~mir-security-review-priority` or `~security-engineering`.
12441262

1245-
Teams are encouraged to set the relative importance of MIRs they own on the [MIR / Audits Jira Page](https://warthogs.atlassian.net/jira/software/c/projects/SEC/boards/594). Security attempts to work across and prioritize all teams equally. Jira priority drives the order we work on MIRs.
1263+
Teams are encouraged to set the relative importance of MIRs they own on the
1264+
[MIR / Audits Jira Page](https://warthogs.atlassian.net/jira/software/c/projects/SEC/boards/594).
1265+
Security attempts to work across and prioritize all teams equally.
1266+
Jira priority drives the order we work on MIRs.
12461267

12471268
## Bug Lists
12481269

0 commit comments

Comments
 (0)