Skip to content

Commit 116f148

Browse files
committed
consider patch perls to be development perls
There's some weird data in the database right now, but it seems like the existing backend code treats patch perls as non-stable perls.
1 parent 8067271 commit 116f148

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

lib/CPAN/Testers/Schema/ResultSet/Stats.pm

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,15 @@ C<dev> Perl versions.
4949
sub perl_maturity( $self, $maturity ) {
5050
my $devel = $maturity eq 'stable' ? 0 : $maturity eq 'dev' ? 1
5151
: Carp::croak "Unknown maturity: $maturity; Must be one of: 'stable', 'dev'";
52+
if ( !$devel ) {
53+
# Patch versions are not stable either
54+
return $self->search(
55+
{ 'perl_version.devel' => 0, 'perl_version.patch' => 0 },
56+
{ join => 'perl_version' },
57+
);
58+
}
5259
return $self->search(
53-
{ 'perl_version.devel' => $devel },
60+
{ -or => { 'perl_version.devel' => 1, 'perl_version.patch' => 1 } },
5461
{ join => 'perl_version' },
5562
);
5663
}

t/resultset/stats.t

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ subtest 'since' => sub {
132132

133133
subtest 'perl_maturity' => sub {
134134
my $perl_devel = $schema->resultset( 'PerlVersion' )->create({ version => '5.25.0' });
135+
my $perl_patch = $schema->resultset( 'PerlVersion' )->create({ version => '5.24.0 patch 123' });
135136
my $perl_stable = $schema->resultset( 'PerlVersion' )->create({ version => '5.22.2' });
136137

137138
my $devel_stat = $schema->resultset( 'Stats' )->create({
@@ -151,11 +152,29 @@ subtest 'perl_maturity' => sub {
151152
'version' => '0.02',
152153
});
153154

155+
my $patch_stat = $schema->resultset( 'Stats' )->create({
156+
'dist' => 'Sorauta-SVN-AutoCommit',
157+
'fulldate' => '201705071643',
158+
'guid' => '11111111-3343-11e7-b830-917e22bfee97',
159+
'id' => 3,
160+
'osname' => 'linux',
161+
'osvers' => '4.8.0-2-amd64',
162+
'perl' => '5.24.0 patch 123',
163+
'platform' => 'x86_64-linux',
164+
'postdate' => 201705,
165+
'state' => 'pass',
166+
'tester' => '"Andreas J. Koenig" <[email protected]>',
167+
'type' => 2,
168+
'uploadid' => 169497,
169+
'version' => '0.02',
170+
});
171+
154172
my $dev_rs = $schema->resultset( 'Stats' )->perl_maturity( 'dev' );
155173
my @dev_rows = $dev_rs->all;
156-
is scalar @dev_rows, 1, '1 test reported for a devel perl';
157-
is $dev_rows[0]->guid, '00000000-3343-11e7-b830-917e22bfee97',
158-
'correct guid for devel perl';
174+
is scalar @dev_rows, 2, '2 tests reported for a devel perl';
175+
is_deeply [ sort map { $_->guid } @dev_rows ],
176+
[ '00000000-3343-11e7-b830-917e22bfee97', '11111111-3343-11e7-b830-917e22bfee97' ],
177+
'correct guids for devel perl';
159178

160179
my $stable_rs = $schema->resultset( 'Stats' )->perl_maturity( 'stable' );
161180
my @stable_rows = $stable_rs->all;

0 commit comments

Comments
 (0)