Merge branch 'develop' of https://github.com/cpathipa/manager into develop

Author: cpathipa

.github/workflows/ci.yml

@@ -11,35 +11,35 @@ jobs:
 
     steps:
       - name: Checkout Code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Use Node.js v18.14.0
-        uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
         with:
-          node-version: "18.14"
+          run_install: false
+          version: 10
 
-      - uses: actions/cache@v3
+      - name: Use Node.js v20.17 LTS
+        uses: actions/setup-node@v4
         with:
-          path: |
-            **/node_modules
-          key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
+          node-version: "20.17"
+          cache: "pnpm"
 
       - name: Install Dependencies
-        run: yarn --frozen-lockfile
+        run: pnpm install --frozen-lockfile
 
       - name: Build @linode/validation
-        run: yarn build:validation
+        run: pnpm build:validation
 
       - name: Build @linode/api-v4
-        run: yarn build:sdk
+        run: pnpm build:sdk
 
       - name: Run Base Branch Coverage
-        run: yarn coverage:summary
+        run: pnpm coverage:summary
 
       - name: Generate Coverage Badge
         uses: jaywcjlove/coverage-badges-cli@7f0781807ef3e7aba97a145beca881d36451b7b7 # v1.1.1
         with:
-          label: '@linode/manager coverage'
+          label: "@linode/manager coverage"
           source: ./packages/manager/coverage/coverage-summary.json
           output: ./packages/manager/coverage/badges.svg
 
@@ -52,4 +52,4 @@ jobs:
           AWS_ACCESS_KEY_ID: ${{ secrets.COVERAGE_BUCKET_ACCESS }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.COVERAGE_BUCKET_SECRET }}
           AWS_REGION: us-east-1
-          SOURCE_DIR: ./packages/manager/coverage
+          SOURCE_DIR: ./packages/manager/coverage

.github/workflows/coverage.yml

@@ -13,20 +13,20 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Pages
-        uses: actions/configure-pages@v3
+        uses: actions/configure-pages@v5
 
-      - uses: oven-sh/setup-bun@v1
+      - uses: oven-sh/setup-bun@v2
         with:
           bun-version: 1.0.21
 
       - name: Build with VitePress
         run: bunx vitepress@1.0.0-rc.35 build docs
 
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@v2
+        uses: actions/upload-pages-artifact@v3
         with:
           path: docs/.vitepress/dist
 
@@ -40,4 +40,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v2
+        uses: actions/deploy-pages@v4

.github/workflows/coverage_badge.yml

@@ -7,6 +7,9 @@ env:
   USER_4: ${{ secrets.USER_4 }}
   CLIENT_ID: ${{ secrets.REACT_APP_CLIENT_ID }}
   CY_TEST_FAIL_ON_MANAGED: 1
+  CY_TEST_RESET_PREFERENCES: 1
+  CY_TEST_SPLIT_RUN: 1
+  CY_TEST_SPLIT_RUN_TOTAL: 4
 on:
   schedule:
     - cron: "0 13 * * 1-5"
@@ -18,54 +21,48 @@ on:
 
 jobs:
   run-cypress-e2e:
+    name: Cypress Tests (User ${{ matrix.user.index }})
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        user: ["USER_1", "USER_2", "USER_3", "USER_4"]
+        user:
+          - { index: 1, name: 'USER_1' }
+          - { index: 2, name: 'USER_2' }
+          - { index: 3, name: 'USER_3' }
+          - { index: 4, name: 'USER_4' }
     steps:
-      - name: install command line utilities
-        run: sudo apt-get install -y expect
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
         with:
-          node-version: "18.14"
-      - uses: actions/cache@v3
+          run_install: false
+          version: 10
+      - uses: actions/setup-node@v4
         with:
-          path: |
-            node_modules
-            */*/node_modules
-            ~/.cache/Cypress
-          key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
-      - run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
+          node-version: "20.17"
       - run: |
-          echo "CYPRESS_RECORD_KEY=${{ secrets.CYPRESS_RECORD_KEY }}" >> $GITHUB_ENV
           echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
-      - run: echo "MANAGER_OAUTH=$USER_1" >> ./packages/manager/.env
-        if: matrix['user'] == 'USER_1'
-      - run: echo "MANAGER_OAUTH=$USER_2" >> ./packages/manager/.env
-        if: matrix['user'] == 'USER_2'
-      - run: echo "MANAGER_OAUTH=$USER_3" >> ./packages/manager/.env
-        if: matrix['user'] == 'USER_3'
-      - run: echo "MANAGER_OAUTH=$USER_4" >> ./packages/manager/.env
-        if: matrix['user'] == 'USER_4'
       - run: |
           echo "REACT_APP_LAUNCH_DARKLY_ID=${{ secrets.REACT_APP_LAUNCH_DARKLY_ID }}" >> ./packages/manager/.env
           echo "REACT_APP_CLIENT_ID=$CLIENT_ID" >> ./packages/manager/.env
           echo "REACT_APP_LOGIN_ROOT=${{ secrets.REACT_APP_LOGIN_ROOT }}" >> ./packages/manager/.env
           echo "REACT_APP_API_ROOT=${{ secrets.REACT_APP_API_ROOT }}" >> ./packages/manager/.env
           echo "REACT_APP_APP_ROOT=${{ secrets.REACT_APP_APP_ROOT }}" >> ./packages/manager/.env
           echo "REACT_APP_DISABLE_NEW_RELIC=1" >> ./packages/manager/.env
-          yarn install:all
-          yarn build
-          yarn start:manager:ci &
+          echo "MANAGER_OAUTH=${{ secrets[matrix.user.name] }}" >> ./packages/manager/.env
+          echo "CY_TEST_SPLIT_RUN_INDEX=${{ matrix.user.index }}" >> ./packages/manager/.env
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm run --filter @linode/validation build
+      - run: pnpm run --filter @linode/api-v4 build
       - name: Run tests
-        uses: cypress-io/github-action@v5
+        uses: cypress-io/github-action@v6
         with:
           working-directory: packages/manager
           wait-on: "http://localhost:3000"
           wait-on-timeout: 1000
           install: false
+          build: pnpm run build
+          start: pnpm start:ci
           browser: chrome
-          record: true
-          parallel: true
+          record: false
+          parallel: false

.github/workflows/coverage_comment.yml

@@ -0,0 +1,30 @@
+name: ESLint Review
+on: [pull_request]
+jobs:
+  eslint:
+    name: ESLint Review
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      checks: write
+    strategy:
+      matrix:
+        package: [manager, api-v4, queries, shared, ui, utilities, validation]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v2
+        with:
+          run_install: false
+          version: 10
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "20.17"
+          cache: "pnpm"
+      - run: pnpm install
+      - uses: abailly-akamai/action-eslint@8ad68ba04fa60924ef7607b07deb5989f38f5ed6 # v1.0.2
+        with:
+          workdir: packages/${{ matrix.package }}
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-check
+          level: warning  # This will report both warnings and errors
+          filter_mode: added  # Only comment on new/modified lines

.github/workflows/docs.yml

@@ -12,7 +12,7 @@ jobs:
     container:
       image: returntocorp/semgrep
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
       # Perform scanning using Semgrep
       # Pass even when it identifies issues or encounters errors.