Skip to content

Commit 64378dc

Browse files
authored
upcoming: [M3-10485] - Update dual-stack labeling in LKE cluster create (linode#12754)
* Update copy for cluster create dual stack section * Update Cypress test * Added changeset: Update dual-stack labeling for LKE-E clusters in create cluster flow * Update unit test
1 parent 9f6206f commit 64378dc

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Upcoming Features
3+
---
4+
5+
Update dual-stack labeling for LKE-E clusters in create cluster flow ([#12754](https://github.com/linode/manager/pull/12754))

packages/manager/cypress/e2e/core/kubernetes/lke-enterprise-create.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ describe('LKE Cluster Creation with LKE-E', () => {
171171

172172
// Select either the IPv4 or IPv4 + IPv6 (dual-stack) IP Networking radio button
173173
cy.findByLabelText(
174-
stackType === 'ipv4' ? 'IPv4' : 'IPv4 + IPv6'
174+
stackType === 'ipv4' ? 'IPv4' : 'IPv4 + IPv6 (dual-stack)'
175175
).click();
176176

177177
// Select a plan and add nodes

packages/manager/src/features/Kubernetes/CreateCluster/ClusterNetworkingPanel.test.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ describe('ClusterNetworkingPanel', () => {
4949
});
5050

5151
// Confirm stack type section
52-
expect(getByText('IP Version')).toBeVisible();
52+
expect(getByText('IP Stack')).toBeVisible();
5353
expect(getByText('IPv4')).toBeVisible();
54-
expect(getByText('IPv4 + IPv6')).toBeVisible();
54+
expect(getByText('IPv4 + IPv6 (dual-stack)')).toBeVisible();
5555

5656
// Confirm VPC section
5757
expect(getByText('VPC')).toBeVisible();
@@ -71,7 +71,9 @@ describe('ClusterNetworkingPanel', () => {
7171

7272
// Confirm stack type default
7373
expect(getByRole('radio', { name: 'IPv4' })).toBeChecked();
74-
expect(getByRole('radio', { name: 'IPv4 + IPv6' })).not.toBeChecked();
74+
expect(
75+
getByRole('radio', { name: 'IPv4 + IPv6 (dual-stack)' })
76+
).not.toBeChecked();
7577

7678
// Confirm VPC default
7779
expect(

packages/manager/src/features/Kubernetes/CreateCluster/ClusterNetworkingPanel.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ export const ClusterNetworkingPanel = (props: Props) => {
5959
onChange={(e) => field.onChange(e.target.value)}
6060
value={field.value ?? null}
6161
>
62-
<FormLabel>IP Version</FormLabel>
62+
<FormLabel>IP Stack</FormLabel>
6363
<FormControlLabel control={<Radio />} label="IPv4" value="ipv4" />
6464
<FormControlLabel
6565
control={<Radio />}
66-
label="IPv4 + IPv6"
66+
label="IPv4 + IPv6 (dual-stack)"
6767
value="ipv4-ipv6"
6868
/>
6969
</RadioGroup>

0 commit comments

Comments
 (0)