test: [M3 8070]: apply linting to more test files (linode#11695)

* M3-8070 apply linting to more test directories

* M3-8070 another directory linted

* M3-8070 lint another dir

* M3-8070 fix problems from bad merge

* M3-8070 fix test broken by linter

* M3-8070 fix broken test

Author: dmcintyr-akamai

packages/manager/.eslintrc.cjs

@@ -23,10 +23,6 @@ module.exports = {
     'build',
     'storybook-static',
     '.storybook',
-    'e2e/core/domains',
-    'e2e/core/firewalls',
-    'e2e/core/general',
-    'e2e/core/helpAndSupport',
     'e2e/core/images',
     'e2e/core/kubernetes',
     'e2e/core/linodes',
@@ -43,7 +39,6 @@ module.exports = {
     'e2e/core/stackscripts',
     'e2e/core/volumes',
     'e2e/core/vpc',
-    'e2e/core/cloudpulse/timerange-verification.spec.ts',
     'public',
     '!.eslintrc.js',
   ],

packages/manager/cypress/e2e/core/cloudpulse/timerange-verification.spec.ts

@@ -1,17 +1,27 @@
 /**
  * @file Integration Tests for CloudPulse Custom and Preset Verification
  */
-import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
+import { DateTime } from 'luxon';
+import { widgetDetails } from 'support/constants/widgets';
+import { mockGetAccount } from 'support/intercepts/account';
 import {
   mockCreateCloudPulseJWEToken,
-  mockGetCloudPulseDashboard,
   mockCreateCloudPulseMetrics,
+  mockGetCloudPulseDashboard,
   mockGetCloudPulseDashboards,
   mockGetCloudPulseMetricDefinitions,
   mockGetCloudPulseServices,
 } from 'support/intercepts/cloudpulse';
+import { mockGetDatabases } from 'support/intercepts/databases';
+import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
+import {
+  mockGetProfile,
+  mockGetUserPreferences,
+} from 'support/intercepts/profile';
+import { mockGetRegions } from 'support/intercepts/regions';
 import { ui } from 'support/ui';
-import { widgetDetails } from 'support/constants/widgets';
+import { generateRandomMetricsData } from 'support/util/cloudpulse';
+
 import {
   accountFactory,
   cloudPulseMetricsResponseFactory,
@@ -22,20 +32,12 @@ import {
   regionFactory,
   widgetFactory,
 } from 'src/factories';
-import { mockGetAccount } from 'support/intercepts/account';
-import {
-  mockGetProfile,
-  mockGetUserPreferences,
-} from 'support/intercepts/profile';
-import { mockGetRegions } from 'support/intercepts/regions';
-import { Database, DateTimeWithPreset } from '@linode/api-v4';
-import { generateRandomMetricsData } from 'support/util/cloudpulse';
-import { mockGetDatabases } from 'support/intercepts/databases';
-import type { Flags } from 'src/featureFlags';
-import type { Interception } from 'support/cypress-exports';
 import { convertToGmt } from 'src/features/CloudPulse/Utils/CloudPulseDateTimePickerUtils';
 import { formatDate } from 'src/utilities/formatDate';
-import { DateTime } from 'luxon';
+
+import type { Database, DateTimeWithPreset } from '@linode/api-v4';
+import type { Flags } from 'src/featureFlags';
+import type { Interception } from 'support/cypress-exports';
 
 const formatter = "yyyy-MM-dd'T'HH:mm:ss'Z'";
 const currentDate = new Date();
@@ -59,7 +61,7 @@ const mockRegion = regionFactory.build({
 });
 
 const flags: Partial<Flags> = {
-  aclp: { enabled: true, beta: true },
+  aclp: { beta: true, enabled: true },
   aclpResourceTypeMap: [
     {
       dimensionKey: 'cluster_id',
@@ -70,23 +72,23 @@ const flags: Partial<Flags> = {
   ],
 };
 
-const { metrics, id, serviceType, dashboardName, engine } = widgetDetails.dbaas;
+const { dashboardName, engine, id, metrics, serviceType } = widgetDetails.dbaas;
 
 const dashboard = dashboardFactory.build({
   label: dashboardName,
   service_type: serviceType,
-  widgets: metrics.map(({ title, yLabel, name, unit }) => {
+  widgets: metrics.map(({ name, title, unit, yLabel }) => {
     return widgetFactory.build({
       label: title,
-      y_label: yLabel,
       metric: name,
       unit,
+      y_label: yLabel,
     });
   }),
 });
 
 const metricDefinitions = {
-  data: metrics.map(({ title, name, unit }) =>
+  data: metrics.map(({ name, title, unit }) =>
     dashboardMetricFactory.build({
       label: title,
       metric: name,
@@ -102,8 +104,8 @@ const metricsAPIResponsePayload = cloudPulseMetricsResponseFactory.build({
 });
 
 const databaseMock: Database = databaseFactory.build({
-  type: engine,
   region: mockRegion.label,
+  type: engine,
 });
 const mockProfile = profileFactory.build({
   timezone: 'Etc/GMT',
@@ -235,8 +237,8 @@ describe('Integration tests for verifying Cloudpulse custom and preset configura
       aclpPreference: {
         dashboardId: id,
         engine: engine.toLowerCase(),
-        resources: ['1'],
         region: mockRegion.id,
+        resources: ['1'],
       },
     }).as('fetchPreferences');
     mockGetDatabases([databaseMock]);
@@ -284,24 +286,26 @@ describe('Integration tests for verifying Cloudpulse custom and preset configura
       .click();
 
     // Selects the start hour, minute, and meridiem (AM/PM) in the time picker.
-
     cy.findByLabelText('Select hours')
-      .scrollIntoView({ easing: 'linear' })
-      .within(() => {
-        cy.get(`[aria-label="${startHour} hours"]`).click();
-      });
+      .as('selectHours')
+      .scrollIntoView({ easing: 'linear' });
+    cy.get('@selectHours').within(() => {
+      cy.get(`[aria-label="${startHour} hours"]`).click();
+    });
 
     cy.findByLabelText('Select minutes')
-      .scrollIntoView({ easing: 'linear', duration: 500 })
-      .within(() => {
-        cy.get(`[aria-label="${startMinute} minutes"]`).click();
-      });
+      .as('selectMinutes')
+      .scrollIntoView({ duration: 500, easing: 'linear' });
+    cy.get('@selectMinutes').within(() => {
+      cy.get(`[aria-label="${startMinute} minutes"]`).click();
+    });
 
     cy.findByLabelText('Select meridiem')
-      .scrollIntoView({ easing: 'linear', duration: 500 })
-      .within(() => {
-        cy.get(`[aria-label="PM"]`).click();
-      });
+      .as('selectMeridiem')
+      .scrollIntoView({ duration: 500, easing: 'linear' });
+    cy.get('@selectMeridiem').within(() => {
+      cy.get(`[aria-label="PM"]`).click();
+    });
 
     // Click the "Apply" button to confirm the start date and time
     ui.button
@@ -312,7 +316,9 @@ describe('Integration tests for verifying Cloudpulse custom and preset configura
 
     // Assert that the start date and time is correctly displayed
     cy.findByPlaceholderText('Select Start Date')
-      .scrollIntoView({ easing: 'linear' })
+      .as('selectStartDate')
+      .scrollIntoView({ easing: 'linear' });
+    cy.get('@selectStartDate')
       .should('be.visible')
       .should('have.value', `${cleanText(startActualDate)} PM`);
 
@@ -329,23 +335,29 @@ describe('Integration tests for verifying Cloudpulse custom and preset configura
       .click();
 
     // Selects the start hour, minute, and meridiem (AM/PM) in the time picker.
-    cy.findByLabelText('Select hours')
-      .scrollIntoView({ easing: 'linear', duration: 500 })
-      .within(() => {
-        cy.get(`[aria-label="${endHour} hours"]`).click();
-      });
+    cy.findByLabelText('Select hours').scrollIntoView({
+      duration: 500,
+      easing: 'linear',
+    });
+    cy.get('@selectHours').within(() => {
+      cy.get(`[aria-label="${endHour} hours"]`).click();
+    });
 
-    cy.findByLabelText('Select minutes')
-      .scrollIntoView({ easing: 'linear', duration: 500 })
-      .within(() => {
-        cy.get(`[aria-label="${endMinute} minutes"]`).click();
-      });
+    cy.findByLabelText('Select minutes').scrollIntoView({
+      duration: 500,
+      easing: 'linear',
+    });
+    cy.get('@selectMinutes').within(() => {
+      cy.get(`[aria-label="${endMinute} minutes"]`).click();
+    });
 
-    cy.findByLabelText('Select meridiem')
-      .scrollIntoView({ easing: 'linear', duration: 500 })
-      .within(() => {
-        cy.get(`[aria-label="PM"]`).click();
-      });
+    cy.findByLabelText('Select meridiem').scrollIntoView({
+      duration: 500,
+      easing: 'linear',
+    });
+    cy.get('@selectMeridiem').within(() => {
+      cy.get(`[aria-label="PM"]`).click();
+    });
 
     // Click the "Apply" button to confirm the end date and time
     ui.button
@@ -355,8 +367,10 @@ describe('Integration tests for verifying Cloudpulse custom and preset configura
       .click();
 
     // Assert that the end date and time is correctly displayed
+    cy.findByPlaceholderText('Select End Date').scrollIntoView({
+      easing: 'linear',
+    });
     cy.findByPlaceholderText('Select End Date')
-      .scrollIntoView({ easing: 'linear' })
       .should('be.visible')
       .should('have.value', `${cleanText(endActualDate)} PM`);
 
@@ -455,7 +469,7 @@ describe('Integration tests for verifying Cloudpulse custom and preset configura
   });
 
   it('Select the "Last Month" preset from the "Time Range" dropdown and verify its functionality.', () => {
-    const { start, end } = getLastMonthRange();
+    const { end, start } = getLastMonthRange();
 
     ui.autocomplete
       .findByLabel('Time Range')
@@ -486,7 +500,7 @@ describe('Integration tests for verifying Cloudpulse custom and preset configura
   });
 
   it('Select the "This Month" preset from the "Time Range" dropdown and verify its functionality.', () => {
-    const { start, end } = getThisMonthRange();
+    const { end, start } = getThisMonthRange();
 
     ui.autocomplete
       .findByLabel('Time Range')

packages/manager/cypress/e2e/core/domains/domains-empty-landing-page.spec.ts

@@ -1,5 +1,5 @@
-import { ui } from 'support/ui';
 import { mockGetDomains } from 'support/intercepts/domains';
+import { ui } from 'support/ui';
 
 describe('Domains empty landing page', () => {
   /**

packages/manager/cypress/e2e/core/domains/smoke-clone-domain.spec.ts

@@ -1,12 +1,13 @@
-import { Domain } from '@linode/api-v4';
+import { createDomain } from '@linode/api-v4/lib/domains';
 import { domainFactory } from '@src/factories';
 import { authenticate } from 'support/api/authentication';
-import { randomDomainName } from 'support/util/random';
-import { createDomain } from '@linode/api-v4/lib/domains';
 import { createDomainRecords } from 'support/constants/domains';
 import { interceptCreateDomainRecord } from 'support/intercepts/domains';
 import { ui } from 'support/ui';
 import { cleanUp } from 'support/util/cleanup';
+import { randomDomainName } from 'support/util/random';
+
+import type { Domain } from '@linode/api-v4';
 
 authenticate();
 describe('Clone a Domain', () => {
@@ -45,7 +46,8 @@ describe('Clone a Domain', () => {
           interceptCreateDomainRecord().as('apiCreateRecord');
           cy.findByText(rec.name).click();
           rec.fields.forEach((f) => {
-            cy.get(f.name).click().type(f.value);
+            cy.get(f.name).click();
+            cy.focused().type(f.value);
           });
           cy.findByText('Save').click();
           cy.wait('@apiCreateRecord');
@@ -101,18 +103,18 @@ describe('Clone a Domain', () => {
               .should('be.disabled');
 
             // Confirm that an error is displayed when entering an invalid domain name
-            cy.findByLabelText('New Domain').click().type(invalidDomainName);
+            cy.findByLabelText('New Domain').click();
+            cy.focused().type(invalidDomainName);
             ui.buttonGroup
               .findButtonByTitle('Create Domain')
               .should('be.visible')
               .should('be.enabled')
               .click();
             cy.findByText('Domain is not valid.').should('be.visible');
 
-            cy.findByLabelText('New Domain')
-              .click()
-              .clear()
-              .type(clonedDomainName);
+            cy.findByLabelText('New Domain').click();
+            cy.focused().clear();
+            cy.focused().type(clonedDomainName);
             ui.buttonGroup
               .findButtonByTitle('Create Domain')
               .should('be.visible')

packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts

@@ -1,7 +1,7 @@
 import { authenticate } from 'support/api/authentication';
 import { createDomain } from 'support/api/domains';
-import { interceptCreateDomainRecord } from 'support/intercepts/domains';
 import { createDomainRecords } from 'support/constants/domains';
+import { interceptCreateDomainRecord } from 'support/intercepts/domains';
 import { ui } from 'support/ui';
 import { cleanUp } from 'support/util/cleanup';
 
@@ -42,7 +42,8 @@ const editCaaRecord = (name: string, newValue: string) => {
   ui.actionMenuItem.findByTitle('Edit').should('be.visible').click();
 
   // Edit the value field
-  cy.findByLabelText('Value').clear().type(newValue);
+  cy.findByLabelText('Value').clear();
+  cy.focused().type(newValue);
   ui.button.findByTitle('Save').click();
 };
 

packages/manager/cypress/e2e/core/domains/smoke-create-domain.spec.ts

@@ -1,4 +1,3 @@
-import { Domain } from '@linode/api-v4';
 import { domainFactory } from '@src/factories';
 import { authenticate } from 'support/api/authentication';
 import {
@@ -8,6 +7,8 @@ import {
 import { cleanUp } from 'support/util/cleanup';
 import { randomDomainName } from 'support/util/random';
 
+import type { Domain } from '@linode/api-v4';
+
 authenticate();
 describe('Create a Domain', () => {
   before(() => {

packages/manager/cypress/e2e/core/domains/smoke-delete-domain.spec.ts

@@ -1,9 +1,10 @@
-import { Domain } from '@linode/api-v4';
+import { createDomain } from '@linode/api-v4/lib/domains';
 import { domainFactory } from '@src/factories';
 import { authenticate } from 'support/api/authentication';
-import { randomDomainName } from 'support/util/random';
-import { createDomain } from '@linode/api-v4/lib/domains';
 import { ui } from 'support/ui';
+import { randomDomainName } from 'support/util/random';
+
+import type { Domain } from '@linode/api-v4';
 
 authenticate();
 beforeEach(() => {
@@ -72,7 +73,8 @@ describe('Delete a Domain', () => {
               .findButtonByTitle('Delete Domain')
               .should('be.visible')
               .should('be.disabled');
-            cy.contains('Domain Name').click().type(domain.domain);
+            cy.contains('Domain Name').click();
+            cy.focused().type(domain.domain);
 
             ui.buttonGroup
               .findButtonByTitle('Delete Domain')