feat: [M3-10437] - Revert disabled action treatment for autogenerated LKE-E VPCs (linode#12675)

* Re-enable SubnetActionMenu actions

* Re-enable SubnetLinodeRow actions

* Update warning messages

* Re-enable buttons on VPC landing page

* Update more tests

* Added changeset: Enable action buttons for VPCs autogenerate for LKE-E

* Fix typo

* Address feedback: banner type and copy; clean up

* Fix test

* Address UX feedback: remove (Managed)

Author: mjac0bs

packages/manager/.changeset/pr-12675-changed-1754945494991.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Changed
+---
+
+Enable action buttons for VPCs autogenerated for LKE-E ([#12675](https://github.com/linode/manager/pull/12675))

packages/manager/src/features/Kubernetes/constants.ts

@@ -31,11 +31,8 @@ export const CREATE_CLUSTER_ENTERPRISE_TIER_ACL_COPY =
 export const CREATE_CLUSTER_STANDARD_TIER_ACL_COPY =
   'Enable an access control list (ACL) on your LKE cluster to restrict access to your cluster’s control plane. Only the IP addresses and ranges specified in the ACL can connect to the control plane.';
 
-export const LKE_ENTERPRISE_VPC_WARNING =
-  'This VPC has been automatically generated for your LKE Enterprise cluster. Making edits is disabled to avoid disruption to cluster communication.';
-
-export const LKE_ENTERPRISE_LINODE_VPC_CONFIG_WARNING =
-  'This VPC has been automatically generated for your LKE Enterprise cluster. Making edits may disrupt cluster communication.';
+export const LKE_ENTERPRISE_AUTOGEN_VPC_WARNING =
+  'This VPC has been automatically generated for your LKE Enterprise cluster.';
 
 export const MAX_NODES_PER_POOL_ENTERPRISE_TIER = 500; // TODO LKE-E M3-9793: Update this limit once a higher one is supported on the backend.
 export const MAX_NODES_PER_POOL_STANDARD_TIER = 100;

packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/LinodeConfigDialog.test.tsx

@@ -2,7 +2,6 @@ import { linodeConfigInterfaceFactory, linodeFactory } from '@linode/utilities';
 import React from 'react';
 
 import { linodeConfigFactory } from 'src/factories';
-import { LKE_ENTERPRISE_LINODE_VPC_CONFIG_WARNING } from 'src/features/Kubernetes/constants';
 import {
   LINODE_UNREACHABLE_HELPER_TEXT,
   NATTED_PUBLIC_IP_HELPER_TEXT,
@@ -174,24 +173,6 @@ describe('LinodeConfigDialog', () => {
 
       expect(valueReturned?.props.text).toBe(undefined);
     });
-
-    it('should return a <Notice /> with LKE_ENTERPRISE_LINODE_VPC_CONFIG_WARNING text if the Linode is associated with a LKE-E cluster', () => {
-      const valueReturned = unrecommendedConfigNoticeSelector({
-        _interface: vpcInterface,
-        isLKEEnterpriseCluster: true,
-        primaryInterfaceIndex: editableFields.interfaces.findIndex(
-          (element) => element.primary === true
-        ),
-        thisIndex: editableFields.interfaces.findIndex(
-          (element) => element.purpose === 'vpc'
-        ),
-        values: editableFields,
-      });
-
-      expect(valueReturned?.props.text).toEqual(
-        LKE_ENTERPRISE_LINODE_VPC_CONFIG_WARNING
-      );
-    });
   });
 
   it('should display the correct network interfaces', async () => {

packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/LinodeConfigDialog.tsx

@@ -44,7 +44,6 @@ import type { JSX } from 'react';
 
 import { FormLabel } from 'src/components/FormLabel';
 import { Link } from 'src/components/Link';
-import { LKE_ENTERPRISE_LINODE_VPC_CONFIG_WARNING } from 'src/features/Kubernetes/constants';
 import {
   useIsLkeEnterpriseEnabled,
   useKubernetesBetaEndpoint,
@@ -1323,10 +1322,6 @@ export const unrecommendedConfigNoticeSelector = ({
     values.interfaces &&
     values.interfaces[primaryInterfaceIndex].purpose === 'vpc';
 
-  // Return a different warning if the VPC interface was created for a LKE-E cluster
-  if (vpcInterface && isLKEEnterpriseCluster) {
-    return noticeForScenario(LKE_ENTERPRISE_LINODE_VPC_CONFIG_WARNING);
-  }
   /*
    Scenario 1:
     - the interface passed in to this function is a VPC interface

packages/manager/src/features/VPCs/VPCDetail/SubnetActionMenu.test.tsx

@@ -16,7 +16,6 @@ const props = {
   handleDelete: vi.fn(),
   handleEdit: vi.fn(),
   handleUnassignLinodes: vi.fn(),
-  isVPCLKEEnterpriseCluster: false,
   numLinodes: 1,
   numNodebalancers: 1,
   subnet: subnetFactory.build({ label: 'subnet-1' }),
@@ -106,16 +105,4 @@ describe('SubnetActionMenu', () => {
     await userEvent.click(assignButton);
     expect(props.handleAssignLinodes).toHaveBeenCalled();
   });
-
-  it('should disable action buttons if isVPCLKEEnterpriseCluster is true', async () => {
-    const updatedProps = { ...props, isVPCLKEEnterpriseCluster: true };
-    const view = renderWithTheme(<SubnetActionMenu {...updatedProps} />);
-    const actionMenu = view.getByLabelText(`Action menu for Subnet subnet-1`);
-    await userEvent.click(actionMenu);
-
-    const actionButtons = view.getAllByRole('menuitem');
-    actionButtons.forEach((button) =>
-      expect(button).toHaveAttribute('aria-disabled', 'true')
-    );
-  });
 });

packages/manager/src/features/VPCs/VPCDetail/SubnetActionMenu.tsx

@@ -14,7 +14,6 @@ interface SubnetActionHandlers {
 }
 
 interface Props extends SubnetActionHandlers {
-  isVPCLKEEnterpriseCluster: boolean;
   numLinodes: number;
   numNodebalancers: number;
   subnet: Subnet;
@@ -27,7 +26,6 @@ export const SubnetActionMenu = (props: Props) => {
     handleDelete,
     handleEdit,
     handleUnassignLinodes,
-    isVPCLKEEnterpriseCluster,
     numLinodes,
     numNodebalancers,
     subnet,
@@ -37,35 +35,31 @@ export const SubnetActionMenu = (props: Props) => {
 
   const actions: Action[] = [
     {
-      disabled: isVPCLKEEnterpriseCluster,
       onClick: () => {
         handleAssignLinodes(subnet);
       },
       title: 'Assign Linodes',
     },
     {
-      disabled: isVPCLKEEnterpriseCluster,
       onClick: () => {
         handleUnassignLinodes(subnet);
       },
       title: 'Unassign Linodes',
     },
     {
-      disabled: isVPCLKEEnterpriseCluster,
       onClick: () => {
         handleEdit(subnet);
       },
       title: 'Edit',
     },
     {
-      disabled:
-        numLinodes !== 0 || numNodebalancers !== 0 || isVPCLKEEnterpriseCluster,
+      disabled: numLinodes !== 0 || numNodebalancers !== 0,
       onClick: () => {
         handleDelete(subnet);
       },
       title: 'Delete',
       tooltip:
-        !isVPCLKEEnterpriseCluster && (numLinodes > 0 || numNodebalancers > 0)
+        numLinodes > 0 || numNodebalancers > 0
           ? `${flags.isNodebalancerVPCEnabled ? 'Resources' : 'Linodes'} assigned to a subnet must be unassigned before the subnet can be deleted.`
           : '',
     },

packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeActionMenu.test.tsx

@@ -10,7 +10,6 @@ import { SubnetLinodeActionMenu } from './SubnetLinodeActionMenu';
 const props = {
   handlePowerActionsLinode: vi.fn(),
   handleUnassignLinode: vi.fn(),
-  isVPCLKEEnterpriseCluster: false,
   linode: linodeFactory.build({ label: 'linode-1' }),
   subnet: subnetFactory.build({ label: 'subnet-1' }),
   isOffline: false,
@@ -90,20 +89,4 @@ describe('SubnetActionMenu', () => {
     await userEvent.click(unassignButton);
     expect(props.handleUnassignLinode).toHaveBeenCalled();
   });
-
-  it('should disable action buttons if isVPCLKEEnterpriseCluster is true', async () => {
-    const updatedProps = { ...props, isVPCLKEEnterpriseCluster: true };
-    const { getByLabelText, getAllByRole } = renderWithTheme(
-      <SubnetLinodeActionMenu {...updatedProps} />
-    );
-    const actionMenu = getByLabelText(
-      `Action menu for Linodes in Subnet subnet-1`
-    );
-    await userEvent.click(actionMenu);
-
-    const actionButtons = getAllByRole('menuitem');
-    actionButtons.forEach((button) =>
-      expect(button).toHaveAttribute('aria-disabled', 'true')
-    );
-  });
 });

packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeActionMenu.tsx

@@ -18,7 +18,6 @@ interface SubnetLinodeActionHandlers {
 interface Props extends SubnetLinodeActionHandlers {
   isOffline: boolean;
   isRebootNeeded: boolean;
-  isVPCLKEEnterpriseCluster: boolean;
   linode: Linode;
   showPowerButton: boolean;
   subnet: Subnet;
@@ -28,7 +27,6 @@ export const SubnetLinodeActionMenu = (props: Props) => {
   const {
     handlePowerActionsLinode,
     handleUnassignLinode,
-    isVPCLKEEnterpriseCluster,
     isOffline,
     isRebootNeeded,
     subnet,
@@ -39,7 +37,6 @@ export const SubnetLinodeActionMenu = (props: Props) => {
   const actions: ActionMenuAction[] = [];
   if (isRebootNeeded) {
     actions.push({
-      disabled: isVPCLKEEnterpriseCluster,
       onClick: () => {
         handlePowerActionsLinode(linode, 'Reboot', subnet);
       },
@@ -49,7 +46,6 @@ export const SubnetLinodeActionMenu = (props: Props) => {
 
   if (showPowerButton) {
     actions.push({
-      disabled: isVPCLKEEnterpriseCluster,
       onClick: () => {
         handlePowerActionsLinode(
           linode,
@@ -62,7 +58,6 @@ export const SubnetLinodeActionMenu = (props: Props) => {
   }
 
   actions.push({
-    disabled: isVPCLKEEnterpriseCluster,
     onClick: () => {
       handleUnassignLinode(linode, subnet);
     },

packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.test.tsx

@@ -377,31 +377,6 @@ describe('SubnetLinodeRow', () => {
     });
   });
 
-  it('should hide action-menu buttons for LKE-E Linodes', async () => {
-    queryMocks.useLinodeConfigQuery.mockReturnValue({
-      data: configurationProfile,
-    });
-
-    const { queryByText } = renderWithTheme(
-      wrapWithTableBody(
-        <SubnetLinodeRow
-          handlePowerActionsLinode={handlePowerActionsLinode}
-          handleUnassignLinode={handleUnassignLinode}
-          isVPCLKEEnterpriseCluster={true}
-          linodeId={linodeFactory1.id}
-          subnet={subnetFactory.build()}
-          subnetId={0}
-          subnetInterfaces={[{ active: true, config_id: 1, id: 1 }]}
-        />
-      )
-    );
-
-    const powerOffButton = queryByText('Power Off');
-    expect(powerOffButton).not.toBeInTheDocument();
-    const unassignLinodeButton = queryByText('Unassign Linode');
-    expect(unassignLinodeButton).not.toBeInTheDocument();
-  });
-
   it('should not display a warning icon for LKE-E Linodes', async () => {
     const subnet = subnetFactory.build({
       id: 1,

packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx

@@ -266,18 +266,15 @@ export const SubnetLinodeRow = (props: Props) => {
         )}
       </Hidden>
       <TableCell actionCell noWrap>
-        {!isVPCLKEEnterpriseCluster && (
-          <SubnetLinodeActionMenu
-            handlePowerActionsLinode={handlePowerActionsLinode}
-            handleUnassignLinode={handleUnassignLinode}
-            isOffline={isOffline}
-            isRebootNeeded={isRebootNeeded}
-            isVPCLKEEnterpriseCluster={isVPCLKEEnterpriseCluster}
-            linode={linode}
-            showPowerButton={showPowerButton}
-            subnet={subnet}
-          />
-        )}
+        <SubnetLinodeActionMenu
+          handlePowerActionsLinode={handlePowerActionsLinode}
+          handleUnassignLinode={handleUnassignLinode}
+          isOffline={isOffline}
+          isRebootNeeded={isRebootNeeded}
+          linode={linode}
+          showPowerButton={showPowerButton}
+          subnet={subnet}
+        />
       </TableCell>
     </TableRow>
   );