refactor: [M3-9616] - Move ramda dependent utils (linode#11913)

bill-akamai · hana-akamai · pmakode-akamai · web-flow · commit b8fa65b8350d · 2025-03-26T14:18:35.000-05:00
* Move isNilOrEmpty * Move createDevicesFromStrings * Resolve TS errors in createDevicesFromStrings.text.ts * Move createStringsFromDevices * Move maybeCastToNumber * Consolidate imports * Fix TS error * Added changeset: Move ramda dependent utils * Keep DevicesAsStrings type import separate for better organization * Added changeset: Migrated ramda dependent utils to @linode/utilities package * Avoid importing from @linode/utilities from within the same package * Update packages/manager/.changeset/pr-11913-added-1742915642212.md Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> * Update packages/manager/.changeset/pr-11913-added-1742915642212.md Co-authored-by: Purvesh Makode <pmakode@akamai.com> * Move utils changeset to correct spot * upcoming: [M3-9534] - Initial VPC Support in the `Add Network Interface` Drawer (linode#11887) * initial vpc and subnet select * add a shared firewallselect component * use firewall select globally * add jsdoc comments * add some testing * finish up testing for now * Added changeset: Add VPC support to the Add Network Interface Drawer * Added changeset: Added `FirewallSelect` component * Added changeset: Add test for Add Linode Interface drawer * clean up changesets * support default chips in the Firewall Select * fix spacing regression * properly handle disableClearable in the new Firewall Select * support default firewalls in the Add Interface drawer * use newer copy @coliu-akamai * fix unit test after UX tooltip changes --------- Co-authored-by: Banks Nussman <banks@nussman.us> * test: [M3-9486, M3-9487, M3-9557] - Allow Linode create tests to pass in alternative environments (linode#11886) * Delete redundant Linode Create SSH key test * Add "env:premiumPlans" test tag * Apply "env:premiumPlans" tag to Linode premium plan e2e test * Only require "Premium Plans" region capability for Premium Plans Linode create test * refactor: [M3-9617] - Move `doesRegionSupportFeature` to `utilities` package (linode#11891) * Move `doesRegionSupporFeature` to `utilities` pkg * Added changeset: Move `doesRegionSupportFeature` from `manager` to `utilities` package * Added changeset: Move `doesRegionSupportFeature` from `manager` to `utilities` package * refactor: [M3-8247] - Remove ramda from Utilities (linode#11861) * refactor: [M3-8247] - Remove ramda from Utilities * Add changeset * Add changeset * updated comment * increase coverage for isNilorEmpty() * feat: [UIE-8600] - IAM RBAC: add new drawer for unassigning role flow (linode#11893) * feat: [UIE-8600] - IAM RBAC: add new drawer for unassigning role flow * Added changeset: Add a new confirmation dialog for the unassigning role flow in IAM * fix the chip's color for dark theme * fix conflict and small improvements * upcoming: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs (linode#11812) * feat: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs * feat: [UIE-8515] - update mock data * Added changeset: DBaaS Advanced Configurations: added `getDatabaseEngineConfig` request to fetch all advanced configurations and updated types for advanced configs * Added changeset: DBaaS Advanced Configurations: added UI for existing engine options in the drawer * upcoming: [UIE-8515] - review fix * upcoming: [UIE-8515] - style update, add link * update styles after token re-organization --------- Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com> * Resolve merge conflict * Move createDevicesFromStrings * Move createStringsFromDevices * Avoid importing from @linode/utilities from within the same package * refactor: [M3-8247] - Remove ramda from Utilities (linode#11861) * refactor: [M3-8247] - Remove ramda from Utilities * Add changeset * Add changeset * updated comment * increase coverage for isNilorEmpty() * Move isNilOrEmpty * Move createDevicesFromStrings * Move createStringsFromDevices * refactor: [M3-8247] - Remove ramda from Utilities (linode#11861) * refactor: [M3-8247] - Remove ramda from Utilities * Add changeset * Add changeset * updated comment * increase coverage for isNilorEmpty() * Fix post merge conflict issues --------- Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com> Co-authored-by: Harsh Shankar Rao <hrao@akamai.com> Co-authored-by: aaleksee-akamai <aaleksee@akamai.com> Co-authored-by: mpolotsk-akamai <157619599+mpolotsk-akamai@users.noreply.github.com> Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com>
diff --git a/packages/manager/.changeset/pr-11913-removed-1742847225104.md b/packages/manager/.changeset/pr-11913-removed-1742847225104.md
@@ -0,0 +1,5 @@
+---
+"@linode/manager": Removed
+---
+
+Move ramda dependent utils ([#11913](https://github.com/linode/manager/pull/11913))
diff --git a/packages/manager/src/features/Domains/DomainDetail/DomainRecords/DomainRecordDrawerUtils.tsx b/packages/manager/src/features/Domains/DomainDetail/DomainRecords/DomainRecordDrawerUtils.tsx
@@ -1,6 +1,6 @@
 import produce from 'immer';
 
-import { maybeCastToNumber } from 'src/utilities/maybeCastToNumber';
+import { maybeCastToNumber } from '@linode/utilities';
 
 import { getInitialIPs } from '../../domainUtils';
 
diff --git a/packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/LinodeConfigDialog.tsx b/packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/LinodeConfigDialog.tsx
@@ -29,7 +29,11 @@ import {
   Typography,
   omitProps,
 } from '@linode/ui';
-import { scrollErrorIntoViewV2 } from '@linode/utilities';
+import {
+  createDevicesFromStrings,
+  createStringsFromDevices,
+  scrollErrorIntoViewV2,
+} from '@linode/utilities';
 import Grid from '@mui/material/Grid2';
 import { useTheme } from '@mui/material/styles';
 import { useQueryClient } from '@tanstack/react-query';
@@ -49,8 +53,6 @@ import {
   NOT_NATTED_HELPER_TEXT,
 } from 'src/features/VPCs/constants';
 import { useKubernetesClusterQuery } from 'src/queries/kubernetes';
-import { createDevicesFromStrings } from 'src/utilities/createDevicesFromStrings';
-import { createStringsFromDevices } from 'src/utilities/createStringsFromDevices';
 import {
   handleFieldErrors,
   handleGeneralErrors,
@@ -76,7 +78,7 @@ import type {
   Interface,
   LinodeConfigCreationData,
 } from '@linode/api-v4';
-import type { DevicesAsStrings } from 'src/utilities/createDevicesFromStrings';
+import type { DevicesAsStrings } from '@linode/utilities';
 import type { ExtendedIP } from 'src/utilities/ipUtils';
 
 interface Helpers {
diff --git a/packages/manager/src/features/Linodes/LinodesDetail/LinodeRescue/StandardRescueDialog.tsx b/packages/manager/src/features/Linodes/LinodesDetail/LinodeRescue/StandardRescueDialog.tsx
@@ -15,21 +15,20 @@ import {
   Paper,
   clamp,
 } from '@linode/ui';
-import { usePrevious } from '@linode/utilities';
+import { usePrevious, createDevicesFromStrings } from '@linode/utilities';
 import { styled, useTheme } from '@mui/material/styles';
 import { useSnackbar } from 'notistack';
 import * as React from 'react';
 
 import { useEventsPollingActions } from 'src/queries/events/events';
-import { createDevicesFromStrings } from 'src/utilities/createDevicesFromStrings';
 
 import { LinodePermissionsError } from '../LinodePermissionsError';
 import { DeviceSelection } from './DeviceSelection';
 import { RescueDescription } from './RescueDescription';
 
 import type { ExtendedDisk } from './DeviceSelection';
 import type { APIError } from '@linode/api-v4/lib/types';
-import type { DevicesAsStrings } from 'src/utilities/createDevicesFromStrings';
+import type { DevicesAsStrings } from '@linode/utilities';
 
 interface Props {
   linodeId: number | undefined;
diff --git a/packages/manager/src/features/Volumes/Drawers/VolumeDrawer/LinodeVolumeCreateForm.tsx b/packages/manager/src/features/Volumes/Drawers/VolumeDrawer/LinodeVolumeCreateForm.tsx
@@ -28,7 +28,7 @@ import {
   handleFieldErrors,
   handleGeneralErrors,
 } from 'src/utilities/formikErrorUtils';
-import { maybeCastToNumber } from 'src/utilities/maybeCastToNumber';
+import { maybeCastToNumber } from '@linode/utilities';
 import { PRICES_RELOAD_ERROR_NOTICE_TEXT } from 'src/utilities/pricing/constants';
 
 import { ConfigSelect } from './ConfigSelect';
diff --git a/packages/manager/src/features/Volumes/VolumeCreate.tsx b/packages/manager/src/features/Volumes/VolumeCreate.tsx
@@ -54,8 +54,7 @@ import {
   handleFieldErrors,
   handleGeneralErrors,
 } from 'src/utilities/formikErrorUtils';
-import { isNilOrEmpty } from 'src/utilities/isNilOrEmpty';
-import { maybeCastToNumber } from 'src/utilities/maybeCastToNumber';
+import { isNilOrEmpty, maybeCastToNumber } from '@linode/utilities';
 import { PRICES_RELOAD_ERROR_NOTICE_TEXT } from 'src/utilities/pricing/constants';
 import { reportAgreementSigningError } from 'src/utilities/reportAgreementSigningError';
 
diff --git a/packages/manager/src/utilities/formikErrorUtils.ts b/packages/manager/src/utilities/formikErrorUtils.ts
@@ -1,5 +1,5 @@
 import { getAPIErrorOrDefault } from './errorUtils';
-import { isNilOrEmpty } from './isNilOrEmpty';
+import { isNilOrEmpty } from '@linode/utilities';
 
 import type { APIError } from '@linode/api-v4/lib/types';
 import type { FormikErrors } from 'formik';
diff --git a/packages/utilities/.changeset/pr-11913-added-1742915642212.md b/packages/utilities/.changeset/pr-11913-added-1742915642212.md
@@ -0,0 +1,5 @@
+---
+"@linode/utilities": Added
+---
+
+Migrate ramda dependent utils to @linode/utilities package ([#11913](https://github.com/linode/manager/pull/11913))
diff --git a/packages/utilities/src/helpers/createDevicesFromStrings.test.ts b/packages/utilities/src/helpers/createDevicesFromStrings.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from 'vitest';
+
 import { createDevicesFromStrings } from './createDevicesFromStrings';
 
 describe('LinodeRescue', () => {
diff --git a/packages/utilities/src/helpers/createDevicesFromStrings.ts b/packages/utilities/src/helpers/createDevicesFromStrings.ts
diff --git a/packages/utilities/src/helpers/createStringsFromDevices.test.ts b/packages/utilities/src/helpers/createStringsFromDevices.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from 'vitest';
+
 import { createStringsFromDevices } from './createStringsFromDevices';
 
 describe('LinodeRescue', () => {
diff --git a/packages/utilities/src/helpers/createStringsFromDevices.ts b/packages/utilities/src/helpers/createStringsFromDevices.ts
@@ -3,7 +3,7 @@ import type {
   DiskDevice,
   VolumeDevice,
 } from '@linode/api-v4/lib/linodes';
-import type { DevicesAsStrings } from 'src/utilities/createDevicesFromStrings';
+import type { DevicesAsStrings } from './createDevicesFromStrings';
 
 const rdx = (
   result: DevicesAsStrings,
diff --git a/packages/utilities/src/helpers/index.ts b/packages/utilities/src/helpers/index.ts
@@ -5,6 +5,8 @@ export * from './arePropsEqual';
 export * from './arrayToList';
 export * from './breakpoints';
 export * from './capitalize';
+export * from './createDevicesFromStrings';
+export * from './createStringsFromDevices';
 export * from './deepStringTransform';
 export * from './doesRegionSupportFeature';
 export * from './downloadFile';
@@ -20,10 +22,12 @@ export * from './getNewRegionLabel';
 export * from './groupByTags';
 export * from './getDisplayName';
 export * from './initWindows';
+export * from './isNilOrEmpty';
 export * from './isNumber';
 export * from './isToday';
 export * from './link';
 export * from './manuallySetVPCConfigInterfacesToActive';
+export * from './maybeCastToNumber';
 export * from './metadata';
 export * from './minute-conversion';
 export * from './mockLocalStorage';
diff --git a/packages/utilities/src/helpers/isNilOrEmpty.test.ts b/packages/utilities/src/helpers/isNilOrEmpty.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from 'vitest';
+
 import { isNilOrEmpty } from './isNilOrEmpty';
 
 describe('isNilOrEmpty function', () => {
diff --git a/packages/utilities/src/helpers/isNilOrEmpty.ts b/packages/utilities/src/helpers/isNilOrEmpty.ts
diff --git a/packages/utilities/src/helpers/maybeCastToNumber.ts b/packages/utilities/src/helpers/maybeCastToNumber.ts

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@linode/manager": Removed
 +---
++
 +Move ramda dependent utils ([#11913](https://github.com/linode/manager/pull/11913))
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+import { describe, expect, it } from 'vitest';`
	`2`	`+`
`1`	`3`	`import { createDevicesFromStrings } from './createDevicesFromStrings';`
`2`	`4`
`3`	`5`	`describe('LinodeRescue', () => {`