change: [M3-10348, M3-10013] - Add/update inline docs for ACLP Alerts logic and fix Longview UI alignment issue (linode#12578)

* Add and update code comments

* Fix longview UI alignment issue

* Added changeset: Longview UI alignment issue

* Added changeset: Add/update inline docs for ACLP Alerts logic

Author: pmakode-akamai

packages/manager/.changeset/pr-12578-fixed-1753437741673.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Longview UI alignment issue ([#12578](https://github.com/linode/manager/pull/12578))

packages/manager/.changeset/pr-12578-upcoming-features-1753437780675.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add/update inline docs for ACLP Alerts logic ([#12578](https://github.com/linode/manager/pull/12578))

packages/manager/src/features/Linodes/AclpPreferenceToggle.tsx

@@ -67,6 +67,13 @@ const preferenceConfig: Record<
   },
 };
 
+/**
+ * - For Alerts, the toggle uses local state, not preferences. We do this because each Linode should manage its own alert mode individually.
+ *   - Create Linode: Toggle defaults to false (legacy mode). It's a simple UI toggle with no persistence.
+ *   - Edit Linode: Toggle defaults based on useIsLinodeAclpSubscribed (true if the Linode is already subscribed to ACLP). Still local state - not saved to preferences.
+ *
+ * - For Metrics, we use account-level preferences, since it's a global setting shared across all Linodes.
+ */
 export const AclpPreferenceToggle = (props: AclpPreferenceToggleType) => {
   const { isAlertsBetaMode, onAlertsModeChange, type } = props;
 

packages/manager/src/features/Longview/shared/InstallationInstructions.styles.ts

@@ -16,7 +16,7 @@ export const StyledInstructionGrid = styled(Grid, {
         content: "'|'",
         left: `calc(-${theme.spacing(1)} + 2px)`,
         position: 'absolute',
-        top: `calc(${theme.spacing(1)} - 3px)`,
+        top: `calc(${theme.spacing(1)} - 8px)`,
       },
       marginLeft: theme.spacing(2),
       paddingLeft: theme.spacing(2),

packages/shared/src/hooks/useIsLinodeAclpSubscribed.ts

@@ -7,14 +7,12 @@ type AclpStage = 'beta' | 'ga';
  *
  * ### Cases:
  * - Legacy alerts = 0, Beta alerts = []
- *   - Show default Legacy UI (disabled) for Beta
- *   - Show default Beta UI (disabled) for GA
+ *   - Show default Legacy UI (disabled) for Beta stage
+ *   - Show default Beta UI (disabled) for GA stage
  * - Legacy alerts > 0, Beta alerts = []
  *   - Show default Legacy UI (enabled)
  * - Legacy alerts = 0, Beta alerts has values (either system, user, or both)
- *   - Show default Beta UI
- * - Legacy alerts > 0, Beta alerts has values (either system, user, or both)
- *   - Show default Beta UI
+ *   - Show default Beta UI (enabled)
  *
  * @param linodeId - The ID of the Linode
  * @param stage - The current ACLP stage: 'beta' or 'ga'