refactor: [M3-10038] - Address Linode Create Legacy Interface type-safety (linode#12612)

## Description 📝
Refactor types so that `LinodeCreateFormValues` satisfies the `CreateLinodeSchema` type without any omitting of types

## Changes  🔄
There should be no visual changes

### Verification steps

(How to verify changes)

- [ ] Ensure Linode creation with VPC IPv4 still works as expected

Author: hana-akamai

packages/api-v4/.changeset/pr-12612-changed-1754068646618.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Removed
+---
+
+Delete `ConfigInterfaceIPv6` and use `IPv6Interface` instead ([#12612](https://github.com/linode/manager/pull/12612))

packages/api-v4/src/linodes/types.ts

@@ -195,22 +195,14 @@ export interface IPv6SLAAC {
   range: string;
 }
 
-export interface ConfigInterfaceIPv6 {
-  is_public: boolean;
-  ranges: {
-    range?: string;
-  }[];
-  slaac: IPv6SLAAC[];
-}
-
 // The legacy interface type - for Configuration Profile Interfaces
 export interface Interface {
   active: boolean;
   id: number;
   ip_ranges?: string[];
   ipam_address: null | string;
   ipv4?: ConfigInterfaceIPv4;
-  ipv6?: ConfigInterfaceIPv6;
+  ipv6?: IPv6Interface;
   label: null | string;
   primary?: boolean;
   purpose: InterfacePurpose;
@@ -225,7 +217,7 @@ export interface InterfacePayload {
    */
   ipam_address?: null | string;
   ipv4?: ConfigInterfaceIPv4;
-  ipv6?: ConfigInterfaceIPv6;
+  ipv6?: Partial<IPv6Interface>;
   /**
    * Required to specify a VLAN
    */
@@ -301,14 +293,13 @@ export interface LinodeInterfaces {
   interfaces: LinodeInterface[];
 }
 
-export interface LinodeInterfaceIPv6 {
+export interface IPv6Interface {
   is_public: boolean;
   ranges: {
     range: string;
   }[];
   slaac: IPv6SLAAC[];
 }
-
 export interface VPCInterfaceData {
   ipv4?: {
     addresses: {
@@ -318,7 +309,7 @@ export interface VPCInterfaceData {
     }[];
     ranges: { range: string }[];
   };
-  ipv6?: LinodeInterfaceIPv6;
+  ipv6?: IPv6Interface;
   subnet_id: number;
   vpc_id: number;
 }

packages/manager/.changeset/pr-12612-tech-stories-1754068469860.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Clean up types for `LinodeCreateFormValues` interface ([#12612](https://github.com/linode/manager/pull/12612))

packages/manager/src/features/Linodes/LinodeCreate/utilities.ts

@@ -190,8 +190,7 @@ const defaultInterfaces: InterfacePayload[] = [
  * For any extra values added to the form, we should make sure `getLinodeCreatePayload`
  * removes them from the payload before it is sent to the API.
  */
-export interface LinodeCreateFormValues
-  extends Omit<CreateLinodeRequest, 'maintenance_policy'> {
+export interface LinodeCreateFormValues extends CreateLinodeRequest {
   /**
    * Manually override firewall policy for sensitive users
    */
@@ -202,10 +201,8 @@ export interface LinodeCreateFormValues
   hasSignedEUAgreement?: boolean;
   /**
    * Override the interfaces type of the Linode Create flow so it only has Legacy Interfaces.
-   * `ipv4` and `ipv6` fields are only accepted for VPC interfaces and the omit type avoids
-   * `CreateLinodeSchema` type errors (see https://github.com/linode/manager/pull/11942#discussion_r2043029481)
    */
-  interfaces: InterfacePayload[] | Omit<InterfacePayload, 'ipv4' | 'ipv6'>[];
+  interfaces: InterfacePayload[];
   /**
    * The currently selected Linode (used for the Backups and Clone tabs)
    */

packages/validation/.changeset/pr-12612-tech-stories-1754068574848.md

@@ -0,0 +1,5 @@
+---
+"@linode/validation": Tech Stories
+---
+
+Clean up linode ipv6 interfaces ([#12612](https://github.com/linode/manager/pull/12612))

packages/validation/src/linodes.schema.ts

@@ -145,76 +145,31 @@ const slaacSchema = object().shape({
       message: 'Must be a /64 IPv6 network CIDR',
       test: (value) => validateIPv6PrefixLengthIs64(value),
     }),
+  address: string().required(),
 });
 
-const IPv6ConfigInterfaceRangesSchema = object({
+const VPCInterfaceIPv6RangeSchema = object({
   range: string()
-    .optional()
     .test({
       name: 'IPv6 prefix length',
       message: 'Must be a /64 IPv6 network CIDR',
       test: (value) => validateIPv6PrefixLengthIs64(value),
-    }),
+    })
+    .required(),
 });
 
-const ipv6ConfigInterface = object().when('purpose', {
-  is: 'vpc',
-  then: (schema) =>
-    schema
-      .shape({
-        slaac: array()
-          .of(slaacSchema)
-          .test({
-            name: 'slaac field must have zero or one entry',
-            message: 'ipv6.slaac field must have zero or one entry',
-            test: (value) =>
-              !value ? true : value?.length === 0 || value?.length === 1,
-          }),
-        ranges: array().of(IPv6ConfigInterfaceRangesSchema),
-        is_public: boolean(),
-      })
-      .notRequired()
-      .when('ipv4', {
-        is: (value: unknown) => value === null || value === undefined,
-        then: (schema) => schema.required(VPC_INTERFACE_IP_RULE),
-      }),
-  otherwise: (schema) =>
-    schema
-      .nullable()
-      .test({
-        name: testnameDisallowedBasedOnPurpose('VPC'),
-        message: testmessageDisallowedBasedOnPurpose('vpc', 'ipv6.slaac'),
-        test: (value: any) => {
-          if (value?.slaac) {
-            return typeof value.slaac === 'undefined';
-          }
-
-          return true;
-        },
-      })
-      .test({
-        name: testnameDisallowedBasedOnPurpose('VPC'),
-        message: testmessageDisallowedBasedOnPurpose('vpc', 'ipv6.ranges'),
-        test: (value: any) => {
-          if (value?.ranges) {
-            return typeof value.ranges === 'undefined';
-          }
-
-          return true;
-        },
-      })
-      .test({
-        name: testnameDisallowedBasedOnPurpose('VPC'),
-        message: testmessageDisallowedBasedOnPurpose('vpc', 'ipv6.is_public'),
-        test: (value: any) => {
-          if (value?.is_public) {
-            return typeof value.is_public === 'undefined';
-          }
-
-          return true;
-        },
-      }),
-});
+const ipv6Interface = object({
+  slaac: array()
+    .of(slaacSchema)
+    .test({
+      name: 'slaac field must have zero or one entry',
+      message: 'ipv6.slaac field must have zero or one entry',
+      test: (value) =>
+        !value ? true : value?.length === 0 || value?.length === 1,
+    }),
+  ranges: array().of(VPCInterfaceIPv6RangeSchema),
+  is_public: boolean(),
+}).notRequired();
 
 // This is the validation schema for legacy interfaces attached to configuration profiles
 // For new interfaces, denoted as Linode Interfaces, see CreateLinodeInterfaceSchema or ModifyLinodeInterfaceSchema
@@ -314,7 +269,7 @@ export const ConfigProfileInterfaceSchema = object().shape(
           }),
     }),
     ipv4: ipv4ConfigInterface,
-    ipv6: ipv6ConfigInterface,
+    ipv6: ipv6Interface.nonNullable(),
     ip_ranges: array()
       .of(string().defined())
       .notRequired()
@@ -385,20 +340,12 @@ export const UpdateConfigInterfaceSchema = object({
   ip_ranges: array().of(string().test(validateIP)).max(1).notRequired(),
 });
 
-// const rootPasswordValidation = string().test(
-//   'is-strong-password',
-//   'Password does not meet strength requirements.',
-//   (value: string) =>
-//     Boolean(value) && zxcvbn(value).score >= MINIMUM_PASSWORD_STRENGTH
-// );
-
 export const ResizeLinodeDiskSchema = object({
   size: number().required('Size is required.').min(1),
 });
 
 export const UpdateLinodePasswordSchema = object({
   password: string().required('Password is required.'),
-  // .concat(rootPasswordValidation)
 });
 
 const MetadataSchema = object({
@@ -629,10 +576,6 @@ const VPCInterfaceIPv4RangeSchema = object({
   range: string().required('Range is required.'),
 });
 
-const VPCInterfaceIPv6RangeSchema = object({
-  range: string().test((value) => validateIPv6PrefixLengthIs64(value)),
-});
-
 const PublicInterfaceRangeSchema = object({
   range: string().required('IPv6 range is required.').nullable(),
 });
@@ -663,11 +606,7 @@ export const CreateVPCInterfaceSchema = object({
     addresses: array().of(CreateVPCInterfaceIpv4AddressSchema),
     ranges: array().of(VPCInterfaceIPv4RangeSchema),
   }).notRequired(),
-  ipv6: object({
-    slaac: array().of(slaacSchema),
-    ranges: array().of(VPCInterfaceIPv6RangeSchema),
-    is_public: boolean(),
-  }).notRequired(),
+  ipv6: ipv6Interface,
 });
 
 export const CreateLinodeInterfaceSchema = object({