upcoming:[DI-24445] - Remove or condition when empty (linode#11967)

* upcoming:[DI-24445] - Remove or condition when empty

* upcoming:[DI-24445] - PR comment

* upcoming:[DI-24445] - Add changeset

---------

Co-authored-by: venkatmano-akamai <[email protected]>

Author: ankita-akamai

packages/manager/.changeset/pr-11967-upcoming-features-1743747392300.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Remove `or` condition in filtering of `/instances` call at CloudPulse Metrics ([#11967](https://github.com/linode/manager/pull/11967))

packages/manager/src/features/CloudPulse/Utils/FilterBuilder.test.ts

@@ -142,9 +142,7 @@ it('test getResourceSelectionProperties method', () => {
     expect(handleResourcesSelection).toBeDefined();
     expect(savePreferences).toEqual(false);
     expect(disabled).toEqual(false);
-    expect(JSON.stringify(xFilter)).toEqual(
-      '{"+and":[{"region":"us-east"}],"+or":[]}'
-    );
+    expect(JSON.stringify(xFilter)).toEqual('{"+and":[{"region":"us-east"}]}');
     expect(label).toEqual(name);
   }
 });
@@ -176,7 +174,7 @@ it('test getResourceSelectionProperties method with disabled true', () => {
     expect(handleResourcesSelection).toBeDefined();
     expect(savePreferences).toEqual(false);
     expect(disabled).toEqual(true);
-    expect(JSON.stringify(xFilter)).toEqual('{"+and":[],"+or":[]}');
+    expect(JSON.stringify(xFilter)).toEqual('{"+and":[]}');
     expect(label).toEqual(name);
   }
 });
@@ -303,7 +301,7 @@ it('test buildXfilter method', () => {
 
     result = buildXFilter(resourceSelectionConfig, {});
 
-    expect(JSON.stringify(result)).toEqual('{"+and":[],"+or":[]}');
+    expect(JSON.stringify(result)).toEqual('{"+and":[]}');
   }
 });
 

packages/manager/src/features/CloudPulse/Utils/FilterBuilder.ts

@@ -313,8 +313,10 @@ export const buildXFilter = (
       }
     });
   }
-
-  return { '+and': filters, '+or': orCondition };
+  if (orCondition.length) {
+    return { '+and': filters, '+or': orCondition };
+  }
+  return { '+and': filters };
 };
 
 /**