Skip to content

Commit d71e92e

Browse files
authored
fix: [M3-9269] - Switch LKE Node Pool footer order with pagination (linode#11639)
* Swap the footer order * Update the legacy MSW for now * Added changeset: Order of footers for paginated LKE Node Pools * Use a better factory method
1 parent 29d5ac1 commit d71e92e

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Fixed
3+
---
4+
5+
Order of footers for paginated LKE Node Pools ([#11639](https://github.com/linode/manager/pull/11639))

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/NodePoolsDisplay/NodeTable.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,14 @@ export const NodeTable = React.memo((props: Props) => {
241241
)}
242242
</TableBody>
243243
</Table>
244+
<PaginationFooter
245+
count={count}
246+
eventCategory="Node Table"
247+
handlePageChange={handlePageChange}
248+
handleSizeChange={handlePageSizeChange}
249+
page={page}
250+
pageSize={pageSize}
251+
/>
244252
<StyledTableFooter>
245253
<StyledPoolInfoBox>
246254
{isDiskEncryptionFeatureEnabled &&
@@ -265,14 +273,6 @@ export const NodeTable = React.memo((props: Props) => {
265273
</StyledPoolInfoBox>
266274
<TagCell tags={tags} updateTags={updateTags} view="inline" />
267275
</StyledTableFooter>
268-
<PaginationFooter
269-
count={count}
270-
eventCategory="Node Table"
271-
handlePageChange={handlePageChange}
272-
handleSizeChange={handlePageSizeChange}
273-
page={page}
274-
pageSize={pageSize}
275-
/>
276276
</>
277277
)}
278278
</Paginate>

packages/manager/src/mocks/serverHandlers.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ import {
4545
invoiceFactory,
4646
invoiceItemFactory,
4747
kubeEndpointFactory,
48+
kubeLinodeFactory,
4849
kubernetesAPIResponse,
4950
kubernetesVersionFactory,
5051
linodeConfigFactory,
@@ -849,9 +850,11 @@ export const handlers = [
849850
const unencryptedPools = nodePoolFactory.buildList(5, {
850851
disk_encryption: 'disabled',
851852
});
852-
nodePoolFactory.resetSequenceNumber();
853+
const paginatedPool = nodePoolFactory.build({
854+
nodes: kubeLinodeFactory.buildList(26),
855+
});
853856
return HttpResponse.json(
854-
makeResourcePage([...encryptedPools, ...unencryptedPools])
857+
makeResourcePage([...encryptedPools, ...unencryptedPools, paginatedPool])
855858
);
856859
}),
857860
http.get('*/lke/clusters/*/api-endpoints', async () => {

0 commit comments

Comments
 (0)